From: Kevin Hilman <khilman@kernel.org>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] PM QoS: Add debugfs support to view the list of constraints
Date: Mon, 15 Dec 2014 14:34:15 -0800 [thread overview]
Message-ID: <7h1to0h7a0.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1417799948-48440-1-git-send-email-d-gerlach@ti.com> (Dave Gerlach's message of "Fri, 5 Dec 2014 11:19:08 -0600")
Dave Gerlach <d-gerlach@ti.com> writes:
> From: Nishanth Menon <nm@ti.com>
>
> PM QoS requests are notoriously hard to debug and made even
> more so due to their highly dynamic nature. Having visibility
> into the internal data representation per constraint allows
> us to have much better appreciation of potential issues or
> bad usage by drivers in the system.
>
> So introduce for all classes of PM QoS, an entry in
> /sys/kernel/debug/pm_qos that shall show all the current
> requests as well as the snapshot of the value these requests
> boil down to. For example:
> ==> /sys/kernel/debug/pm_qos/cpu_dma_latency <==
> 1: 4444: Active
> 2: 2000000000: Default
> 3: 2000000000: Default
> 4: 2000000000: Default
> Type=Minimum, Value=4444, Requests: active=1 / total=4
>
> ==> /sys/kernel/debug/pm_qos/memory_bandwidth <==
> Empty!
>
> ...
>
> The actual value listed will have their meaning based
> on the QoS it is on, the 'Type' indicates what logic
> it would use to collate the information - Minimum,
> Maximum, or Sum. Value is the collation of all requests.
> This interface also compares the values with the defaults
> for the QoS class and marks the ones that are
> currently active.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
A very useful feature indeed,
Acked-by: Kevin Hilman <khilman@linaro.org>
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@kernel.org>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] PM QoS: Add debugfs support to view the list of constraints
Date: Mon, 15 Dec 2014 14:34:15 -0800 [thread overview]
Message-ID: <7h1to0h7a0.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1417799948-48440-1-git-send-email-d-gerlach@ti.com> (Dave Gerlach's message of "Fri, 5 Dec 2014 11:19:08 -0600")
Dave Gerlach <d-gerlach@ti.com> writes:
> From: Nishanth Menon <nm@ti.com>
>
> PM QoS requests are notoriously hard to debug and made even
> more so due to their highly dynamic nature. Having visibility
> into the internal data representation per constraint allows
> us to have much better appreciation of potential issues or
> bad usage by drivers in the system.
>
> So introduce for all classes of PM QoS, an entry in
> /sys/kernel/debug/pm_qos that shall show all the current
> requests as well as the snapshot of the value these requests
> boil down to. For example:
> ==> /sys/kernel/debug/pm_qos/cpu_dma_latency <==
> 1: 4444: Active
> 2: 2000000000: Default
> 3: 2000000000: Default
> 4: 2000000000: Default
> Type=Minimum, Value=4444, Requests: active=1 / total=4
>
> ==> /sys/kernel/debug/pm_qos/memory_bandwidth <==
> Empty!
>
> ...
>
> The actual value listed will have their meaning based
> on the QoS it is on, the 'Type' indicates what logic
> it would use to collate the information - Minimum,
> Maximum, or Sum. Value is the collation of all requests.
> This interface also compares the values with the defaults
> for the QoS class and marks the ones that are
> currently active.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
A very useful feature indeed,
Acked-by: Kevin Hilman <khilman@linaro.org>
Kevin
next prev parent reply other threads:[~2014-12-15 22:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 17:19 [PATCH] PM QoS: Add debugfs support to view the list of constraints Dave Gerlach
2014-12-05 17:19 ` Dave Gerlach
2014-12-05 22:47 ` Rafael J. Wysocki
2014-12-15 22:34 ` Kevin Hilman [this message]
2014-12-15 22:34 ` Kevin Hilman
2015-01-30 0:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h1to0h7a0.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=d-gerlach@ti.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.