* [PATCH 0/3] arm64: arch_k3: Removed ti mailbox and sci select
@ 2022-11-22 20:22 ` Nicolas Frayer
0 siblings, 0 replies; 14+ messages in thread
From: Nicolas Frayer @ 2022-11-22 20:22 UTC (permalink / raw)
To: nm, kristo, ssantosh, linux-arm-kernel, jassisinghbrar,
catalin.marinas, will, linux-kernel
Cc: khilman, glaroque, nfrayer
Removing the automatic selection of the TI message manager and the
TI sci protocol drivers from ARCH_K3 to allow module build support.
Set these 2 drivers as ARCH_K3 for the default selection.
Tested on a TI AM62x SK board.
Nicolas Frayer (3):
arm64: arch_k3: Removed ti mailbox and sci select
mailbox: config: ti-msgmgr: Default set to ARCH_K3 for TI msg manager
firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver
arch/arm64/Kconfig.platforms | 2 --
drivers/firmware/Kconfig | 1 +
drivers/mailbox/Kconfig | 1 +
3 files changed, 2 insertions(+), 2 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select
2022-11-22 20:22 ` Nicolas Frayer
@ 2022-11-22 20:22 ` Nicolas Frayer
-1 siblings, 0 replies; 14+ messages in thread
From: Nicolas Frayer @ 2022-11-22 20:22 UTC (permalink / raw)
To: nm, kristo, ssantosh, linux-arm-kernel, jassisinghbrar,
catalin.marinas, will, linux-kernel
Cc: khilman, glaroque, nfrayer
In order to build ti mailbox and ti sci as modules,
remove their automatic selection by ARCH_K3
Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
---
arch/arm64/Kconfig.platforms | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 912529ac58b3..5f16eb498dbf 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -126,8 +126,6 @@ config ARCH_K3
select PM_GENERIC_DOMAINS if PM
select MAILBOX
select SOC_TI
- select TI_MESSAGE_MANAGER
- select TI_SCI_PROTOCOL
select TI_SCI_INTR_IRQCHIP
select TI_SCI_INTA_IRQCHIP
help
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select
@ 2022-11-22 20:22 ` Nicolas Frayer
0 siblings, 0 replies; 14+ messages in thread
From: Nicolas Frayer @ 2022-11-22 20:22 UTC (permalink / raw)
To: nm, kristo, ssantosh, linux-arm-kernel, jassisinghbrar,
catalin.marinas, will, linux-kernel
Cc: khilman, glaroque, nfrayer
In order to build ti mailbox and ti sci as modules,
remove their automatic selection by ARCH_K3
Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
---
arch/arm64/Kconfig.platforms | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 912529ac58b3..5f16eb498dbf 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -126,8 +126,6 @@ config ARCH_K3
select PM_GENERIC_DOMAINS if PM
select MAILBOX
select SOC_TI
- select TI_MESSAGE_MANAGER
- select TI_SCI_PROTOCOL
select TI_SCI_INTR_IRQCHIP
select TI_SCI_INTA_IRQCHIP
help
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select
2022-11-22 20:22 ` Nicolas Frayer
@ 2022-11-24 14:29 ` Vignesh Raghavendra
-1 siblings, 0 replies; 14+ messages in thread
From: Vignesh Raghavendra @ 2022-11-24 14:29 UTC (permalink / raw)
To: Nicolas Frayer, nm, kristo, ssantosh, linux-arm-kernel,
jassisinghbrar, catalin.marinas, will, linux-kernel
Cc: khilman, glaroque
On 23/11/22 1:52 am, Nicolas Frayer wrote:
> In order to build ti mailbox and ti sci as modules,
> remove their automatic selection by ARCH_K3
>
$Subject: s/Removed/Remove,
s/ti/TI
s/sci/SCI
> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> ---
> arch/arm64/Kconfig.platforms | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 912529ac58b3..5f16eb498dbf 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -126,8 +126,6 @@ config ARCH_K3
> select PM_GENERIC_DOMAINS if PM
> select MAILBOX
> select SOC_TI
> - select TI_MESSAGE_MANAGER
> - select TI_SCI_PROTOCOL
> select TI_SCI_INTR_IRQCHIP
> select TI_SCI_INTA_IRQCHIP
> help
Why not use "imply" instead of "select". This should allow TI_SCI*
drivers to be built as modules if required. Would make 2/3 and 3/3
redundant.
Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees,
so not a great idea to post as a single series.
Regards
Vignesh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select
@ 2022-11-24 14:29 ` Vignesh Raghavendra
0 siblings, 0 replies; 14+ messages in thread
From: Vignesh Raghavendra @ 2022-11-24 14:29 UTC (permalink / raw)
To: Nicolas Frayer, nm, kristo, ssantosh, linux-arm-kernel,
jassisinghbrar, catalin.marinas, will, linux-kernel
Cc: khilman, glaroque
On 23/11/22 1:52 am, Nicolas Frayer wrote:
> In order to build ti mailbox and ti sci as modules,
> remove their automatic selection by ARCH_K3
>
$Subject: s/Removed/Remove,
s/ti/TI
s/sci/SCI
> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> ---
> arch/arm64/Kconfig.platforms | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 912529ac58b3..5f16eb498dbf 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -126,8 +126,6 @@ config ARCH_K3
> select PM_GENERIC_DOMAINS if PM
> select MAILBOX
> select SOC_TI
> - select TI_MESSAGE_MANAGER
> - select TI_SCI_PROTOCOL
> select TI_SCI_INTR_IRQCHIP
> select TI_SCI_INTA_IRQCHIP
> help
Why not use "imply" instead of "select". This should allow TI_SCI*
drivers to be built as modules if required. Would make 2/3 and 3/3
redundant.
Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees,
so not a great idea to post as a single series.
Regards
Vignesh
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select
2022-11-24 14:29 ` Vignesh Raghavendra
@ 2022-11-25 10:36 ` Nicolas Frayer
-1 siblings, 0 replies; 14+ messages in thread
From: Nicolas Frayer @ 2022-11-25 10:36 UTC (permalink / raw)
To: Vignesh Raghavendra
Cc: nm, kristo, ssantosh, linux-arm-kernel, jassisinghbrar,
catalin.marinas, will, linux-kernel, khilman, glaroque
Le jeu. 24 nov. 2022 à 15:29, Vignesh Raghavendra <vigneshr@ti.com> a écrit :
>
>
>
> On 23/11/22 1:52 am, Nicolas Frayer wrote:
> > In order to build ti mailbox and ti sci as modules,
> > remove their automatic selection by ARCH_K3
> >
>
> $Subject: s/Removed/Remove,
> s/ti/TI
> s/sci/SCI
>
> > Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> > ---
> > arch/arm64/Kconfig.platforms | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > index 912529ac58b3..5f16eb498dbf 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -126,8 +126,6 @@ config ARCH_K3
> > select PM_GENERIC_DOMAINS if PM
> > select MAILBOX
> > select SOC_TI
> > - select TI_MESSAGE_MANAGER
> > - select TI_SCI_PROTOCOL
> > select TI_SCI_INTR_IRQCHIP
> > select TI_SCI_INTA_IRQCHIP
> > help
>
>
> Why not use "imply" instead of "select". This should allow TI_SCI*
> drivers to be built as modules if required. Would make 2/3 and 3/3
> redundant.
>
> Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees,
> so not a great idea to post as a single series.
>
> Regards
> Vignesh
Thanks Vignesh, I'll send a v2 using imply and drop 2/3 and 3/3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select
@ 2022-11-25 10:36 ` Nicolas Frayer
0 siblings, 0 replies; 14+ messages in thread
From: Nicolas Frayer @ 2022-11-25 10:36 UTC (permalink / raw)
To: Vignesh Raghavendra
Cc: nm, kristo, ssantosh, linux-arm-kernel, jassisinghbrar,
catalin.marinas, will, linux-kernel, khilman, glaroque
Le jeu. 24 nov. 2022 à 15:29, Vignesh Raghavendra <vigneshr@ti.com> a écrit :
>
>
>
> On 23/11/22 1:52 am, Nicolas Frayer wrote:
> > In order to build ti mailbox and ti sci as modules,
> > remove their automatic selection by ARCH_K3
> >
>
> $Subject: s/Removed/Remove,
> s/ti/TI
> s/sci/SCI
>
> > Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> > ---
> > arch/arm64/Kconfig.platforms | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > index 912529ac58b3..5f16eb498dbf 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -126,8 +126,6 @@ config ARCH_K3
> > select PM_GENERIC_DOMAINS if PM
> > select MAILBOX
> > select SOC_TI
> > - select TI_MESSAGE_MANAGER
> > - select TI_SCI_PROTOCOL
> > select TI_SCI_INTR_IRQCHIP
> > select TI_SCI_INTA_IRQCHIP
> > help
>
>
> Why not use "imply" instead of "select". This should allow TI_SCI*
> drivers to be built as modules if required. Would make 2/3 and 3/3
> redundant.
>
> Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees,
> so not a great idea to post as a single series.
>
> Regards
> Vignesh
Thanks Vignesh, I'll send a v2 using imply and drop 2/3 and 3/3
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] mailbox: config: ti-msgmgr: Default set to ARCH_K3 for TI msg manager
2022-11-22 20:22 ` Nicolas Frayer
@ 2022-11-22 20:22 ` Nicolas Frayer
-1 siblings, 0 replies; 14+ messages in thread
From: Nicolas Frayer @ 2022-11-22 20:22 UTC (permalink / raw)
To: nm, kristo, ssantosh, linux-arm-kernel, jassisinghbrar,
catalin.marinas, will, linux-kernel
Cc: khilman, glaroque, nfrayer
Defaulting the build to ARCH_K3 for the TI message manager driver.
Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
---
drivers/mailbox/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index d7af896cbd7b..04c442532b70 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -136,6 +136,7 @@ config STI_MBOX
config TI_MESSAGE_MANAGER
tristate "Texas Instruments Message Manager Driver"
depends on ARCH_KEYSTONE || ARCH_K3
+ default ARCH_K3
help
An implementation of Message Manager slave driver for Keystone
and K3 architecture SoCs from Texas Instruments. Message Manager
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/3] mailbox: config: ti-msgmgr: Default set to ARCH_K3 for TI msg manager
@ 2022-11-22 20:22 ` Nicolas Frayer
0 siblings, 0 replies; 14+ messages in thread
From: Nicolas Frayer @ 2022-11-22 20:22 UTC (permalink / raw)
To: nm, kristo, ssantosh, linux-arm-kernel, jassisinghbrar,
catalin.marinas, will, linux-kernel
Cc: khilman, glaroque, nfrayer
Defaulting the build to ARCH_K3 for the TI message manager driver.
Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
---
drivers/mailbox/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index d7af896cbd7b..04c442532b70 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -136,6 +136,7 @@ config STI_MBOX
config TI_MESSAGE_MANAGER
tristate "Texas Instruments Message Manager Driver"
depends on ARCH_KEYSTONE || ARCH_K3
+ default ARCH_K3
help
An implementation of Message Manager slave driver for Keystone
and K3 architecture SoCs from Texas Instruments. Message Manager
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/3] firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver
2022-11-22 20:22 ` Nicolas Frayer
@ 2022-11-22 20:22 ` Nicolas Frayer
-1 siblings, 0 replies; 14+ messages in thread
From: Nicolas Frayer @ 2022-11-22 20:22 UTC (permalink / raw)
To: nm, kristo, ssantosh, linux-arm-kernel, jassisinghbrar,
catalin.marinas, will, linux-kernel
Cc: khilman, glaroque, nfrayer
Defaulting the build to ARCH_K3 for the TI SCI driver.
Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
---
drivers/firmware/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index b59e3041fd62..9e29055f62ba 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -261,6 +261,7 @@ config SYSFB_SIMPLEFB
config TI_SCI_PROTOCOL
tristate "TI System Control Interface (TISCI) Message Protocol"
depends on TI_MESSAGE_MANAGER
+ default ARCH_K3
help
TI System Control Interface (TISCI) Message Protocol is used to manage
compute systems such as ARM, DSP etc with the system controller in
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/3] firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver
@ 2022-11-22 20:22 ` Nicolas Frayer
0 siblings, 0 replies; 14+ messages in thread
From: Nicolas Frayer @ 2022-11-22 20:22 UTC (permalink / raw)
To: nm, kristo, ssantosh, linux-arm-kernel, jassisinghbrar,
catalin.marinas, will, linux-kernel
Cc: khilman, glaroque, nfrayer
Defaulting the build to ARCH_K3 for the TI SCI driver.
Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
---
drivers/firmware/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index b59e3041fd62..9e29055f62ba 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -261,6 +261,7 @@ config SYSFB_SIMPLEFB
config TI_SCI_PROTOCOL
tristate "TI System Control Interface (TISCI) Message Protocol"
depends on TI_MESSAGE_MANAGER
+ default ARCH_K3
help
TI System Control Interface (TISCI) Message Protocol is used to manage
compute systems such as ARM, DSP etc with the system controller in
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] arm64: arch_k3: Removed ti mailbox and sci select
2022-11-22 20:22 ` Nicolas Frayer
@ 2022-11-22 22:46 ` Kevin Hilman
-1 siblings, 0 replies; 14+ messages in thread
From: Kevin Hilman @ 2022-11-22 22:46 UTC (permalink / raw)
To: Nicolas Frayer, nm, kristo, ssantosh, linux-arm-kernel,
jassisinghbrar, catalin.marinas, will, linux-kernel
Cc: glaroque, nfrayer
Nicolas Frayer <nfrayer@baylibre.com> writes:
> Removing the automatic selection of the TI message manager and the
> TI sci protocol drivers from ARCH_K3 to allow module build support.
> Set these 2 drivers as ARCH_K3 for the default selection.
> Tested on a TI AM62x SK board.
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
In the future, please include linux-omap@vger.kernel.org list, which is
where more developers for these K3 platforms hang out and you might get
more review & testing.
Thanks,
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] arm64: arch_k3: Removed ti mailbox and sci select
@ 2022-11-22 22:46 ` Kevin Hilman
0 siblings, 0 replies; 14+ messages in thread
From: Kevin Hilman @ 2022-11-22 22:46 UTC (permalink / raw)
To: Nicolas Frayer, nm, kristo, ssantosh, linux-arm-kernel,
jassisinghbrar, catalin.marinas, will, linux-kernel
Cc: glaroque, nfrayer
Nicolas Frayer <nfrayer@baylibre.com> writes:
> Removing the automatic selection of the TI message manager and the
> TI sci protocol drivers from ARCH_K3 to allow module build support.
> Set these 2 drivers as ARCH_K3 for the default selection.
> Tested on a TI AM62x SK board.
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
In the future, please include linux-omap@vger.kernel.org list, which is
where more developers for these K3 platforms hang out and you might get
more review & testing.
Thanks,
Kevin
^ permalink raw reply [flat|nested] 14+ messages in thread