All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kevin Hilman" <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, u-boot@lists.denx.de
Cc: u-boot-amlogic@groups.io, nick@khadas.com,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH 4/4] board: amlogic: vim3: add support for dynamic PCIe enable
Date: Fri, 18 Sep 2020 10:59:15 -0700	[thread overview]
Message-ID: <7h4knvdkzw.fsf@baylibre.com> (raw)
In-Reply-To: <20200918092902.28028-5-narmstrong@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> The VIM3 on-board  MCU can mux the PCIe/USB3.0 shared differential
> lines using a FUSB340TMX USB 3.1 SuperSpeed Data Switch between
> an USB3.0 Type A connector and a M.2 Key M slot.
> The PHY driving these differential lines is shared between
> the USB3.0 controller and the PCIe Controller, thus only
> a single controller can use it.
>
> This adds this dynamic switching right before booting Linux.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  board/amlogic/vim3/vim3.c      | 116 +++++++++++++++++++++++++++++++++
>  configs/khadas-vim3_defconfig  |   3 +
>  configs/khadas-vim3l_defconfig |   3 +
>  3 files changed, 122 insertions(+)
>
> diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c
> index 02d8cd0ce0..cf730fa0d1 100644
> --- a/board/amlogic/vim3/vim3.c
> +++ b/board/amlogic/vim3/vim3.c
> @@ -11,6 +11,122 @@
>  #include <net.h>
>  #include <asm/io.h>
>  #include <asm/arch/eth.h>
> +#include <i2c.h>
> +#include "khadas-mcu.h"

This file doesn't exist in this series, so it doesn't compile.

Copying it from Linux, it compiles and works fine.

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: u-boot@lists.denx.de
Subject: [PATCH 4/4] board: amlogic: vim3: add support for dynamic PCIe enable
Date: Fri, 18 Sep 2020 10:59:15 -0700	[thread overview]
Message-ID: <7h4knvdkzw.fsf@baylibre.com> (raw)
In-Reply-To: <20200918092902.28028-5-narmstrong@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> The VIM3 on-board  MCU can mux the PCIe/USB3.0 shared differential
> lines using a FUSB340TMX USB 3.1 SuperSpeed Data Switch between
> an USB3.0 Type A connector and a M.2 Key M slot.
> The PHY driving these differential lines is shared between
> the USB3.0 controller and the PCIe Controller, thus only
> a single controller can use it.
>
> This adds this dynamic switching right before booting Linux.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  board/amlogic/vim3/vim3.c      | 116 +++++++++++++++++++++++++++++++++
>  configs/khadas-vim3_defconfig  |   3 +
>  configs/khadas-vim3l_defconfig |   3 +
>  3 files changed, 122 insertions(+)
>
> diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c
> index 02d8cd0ce0..cf730fa0d1 100644
> --- a/board/amlogic/vim3/vim3.c
> +++ b/board/amlogic/vim3/vim3.c
> @@ -11,6 +11,122 @@
>  #include <net.h>
>  #include <asm/io.h>
>  #include <asm/arch/eth.h>
> +#include <i2c.h>
> +#include "khadas-mcu.h"

This file doesn't exist in this series, so it doesn't compile.

Copying it from Linux, it compiles and works fine.

Kevin

  reply	other threads:[~2020-09-18 17:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18  9:28 [PATCH 0/4] amlogic: vim3: add support for dynamic PCIe enable Neil Armstrong
2020-09-18  9:28 ` Neil Armstrong
2020-09-18  9:28 ` [PATCH 1/4] ARM: dts: sync amlogic G12A/SM1 DT from Linux 5.9-rc1 Neil Armstrong
2020-09-18  9:28   ` Neil Armstrong
2020-09-18  9:29 ` [PATCH 2/4] board: amlogic: add a vim3 specific board support Neil Armstrong
2020-09-18  9:29   ` Neil Armstrong
2020-09-18  9:29 ` [PATCH 3/4] configs: vim3: use the vim3 " Neil Armstrong
2020-09-18  9:29   ` Neil Armstrong
2020-09-18  9:29 ` [PATCH 4/4] board: amlogic: vim3: add support for dynamic PCIe enable Neil Armstrong
2020-09-18  9:29   ` Neil Armstrong
2020-09-18 17:59   ` Kevin Hilman [this message]
2020-09-18 17:59     ` Kevin Hilman
2020-09-18 17:59 ` [PATCH 0/4] " Kevin Hilman
2020-09-18 17:59   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7h4knvdkzw.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=narmstrong@baylibre.com \
    --cc=nick@khadas.com \
    --cc=u-boot-amlogic@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.