From: Kevin Hilman <khilman@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Mark Brown <broonie@kernel.org>, Wolfram Sang <wsa@the-dreams.de>,
Russell King <linux@arm.linux.org.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jack Dai <jack.dai@rock-chips.com>,
Jinkun Hong <jinkun.hong@rock-chips.com>,
Aaron Lu <aaron.lu@intel.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Subject: Re: [PATCH] PM / Domains: Change prototype for the ->attach_dev() callback
Date: Thu, 30 Oct 2014 13:38:30 -0700 [thread overview]
Message-ID: <7h4mul9ttl.fsf@deeprootsystems.com> (raw)
In-Reply-To: <3981560.mBph1QJkfl@vostro.rjw.lan> (Rafael J. Wysocki's message of "Thu, 30 Oct 2014 21:04:15 +0100")
"Rafael J. Wysocki" <rjw@rjwysocki.net> writes:
> On Thursday, October 30, 2014 01:02:49 PM Ulf Hansson wrote:
>> Convert the prototype to return and int. This is just an initial step,
>> needed to support error handling.
>>
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Kevin Hilman <khilman@linaro.org>
>>
>> This patch is intended as fix for 3.18 rc[n]. Why?
>>
>> There are other SOC specific patches around that adds genpd support and which
>> implements the ->attach_dev() callback. To prevent having an "atomic" patch
>> during the next release cycle, let's change the prototype now instead.
>>
>> Further patches will add the actual error handling in genpd and these can then
>> be reviewed and tested thoroughly.
>
> So we have no users of ->attach_dev at the moment, right?
Not in mainline, but there are a couple getting ready to hit -next, so
we wanted to fix this before they arrive so that adding the error
handling will be easier.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PM / Domains: Change prototype for the ->attach_dev() callback
Date: Thu, 30 Oct 2014 13:38:30 -0700 [thread overview]
Message-ID: <7h4mul9ttl.fsf@deeprootsystems.com> (raw)
In-Reply-To: <3981560.mBph1QJkfl@vostro.rjw.lan> (Rafael J. Wysocki's message of "Thu, 30 Oct 2014 21:04:15 +0100")
"Rafael J. Wysocki" <rjw@rjwysocki.net> writes:
> On Thursday, October 30, 2014 01:02:49 PM Ulf Hansson wrote:
>> Convert the prototype to return and int. This is just an initial step,
>> needed to support error handling.
>>
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Kevin Hilman <khilman@linaro.org>
>>
>> This patch is intended as fix for 3.18 rc[n]. Why?
>>
>> There are other SOC specific patches around that adds genpd support and which
>> implements the ->attach_dev() callback. To prevent having an "atomic" patch
>> during the next release cycle, let's change the prototype now instead.
>>
>> Further patches will add the actual error handling in genpd and these can then
>> be reviewed and tested thoroughly.
>
> So we have no users of ->attach_dev at the moment, right?
Not in mainline, but there are a couple getting ready to hit -next, so
we wanted to fix this before they arrive so that adding the error
handling will be easier.
Kevin
next prev parent reply other threads:[~2014-10-30 20:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 12:02 [PATCH] PM / Domains: Change prototype for the ->attach_dev() callback Ulf Hansson
2014-10-30 12:02 ` Ulf Hansson
2014-10-30 12:17 ` Geert Uytterhoeven
2014-10-30 12:17 ` Geert Uytterhoeven
2014-10-30 12:28 ` Pavel Machek
2014-10-30 12:28 ` Pavel Machek
2014-10-30 20:04 ` Rafael J. Wysocki
2014-10-30 20:04 ` Rafael J. Wysocki
2014-10-30 20:38 ` Kevin Hilman [this message]
2014-10-30 20:38 ` Kevin Hilman
2014-11-05 1:33 ` Dmitry Torokhov
2014-11-05 1:33 ` Dmitry Torokhov
2014-11-05 7:43 ` Geert Uytterhoeven
2014-11-05 7:43 ` Geert Uytterhoeven
2014-11-05 7:54 ` Dmitry Torokhov
2014-11-05 7:54 ` Dmitry Torokhov
2014-11-05 22:43 ` Kevin Hilman
2014-11-05 22:43 ` Kevin Hilman
2014-11-05 22:49 ` Dmitry Torokhov
2014-11-05 22:49 ` Dmitry Torokhov
2014-11-05 23:21 ` Rafael J. Wysocki
2014-11-05 23:21 ` Rafael J. Wysocki
2014-11-05 23:11 ` Kevin Hilman
2014-11-05 23:11 ` Kevin Hilman
2014-11-06 0:54 ` Rafael J. Wysocki
2014-11-06 0:54 ` Rafael J. Wysocki
2014-11-14 8:17 ` Geert Uytterhoeven
2014-11-14 8:17 ` Geert Uytterhoeven
2014-11-06 7:36 ` Geert Uytterhoeven
2014-11-06 7:36 ` Geert Uytterhoeven
2014-11-06 9:55 ` Ulf Hansson
2014-11-06 9:55 ` Ulf Hansson
2014-11-14 23:48 ` Rafael J. Wysocki
2014-11-14 23:48 ` Rafael J. Wysocki
2014-11-15 11:32 ` Geert Uytterhoeven
2014-11-15 11:32 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h4mul9ttl.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=aaron.lu@intel.com \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=jack.dai@rock-chips.com \
--cc=jinkun.hong@rock-chips.com \
--cc=kgene.kim@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=pavel@ucw.cz \
--cc=philipp.zabel@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=s.nawrocki@samsung.com \
--cc=stern@rowland.harvard.edu \
--cc=tomasz.figa@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.