From: Kevin Hilman <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/3] i2c/at91: adopt pinctrl support
Date: Mon, 20 Oct 2014 11:17:43 -0700 [thread overview]
Message-ID: <7h4muyfvw8.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1413776535-10123-4-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> (Wenyou Yang's message of "Mon, 20 Oct 2014 11:42:14 +0800")
Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> writes:
> Amend the i2c at91 pin controller to optionally take a pin control
> handle and set the state of the pins to:
>
> - "default" on boot, resume and before performing an transfer
> - "sleep" on suspend()
>
> This should make it possible to optimize energy usage for the pins
> both for the suspend/resume cycle
>
> Signed-off-by: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
This patch is a good example of why you should just have the ->suspend
function call the same function as ->runtime_suspend.
If you do that, rather than having to add the pinctrl_pm* calls bo both
system PM and runtime PM functions, you could've just added them to the
runtime PM functions.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] i2c/at91: adopt pinctrl support
Date: Mon, 20 Oct 2014 11:17:43 -0700 [thread overview]
Message-ID: <7h4muyfvw8.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1413776535-10123-4-git-send-email-wenyou.yang@atmel.com> (Wenyou Yang's message of "Mon, 20 Oct 2014 11:42:14 +0800")
Wenyou Yang <wenyou.yang@atmel.com> writes:
> Amend the i2c at91 pin controller to optionally take a pin control
> handle and set the state of the pins to:
>
> - "default" on boot, resume and before performing an transfer
> - "sleep" on suspend()
>
> This should make it possible to optimize energy usage for the pins
> both for the suspend/resume cycle
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
This patch is a good example of why you should just have the ->suspend
function call the same function as ->runtime_suspend.
If you do that, rather than having to add the pinctrl_pm* calls bo both
system PM and runtime PM functions, you could've just added them to the
runtime PM functions.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@kernel.org>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: <wsa@the-dreams.de>, <ludovic.desroches@atmel.com>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<nicolas.ferre@atmel.com>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] i2c/at91: adopt pinctrl support
Date: Mon, 20 Oct 2014 11:17:43 -0700 [thread overview]
Message-ID: <7h4muyfvw8.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1413776535-10123-4-git-send-email-wenyou.yang@atmel.com> (Wenyou Yang's message of "Mon, 20 Oct 2014 11:42:14 +0800")
Wenyou Yang <wenyou.yang@atmel.com> writes:
> Amend the i2c at91 pin controller to optionally take a pin control
> handle and set the state of the pins to:
>
> - "default" on boot, resume and before performing an transfer
> - "sleep" on suspend()
>
> This should make it possible to optimize energy usage for the pins
> both for the suspend/resume cycle
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
This patch is a good example of why you should just have the ->suspend
function call the same function as ->runtime_suspend.
If you do that, rather than having to add the pinctrl_pm* calls bo both
system PM and runtime PM functions, you could've just added them to the
runtime PM functions.
Kevin
next prev parent reply other threads:[~2014-10-20 18:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 3:42 [PATCH 0/3] i2c/at91: add support PM functions Wenyou Yang
2014-10-20 3:42 ` Wenyou Yang
2014-10-20 3:42 ` Wenyou Yang
[not found] ` <1413776535-10123-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2014-10-20 3:42 ` [PATCH 1/3] i2c/at91: add support for runtime PM Wenyou Yang
2014-10-20 3:42 ` Wenyou Yang
2014-10-20 3:42 ` Wenyou Yang
[not found] ` <1413776535-10123-2-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2014-10-20 12:39 ` Ludovic Desroches
2014-10-20 12:39 ` Ludovic Desroches
2014-10-20 12:39 ` Ludovic Desroches
2014-10-20 13:14 ` Ludovic Desroches
2014-10-20 13:14 ` Ludovic Desroches
2014-10-20 13:14 ` Ludovic Desroches
2014-10-21 0:56 ` Yang, Wenyou
2014-10-21 0:56 ` Yang, Wenyou
2014-10-21 0:56 ` Yang, Wenyou
2014-10-20 3:42 ` [PATCH 2/3] i2c/at91: add support for system PM Wenyou Yang
2014-10-20 3:42 ` Wenyou Yang
2014-10-20 3:42 ` Wenyou Yang
2014-10-20 12:42 ` Ludovic Desroches
2014-10-20 12:42 ` Ludovic Desroches
2014-10-20 12:42 ` Ludovic Desroches
2014-10-20 13:15 ` Ludovic Desroches
2014-10-20 13:15 ` Ludovic Desroches
2014-10-20 13:15 ` Ludovic Desroches
[not found] ` <1413776535-10123-3-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2014-10-20 18:15 ` Kevin Hilman
2014-10-20 18:15 ` Kevin Hilman
2014-10-20 18:15 ` Kevin Hilman
2014-10-21 1:25 ` Yang, Wenyou
2014-10-21 1:25 ` Yang, Wenyou
2014-10-20 3:42 ` [PATCH 3/3] i2c/at91: adopt pinctrl support Wenyou Yang
2014-10-20 3:42 ` Wenyou Yang
2014-10-20 3:42 ` Wenyou Yang
[not found] ` <1413776535-10123-4-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2014-10-20 12:43 ` Ludovic Desroches
2014-10-20 12:43 ` Ludovic Desroches
2014-10-20 12:43 ` Ludovic Desroches
2014-10-20 18:17 ` Kevin Hilman [this message]
2014-10-20 18:17 ` Kevin Hilman
2014-10-20 18:17 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h4muyfvw8.fsf@deeprootsystems.com \
--to=khilman-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.