All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@kernel.org>
To: Tim Bird <tim.bird@sonymobile.com>
Cc: Kumar Gala <galak@codeaurora.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	Bjorn Andersson <Bjorn.Andersson@sonymobile.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"arnd.bergmann@linaro.org" <arnd.bergmann@linaro.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: Add initial DTS file for Sony Xperia Z1
Date: Wed, 24 Sep 2014 17:10:05 -0700	[thread overview]
Message-ID: <7h61gck1b6.fsf@deeprootsystems.com> (raw)
In-Reply-To: <5422DF46.90306@sonymobile.com> (Tim Bird's message of "Wed, 24 Sep 2014 08:12:06 -0700")

Hi Tim,

Tim Bird <tim.bird@sonymobile.com> writes:

> This DTS has support for the Sony Xperia Z1 phone (codenamed Honami).
> This first version of the DTS supports just a serial console.
>
> changes from v1
>  - removed qcom,msm-id attribute
>  - removed mis-capitalized Qualcomm word
>  - changed dts file name
>  - added board-specific compatible-string
>
> Signed-off-by: Tim Bird <tim.bird@sonymobile.com>

[...]

> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b8c5cd3..0c2702e 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -343,7 +343,8 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>  	qcom-apq8074-dragonboard.dtb \
>  	qcom-apq8084-mtp.dtb \
>  	qcom-msm8660-surf.dtb \
> -	qcom-msm8960-cdp.dtb
> +	qcom-msm8960-cdp.dtb \
> +	qcom-msm8974-sony-honami-xperia.dtb

This doesn't compile becase the filename added is xperia-honami (not
honami-xperia)

After fixing that up, I was able to test it on my Z1 (Thanks Tim/Bjorn!)
but found I needed to add in the qcom,msm-id stuff first.  I guess that
will be remedied with the updated mkbootimg tool, correct?

Anyways, after fixing the filename, feel free to add:

Tested-by: Kevin Hilman <khilman@linaro.org>

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: Add initial DTS file for Sony Xperia Z1
Date: Wed, 24 Sep 2014 17:10:05 -0700	[thread overview]
Message-ID: <7h61gck1b6.fsf@deeprootsystems.com> (raw)
In-Reply-To: <5422DF46.90306@sonymobile.com> (Tim Bird's message of "Wed, 24 Sep 2014 08:12:06 -0700")

Hi Tim,

Tim Bird <tim.bird@sonymobile.com> writes:

> This DTS has support for the Sony Xperia Z1 phone (codenamed Honami).
> This first version of the DTS supports just a serial console.
>
> changes from v1
>  - removed qcom,msm-id attribute
>  - removed mis-capitalized Qualcomm word
>  - changed dts file name
>  - added board-specific compatible-string
>
> Signed-off-by: Tim Bird <tim.bird@sonymobile.com>

[...]

> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b8c5cd3..0c2702e 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -343,7 +343,8 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>  	qcom-apq8074-dragonboard.dtb \
>  	qcom-apq8084-mtp.dtb \
>  	qcom-msm8660-surf.dtb \
> -	qcom-msm8960-cdp.dtb
> +	qcom-msm8960-cdp.dtb \
> +	qcom-msm8974-sony-honami-xperia.dtb

This doesn't compile becase the filename added is xperia-honami (not
honami-xperia)

After fixing that up, I was able to test it on my Z1 (Thanks Tim/Bjorn!)
but found I needed to add in the qcom,msm-id stuff first.  I guess that
will be remedied with the updated mkbootimg tool, correct?

Anyways, after fixing the filename, feel free to add:

Tested-by: Kevin Hilman <khilman@linaro.org>

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@kernel.org>
To: Tim Bird <tim.bird@sonymobile.com>
Cc: Kumar Gala <galak@codeaurora.org>,
	"linux-arm-msm\@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	Bjorn Andersson <Bjorn.Andersson@sonymobile.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"arnd.bergmann\@linaro.org" <arnd.bergmann@linaro.org>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: Add initial DTS file for Sony Xperia Z1
Date: Wed, 24 Sep 2014 17:10:05 -0700	[thread overview]
Message-ID: <7h61gck1b6.fsf@deeprootsystems.com> (raw)
In-Reply-To: <5422DF46.90306@sonymobile.com> (Tim Bird's message of "Wed, 24 Sep 2014 08:12:06 -0700")

Hi Tim,

Tim Bird <tim.bird@sonymobile.com> writes:

> This DTS has support for the Sony Xperia Z1 phone (codenamed Honami).
> This first version of the DTS supports just a serial console.
>
> changes from v1
>  - removed qcom,msm-id attribute
>  - removed mis-capitalized Qualcomm word
>  - changed dts file name
>  - added board-specific compatible-string
>
> Signed-off-by: Tim Bird <tim.bird@sonymobile.com>

[...]

> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b8c5cd3..0c2702e 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -343,7 +343,8 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>  	qcom-apq8074-dragonboard.dtb \
>  	qcom-apq8084-mtp.dtb \
>  	qcom-msm8660-surf.dtb \
> -	qcom-msm8960-cdp.dtb
> +	qcom-msm8960-cdp.dtb \
> +	qcom-msm8974-sony-honami-xperia.dtb

This doesn't compile becase the filename added is xperia-honami (not
honami-xperia)

After fixing that up, I was able to test it on my Z1 (Thanks Tim/Bjorn!)
but found I needed to add in the qcom,msm-id stuff first.  I guess that
will be remedied with the updated mkbootimg tool, correct?

Anyways, after fixing the filename, feel free to add:

Tested-by: Kevin Hilman <khilman@linaro.org>

Kevin

  parent reply	other threads:[~2014-09-25  0:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 15:12 [PATCH v2] ARM: dts: Add initial DTS file for Sony Xperia Z1 Tim Bird
2014-09-24 15:12 ` Tim Bird
2014-09-24 15:12 ` Tim Bird
2014-09-24 18:21 ` Kumar Gala
2014-09-24 18:21   ` Kumar Gala
2014-09-24 21:38   ` Bird, Tim
2014-09-24 21:38     ` Bird, Tim
2014-09-25  0:10 ` Kevin Hilman [this message]
2014-09-25  0:10   ` Kevin Hilman
2014-09-25  0:10   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7h61gck1b6.fsf@deeprootsystems.com \
    --to=khilman@kernel.org \
    --cc=Bjorn.Andersson@sonymobile.com \
    --cc=arnd.bergmann@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim.bird@sonymobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.