* [PATCH 0/1] enable the SAR ADC for all boards based on P23x and Q20x
@ 2018-06-23 14:59 Martin Blumenstingl
2018-06-23 14:59 ` [PATCH 1/1] ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi Martin Blumenstingl
0 siblings, 1 reply; 4+ messages in thread
From: Martin Blumenstingl @ 2018-06-23 14:59 UTC (permalink / raw)
To: linus-amlogic
This is compile-tested only - the goal is to remove some duplicate code
between the P230 and Q200 boards.
As a positive side-effect we also enable the SAR ADC on the P231 and Q201
boards (the only difference to the P230 and Q200 boards seems to be that
P230 and Q200 use an external RGMII Ethernet PHY, while P231 and Q201 use
the internal PHY).
Martin Blumenstingl (1):
ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi
arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi | 12 ++++++++++++
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 12 ------------
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 12 ------------
3 files changed, 12 insertions(+), 24 deletions(-)
--
2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi
2018-06-23 14:59 [PATCH 0/1] enable the SAR ADC for all boards based on P23x and Q20x Martin Blumenstingl
@ 2018-06-23 14:59 ` Martin Blumenstingl
2018-06-26 8:06 ` Neil Armstrong
2018-06-29 21:37 ` Kevin Hilman
0 siblings, 2 replies; 4+ messages in thread
From: Martin Blumenstingl @ 2018-06-23 14:59 UTC (permalink / raw)
To: linus-amlogic
meson-gxl-s905d-p230.dts and meson-gxm-q200.dts enable the saradc node
(and configure it's vref-supply "VDDIO_AO18") in their corresponding
.dts file.
Move both (the saradc node as well as the VDDIO_AO18 regulator) to
remove some duplicate code.
As a positive side-effect this enables the saradc also for the P231 (GXL
S905D) and Q201 (GXM S912) development boards which are similar to the
P230/Q200 boards (P231 and Q201 use the internal 100Mbit/s PHY, while
P230 and Q200 have an external RGMII PHY).
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi | 12 ++++++++++++
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 12 ------------
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 12 ------------
3 files changed, 12 insertions(+), 24 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi
index 88e712ea757a..01616982af0d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi
@@ -35,6 +35,13 @@
regulator-always-on;
};
+ vddio_ao18: regulator-vddio_ao18 {
+ compatible = "regulator-fixed";
+ regulator-name = "VDDIO_AO18";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
vddio_boot: regulator-vddio_boot {
compatible = "regulator-fixed";
regulator-name = "VDDIO_BOOT";
@@ -140,6 +147,11 @@
clock-names = "clkin0";
};
+&saradc {
+ status = "okay";
+ vref-supply = <&vddio_ao18>;
+};
+
/* Wireless SDIO Module */
&sd_emmc_a {
status = "okay";
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
index a9f9bb90a877..9c5be060fd5e 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
@@ -41,13 +41,6 @@
};
};
- vddio_ao18: regulator-vddio_ao18 {
- compatible = "regulator-fixed";
- regulator-name = "VDDIO_AO18";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- };
-
hdmi-connector {
compatible = "hdmi-connector";
type = "a";
@@ -107,8 +100,3 @@
remote-endpoint = <&hdmi_connector_in>;
};
};
-
-&saradc {
- status = "okay";
- vref-supply = <&vddio_ao18>;
-};
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
index 101417298a1d..432f7a435fba 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
@@ -40,13 +40,6 @@
gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
};
};
-
- vddio_ao18: regulator-vddio_ao18 {
- compatible = "regulator-fixed";
- regulator-name = "VDDIO_AO18";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- };
};
/* Q200 has exclusive choice between internal or external PHY */
@@ -78,8 +71,3 @@
interrupts = <25 IRQ_TYPE_LEVEL_LOW>;
};
};
-
-&saradc {
- status = "okay";
- vref-supply = <&vddio_ao18>;
-};
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi
2018-06-23 14:59 ` [PATCH 1/1] ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi Martin Blumenstingl
@ 2018-06-26 8:06 ` Neil Armstrong
2018-06-29 21:37 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2018-06-26 8:06 UTC (permalink / raw)
To: linus-amlogic
On 23/06/2018 16:59, Martin Blumenstingl wrote:
> meson-gxl-s905d-p230.dts and meson-gxm-q200.dts enable the saradc node
> (and configure it's vref-supply "VDDIO_AO18") in their corresponding
> .dts file.
> Move both (the saradc node as well as the VDDIO_AO18 regulator) to
> remove some duplicate code.
>
> As a positive side-effect this enables the saradc also for the P231 (GXL
> S905D) and Q201 (GXM S912) development boards which are similar to the
> P230/Q200 boards (P231 and Q201 use the internal 100Mbit/s PHY, while
> P230 and Q200 have an external RGMII PHY).
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi | 12 ++++++++++++
> arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 12 ------------
> arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 12 ------------
> 3 files changed, 12 insertions(+), 24 deletions(-)
>
[...]
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi
2018-06-23 14:59 ` [PATCH 1/1] ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi Martin Blumenstingl
2018-06-26 8:06 ` Neil Armstrong
@ 2018-06-29 21:37 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2018-06-29 21:37 UTC (permalink / raw)
To: linus-amlogic
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> meson-gxl-s905d-p230.dts and meson-gxm-q200.dts enable the saradc node
> (and configure it's vref-supply "VDDIO_AO18") in their corresponding
> .dts file.
> Move both (the saradc node as well as the VDDIO_AO18 regulator) to
> remove some duplicate code.
>
> As a positive side-effect this enables the saradc also for the P231 (GXL
> S905D) and Q201 (GXM S912) development boards which are similar to the
> P230/Q200 boards (P231 and Q201 use the internal 100Mbit/s PHY, while
> P230 and Q200 have an external RGMII PHY).
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied to v4.19/dt64,
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-29 21:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-23 14:59 [PATCH 0/1] enable the SAR ADC for all boards based on P23x and Q20x Martin Blumenstingl
2018-06-23 14:59 ` [PATCH 1/1] ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi Martin Blumenstingl
2018-06-26 8:06 ` Neil Armstrong
2018-06-29 21:37 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.