From: Kevin Hilman <khilman@kernel.org>
To: Alexander Duyck <alexander.h.duyck@redhat.com>
Cc: linux-kernel@vger.kernel.org, balbi@ti.com, davem@davemloft.net,
tony@atomide.com, netdev@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [net-next PATCH] net: Reserve skb headroom and set skb->dev even if using __alloc_skb
Date: Wed, 13 May 2015 14:35:51 -0700 [thread overview]
Message-ID: <7h8ucs6tzc.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20150513203413.8252.98057.stgit@ahduyck-vm-fedora22> (Alexander Duyck's message of "Wed, 13 May 2015 13:34:13 -0700")
Alexander Duyck <alexander.h.duyck@redhat.com> writes:
> When I had inlined __alloc_rx_skb into __netdev_alloc_skb and
> __napi_alloc_skb I had overlooked the fact that there was a return in the
> __alloc_rx_skb. As a result we weren't reserving headroom or setting the
> skb->dev in certain cases. This change corrects that by adding a couple of
> jump labels to jump to depending on __alloc_skb either succeeding or failing.
>
> Fixes: 9451980a6646 ("net: Use cached copy of pfmemalloc to avoid accessing page")
> Reported-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Tested this on top of next-20150513 on an ARM/OMAP
(am335x-boneblack.dts) an it fixes the boot problem for me.
Tested-by: Kevin Hilman <khilman@linaro.org>
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [net-next PATCH] net: Reserve skb headroom and set skb->dev even if using __alloc_skb
Date: Wed, 13 May 2015 14:35:51 -0700 [thread overview]
Message-ID: <7h8ucs6tzc.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20150513203413.8252.98057.stgit@ahduyck-vm-fedora22> (Alexander Duyck's message of "Wed, 13 May 2015 13:34:13 -0700")
Alexander Duyck <alexander.h.duyck@redhat.com> writes:
> When I had inlined __alloc_rx_skb into __netdev_alloc_skb and
> __napi_alloc_skb I had overlooked the fact that there was a return in the
> __alloc_rx_skb. As a result we weren't reserving headroom or setting the
> skb->dev in certain cases. This change corrects that by adding a couple of
> jump labels to jump to depending on __alloc_skb either succeeding or failing.
>
> Fixes: 9451980a6646 ("net: Use cached copy of pfmemalloc to avoid accessing page")
> Reported-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Tested this on top of next-20150513 on an ARM/OMAP
(am335x-boneblack.dts) an it fixes the boot problem for me.
Tested-by: Kevin Hilman <khilman@linaro.org>
Kevin
next prev parent reply other threads:[~2015-05-13 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 18:27 regression with today's linux-next Felipe Balbi
2015-05-13 18:27 ` Felipe Balbi
2015-05-13 20:34 ` [net-next PATCH] net: Reserve skb headroom and set skb->dev even if using __alloc_skb Alexander Duyck
2015-05-13 20:34 ` Alexander Duyck
2015-05-13 21:35 ` Kevin Hilman [this message]
2015-05-13 21:35 ` Kevin Hilman
2015-05-14 1:43 ` Felipe Balbi
2015-05-14 1:43 ` Felipe Balbi
2015-05-14 1:43 ` Felipe Balbi
2015-05-13 22:07 ` David Miller
2015-05-13 22:07 ` David Miller
2015-05-13 20:39 ` regression with today's linux-next Kevin Hilman
2015-05-13 20:39 ` Kevin Hilman
2015-05-13 21:04 ` Eric Dumazet
2015-05-13 21:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8ucs6tzc.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=alexander.h.duyck@redhat.com \
--cc=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.