All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Jingoo Han <jg1.han@samsung.com>, Inki Dae <inki.dae@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	David Airlie <airlied@linux.ie>, Kukjin Kim <kgene@kernel.org>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fbdev@vger.kernel.org,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	stable@vger.kernel.org, Olof Johansson <olof@lixom.net>
Subject: Re: [RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other
Date: Wed, 29 Apr 2015 17:31:41 +0000	[thread overview]
Message-ID: <7h8udau9he.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1427471856-20918-1-git-send-email-k.kozlowski@samsung.com> (Krzysztof Kozlowski's message of "Fri, 27 Mar 2015 16:57:36 +0100")

Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:

> After adding display power domain for Exynos5250 in commit
> 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") the
> display on Chromebook Snow and others stopped working after boot.
>
> The reason for this suggested Andrzej Hajda: the DP clock was disabled.
> This clock is required by Display Port and is enabled by bootloader.
> However when FIMD driver probing was deferred, the display power domain
> was turned off. This effectively reset the value of DP clock enable
> register.
>
> When exynos-dp is later probed, the clock is not enabled and display is
> not properly configured:
>
> exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok
> exynos-dp 145b0000.dp-controller: unable to config video
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reported-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250")
> Cc: <stable@vger.kernel.org>
>
> ---
>
> This should fix issue reported by Javier [1][2].
>
> Tested on Chromebook Snow (Exynos 5250). More testing would be great,
> especially on other Exynos 5xxx products.

I hoped to try this on my exynos5 boards, but it doesn't seem to apply
to linux-next or to Linus' master branch.

Are there some other dependencies here?

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Jingoo Han <jg1.han@samsung.com>, Inki Dae <inki.dae@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	David Airlie <airlied@linux.ie>, Kukjin Kim <kgene@kernel.org>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fbdev@vger.kernel.org,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	stable@vger.kernel.org, Olof Johansson <olof@lixom.net>
Subject: Re: [RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other
Date: Wed, 29 Apr 2015 10:31:41 -0700	[thread overview]
Message-ID: <7h8udau9he.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1427471856-20918-1-git-send-email-k.kozlowski@samsung.com> (Krzysztof Kozlowski's message of "Fri, 27 Mar 2015 16:57:36 +0100")

Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:

> After adding display power domain for Exynos5250 in commit
> 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") the
> display on Chromebook Snow and others stopped working after boot.
>
> The reason for this suggested Andrzej Hajda: the DP clock was disabled.
> This clock is required by Display Port and is enabled by bootloader.
> However when FIMD driver probing was deferred, the display power domain
> was turned off. This effectively reset the value of DP clock enable
> register.
>
> When exynos-dp is later probed, the clock is not enabled and display is
> not properly configured:
>
> exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok
> exynos-dp 145b0000.dp-controller: unable to config video
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reported-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250")
> Cc: <stable@vger.kernel.org>
>
> ---
>
> This should fix issue reported by Javier [1][2].
>
> Tested on Chromebook Snow (Exynos 5250). More testing would be great,
> especially on other Exynos 5xxx products.

I hoped to try this on my exynos5 boards, but it doesn't seem to apply
to linux-next or to Linus' master branch.

Are there some other dependencies here?

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other
Date: Wed, 29 Apr 2015 10:31:41 -0700	[thread overview]
Message-ID: <7h8udau9he.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1427471856-20918-1-git-send-email-k.kozlowski@samsung.com> (Krzysztof Kozlowski's message of "Fri, 27 Mar 2015 16:57:36 +0100")

Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:

> After adding display power domain for Exynos5250 in commit
> 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") the
> display on Chromebook Snow and others stopped working after boot.
>
> The reason for this suggested Andrzej Hajda: the DP clock was disabled.
> This clock is required by Display Port and is enabled by bootloader.
> However when FIMD driver probing was deferred, the display power domain
> was turned off. This effectively reset the value of DP clock enable
> register.
>
> When exynos-dp is later probed, the clock is not enabled and display is
> not properly configured:
>
> exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok
> exynos-dp 145b0000.dp-controller: unable to config video
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reported-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250")
> Cc: <stable@vger.kernel.org>
>
> ---
>
> This should fix issue reported by Javier [1][2].
>
> Tested on Chromebook Snow (Exynos 5250). More testing would be great,
> especially on other Exynos 5xxx products.

I hoped to try this on my exynos5 boards, but it doesn't seem to apply
to linux-next or to Linus' master branch.

Are there some other dependencies here?

Kevin

  reply	other threads:[~2015-04-29 17:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 15:57 [RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other Krzysztof Kozlowski
2015-03-27 15:57 ` Krzysztof Kozlowski
2015-03-27 15:57 ` Krzysztof Kozlowski
2015-04-29 17:31 ` Kevin Hilman [this message]
2015-04-29 17:31   ` Kevin Hilman
2015-04-29 17:31   ` Kevin Hilman
2015-04-29 23:56   ` Krzysztof Kozlowski
2015-04-29 23:56     ` Krzysztof Kozlowski
2015-04-29 23:56     ` Krzysztof Kozlowski
2015-04-30 15:44     ` Kevin Hilman
2015-04-30 15:44       ` Kevin Hilman
2015-04-30 15:44       ` Kevin Hilman
2015-04-30 15:57       ` Olof Johansson
2015-04-30 15:57         ` Olof Johansson
2015-04-30 15:57         ` Olof Johansson
2015-04-30 16:40         ` Javier Martinez Canillas
2015-04-30 16:40           ` Javier Martinez Canillas
2015-04-30 16:40           ` Javier Martinez Canillas
2015-04-30 16:50           ` Olof Johansson
2015-04-30 16:50             ` Olof Johansson
2015-04-30 16:50             ` Olof Johansson
2015-04-30 16:50             ` Olof Johansson
2015-05-01  9:14             ` Krzysztof Kozlowski
2015-05-01  9:14               ` Krzysztof Kozlowski
2015-05-01  9:14               ` Krzysztof Kozlowski
2015-05-01  9:14               ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7h8udau9he.fsf@deeprootsystems.com \
    --to=khilman@kernel.org \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=jg1.han@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=olof@lixom.net \
    --cc=stable@vger.kernel.org \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.