From: Kevin Hilman <khilman@kernel.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Doug Anderson <dianders@chromium.org>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ARM: exynos_defconfig: re-enable USB gadget and max77802 options
Date: Thu, 09 Oct 2014 16:34:26 -0700 [thread overview]
Message-ID: <7h8ukolsvx.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1412879767-24326-1-git-send-email-javier.martinez@collabora.co.uk> (Javier Martinez Canillas's message of "Thu, 9 Oct 2014 20:36:07 +0200")
Javier Martinez Canillas <javier.martinez@collabora.co.uk> writes:
> Commit 43eeaa42e03a ("ARM: exynos_defconfig: savedefconfig") removed a
> set of Kconfig symbols. For most of them there were no functional change
> since are selected by other Kconfig options or were deprecated but some
> options are not explicitly selected so they should not had been removed.
>
> The options that have to be enabled are USB gadget and the MAX77802 PMIC
> support which were enabled in commits:
>
> 508423bebcda ("ARM: exynos_defconfig: enable USB gadget support")
> 6e80e3d87549 ("ARM: exynos_defconfig: Enable MAX77802")
>
> Enable those options to leave the config in the state before the change.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Acked-by: Kevin Hilman <khilman@linaro.org>
Tested-by: Kevin Hilman <khilman@linaro.org>
This is needed to get RTC wakeup from suspend working on
exynos5800-peach-pi.
Note that the s3c-rtc works fine, but the max77802-rtc doesn't seem to
work be functional for me:
[ 2.408178] max77802-rtc max77802-rtc: rtc core: registered max77802-rtc as rtc0
[ 3.595485] s3c-rtc 101e0000.rtc: rtc core: registered s3c as rtc1
root@(none):/# hwclock --rtc /dev/rtc0
hwclock: ioctl(RTC_RD_TIME) to /dev/rtc0 to read the time failed:
Invalid argument
root@(none):/# hwclock --rtc /dev/rtc1
Thu Oct 9 23:33:06 2014 -0.111978 seconds
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: exynos_defconfig: re-enable USB gadget and max77802 options
Date: Thu, 09 Oct 2014 16:34:26 -0700 [thread overview]
Message-ID: <7h8ukolsvx.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1412879767-24326-1-git-send-email-javier.martinez@collabora.co.uk> (Javier Martinez Canillas's message of "Thu, 9 Oct 2014 20:36:07 +0200")
Javier Martinez Canillas <javier.martinez@collabora.co.uk> writes:
> Commit 43eeaa42e03a ("ARM: exynos_defconfig: savedefconfig") removed a
> set of Kconfig symbols. For most of them there were no functional change
> since are selected by other Kconfig options or were deprecated but some
> options are not explicitly selected so they should not had been removed.
>
> The options that have to be enabled are USB gadget and the MAX77802 PMIC
> support which were enabled in commits:
>
> 508423bebcda ("ARM: exynos_defconfig: enable USB gadget support")
> 6e80e3d87549 ("ARM: exynos_defconfig: Enable MAX77802")
>
> Enable those options to leave the config in the state before the change.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Acked-by: Kevin Hilman <khilman@linaro.org>
Tested-by: Kevin Hilman <khilman@linaro.org>
This is needed to get RTC wakeup from suspend working on
exynos5800-peach-pi.
Note that the s3c-rtc works fine, but the max77802-rtc doesn't seem to
work be functional for me:
[ 2.408178] max77802-rtc max77802-rtc: rtc core: registered max77802-rtc as rtc0
[ 3.595485] s3c-rtc 101e0000.rtc: rtc core: registered s3c as rtc1
root@(none):/# hwclock --rtc /dev/rtc0
hwclock: ioctl(RTC_RD_TIME) to /dev/rtc0 to read the time failed:
Invalid argument
root@(none):/# hwclock --rtc /dev/rtc1
Thu Oct 9 23:33:06 2014 -0.111978 seconds
Kevin
next prev parent reply other threads:[~2014-10-09 23:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 18:36 [PATCH 1/1] ARM: exynos_defconfig: re-enable USB gadget and max77802 options Javier Martinez Canillas
2014-10-09 18:36 ` Javier Martinez Canillas
2014-10-09 23:34 ` Kevin Hilman [this message]
2014-10-09 23:34 ` Kevin Hilman
2014-10-10 12:25 ` Javier Martinez Canillas
2014-10-10 12:25 ` Javier Martinez Canillas
2014-10-10 22:13 ` Kevin Hilman
2014-10-10 22:13 ` Kevin Hilman
2014-10-10 22:13 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8ukolsvx.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.