From: Kevin Hilman <khilman@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Kukjin Kim <kgene.kim@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
javier.martinez@collabora.co.uk, ch.naveen@samsung.com,
jg1.han@samsung.com, jdelvare@suse.de, sjg@google.com,
paul.gortmaker@windriver.com, standby24x7@gmail.com,
sachin.kamat@linaro.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: exynos5: Properly use the "noirq" variants of suspend/resume
Date: Thu, 19 Jun 2014 11:43:11 -0700 [thread overview]
Message-ID: <7h8uosyc3k.fsf@paris.lan> (raw)
In-Reply-To: <1403155273-1057-1-git-send-email-dianders@chromium.org> (Doug Anderson's message of "Wed, 18 Jun 2014 22:21:13 -0700")
Doug Anderson <dianders@chromium.org> writes:
> The original code for the exynos i2c controller registered for the
> "noirq" variants. However during review feedback it was moved to
> SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no
> longer actually "noirq" (despite functions named
> exynos5_i2c_suspend_noirq and exynos5_i2c_resume_noirq).
>
> i2c controllers that might have wakeup sources on them seem to need to
> resume at noirq time so that the individual drivers can actually read
> the i2c bus to handle their wakeup.
I suspect usage of the noirq variants pre-dates the existence of the
late/early callbacks in the PM core, but based on the description above,
I suspect what you actually want is the late/early callbacks.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: exynos5: Properly use the "noirq" variants of suspend/resume
Date: Thu, 19 Jun 2014 11:43:11 -0700 [thread overview]
Message-ID: <7h8uosyc3k.fsf@paris.lan> (raw)
In-Reply-To: <1403155273-1057-1-git-send-email-dianders@chromium.org> (Doug Anderson's message of "Wed, 18 Jun 2014 22:21:13 -0700")
Doug Anderson <dianders@chromium.org> writes:
> The original code for the exynos i2c controller registered for the
> "noirq" variants. However during review feedback it was moved to
> SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no
> longer actually "noirq" (despite functions named
> exynos5_i2c_suspend_noirq and exynos5_i2c_resume_noirq).
>
> i2c controllers that might have wakeup sources on them seem to need to
> resume at noirq time so that the individual drivers can actually read
> the i2c bus to handle their wakeup.
I suspect usage of the noirq variants pre-dates the existence of the
late/early callbacks in the PM core, but based on the description above,
I suspect what you actually want is the late/early callbacks.
Kevin
next prev parent reply other threads:[~2014-06-19 18:43 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 5:21 [PATCH] i2c: exynos5: Properly use the "noirq" variants of suspend/resume Doug Anderson
2014-06-19 5:21 ` Doug Anderson
2014-06-19 5:21 ` Doug Anderson
2014-06-19 18:43 ` Kevin Hilman [this message]
2014-06-19 18:43 ` Kevin Hilman
2014-06-19 22:43 ` Doug Anderson
2014-06-19 22:43 ` Doug Anderson
2014-06-20 21:48 ` Kevin Hilman
2014-06-20 21:48 ` Kevin Hilman
2014-06-20 21:48 ` Kevin Hilman
[not found] ` <7hwqcbs166.fsf-4poPxKt068f/PtFMR13I2A@public.gmane.org>
2014-06-20 22:05 ` Doug Anderson
2014-06-20 22:05 ` Doug Anderson
2014-06-20 22:05 ` Doug Anderson
2014-06-20 23:13 ` Kevin Hilman
2014-06-20 23:13 ` Kevin Hilman
2014-06-20 23:13 ` Kevin Hilman
2014-06-20 23:53 ` Doug Anderson
2014-06-20 23:53 ` Doug Anderson
[not found] ` <CAD=FV=VmPMf6tCNmKJ1o5J7PyAXoU8fb6+s+Fkv18FH2WaQp7A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-20 23:59 ` Tomasz Figa
2014-06-20 23:59 ` Tomasz Figa
2014-06-20 23:59 ` Tomasz Figa
2014-06-23 22:01 ` Doug Anderson
2014-06-23 22:01 ` Doug Anderson
2014-06-23 22:19 ` Kevin Hilman
2014-06-23 22:19 ` Kevin Hilman
2014-06-23 22:19 ` Kevin Hilman
2014-06-23 22:24 ` Tomasz Figa
2014-06-23 22:24 ` Tomasz Figa
2014-06-23 22:27 ` Doug Anderson
2014-06-23 22:27 ` Doug Anderson
[not found] ` <CAD=FV=U0P2kyfnxdU2E1Gm8TdD_cFd6brmtQ7-gpajNJuKmWSA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-23 22:31 ` Tomasz Figa
2014-06-23 22:31 ` Tomasz Figa
2014-06-23 22:31 ` Tomasz Figa
[not found] ` <53A8AAC9.8030407-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-23 22:46 ` Doug Anderson
2014-06-23 22:46 ` Doug Anderson
2014-06-23 22:46 ` Doug Anderson
2014-06-23 23:35 ` Kevin Hilman
2014-06-23 23:35 ` Kevin Hilman
2014-06-23 23:35 ` Kevin Hilman
2014-06-23 22:23 ` Kevin Hilman
2014-06-23 22:23 ` Kevin Hilman
2014-06-23 22:23 ` Kevin Hilman
[not found] ` <7h38evp8ng.fsf-4poPxKt068f/PtFMR13I2A@public.gmane.org>
2014-06-23 22:42 ` Doug Anderson
2014-06-23 22:42 ` Doug Anderson
2014-06-23 22:42 ` Doug Anderson
2014-06-23 23:31 ` Kevin Hilman
2014-06-23 23:31 ` Kevin Hilman
2014-06-23 23:31 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8uosyc3k.fsf@paris.lan \
--to=khilman@linaro.org \
--cc=ch.naveen@samsung.com \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=jdelvare@suse.de \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sachin.kamat@linaro.org \
--cc=sjg@google.com \
--cc=standby24x7@gmail.com \
--cc=tomasz.figa@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.