All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Nishanth Menon <nm@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, nfrayer@baylibre.com,
	Santosh Shilimkar <ssantosh@kernel.org>
Cc: Nishanth Menon <nm@ti.com>, glaroque@baylibre.com
Subject: Re: [PATCH v6 0/2] soc: ti: k3-socinfo: Add module build support to the k3 socinfo driver
Date: Tue, 22 Nov 2022 12:48:26 -0800	[thread overview]
Message-ID: <7ha64iaf6t.fsf@baylibre.com> (raw)
In-Reply-To: <166906774215.20855.4956750581421635106.b4-ty@ti.com>

Hi Nishanth,

Nishanth Menon <nm@ti.com> writes:

> Hi Nicolas Frayer,
>
> On Thu, 17 Nov 2022 10:54:17 +0100, Nicolas Frayer wrote:
>> In order for the TI K3 SoC info driver to be built as a module, the
>> following changes have been made:
>> - Converted memory allocations to devm and added the remove callback
>> - Added necessary code to build the driver as a module
>> 
>> v2->v3:
>> dropped module conversion part of this series while other driver
>> dependencies on socinfo are worked out.
>> A dependency issue is introduced by changing subsys_initcall()
>> to module_platform_driver(). Some drivers using the socinfo information
>> probe before the socinfo driver itself and it makes their probe fail.
>> 
>> [...]
>
> I have applied the following to branch ti-drivers-soc-next on [1].
> Thank you!

Sorry for the churn here, but I think these need to be reverted.

We've discoverd some more complexities/issues when socinfo is modular,
and I think the socinfo core code needs some work before this can
actually work reliably for all socinfo users.

Basically, I think we need to finish converting all the socinfo users to
modules before we can be sure of all the corner cases when socinfo
itself is a module.

Sorry about this churn, but I think it's better to be a bit conservative
here and revert before this lands in mainline.

Thanks,

Kevin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Nishanth Menon <nm@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, nfrayer@baylibre.com,
	Santosh Shilimkar <ssantosh@kernel.org>
Cc: Nishanth Menon <nm@ti.com>, glaroque@baylibre.com
Subject: Re: [PATCH v6 0/2] soc: ti: k3-socinfo: Add module build support to the k3 socinfo driver
Date: Tue, 22 Nov 2022 12:48:26 -0800	[thread overview]
Message-ID: <7ha64iaf6t.fsf@baylibre.com> (raw)
In-Reply-To: <166906774215.20855.4956750581421635106.b4-ty@ti.com>

Hi Nishanth,

Nishanth Menon <nm@ti.com> writes:

> Hi Nicolas Frayer,
>
> On Thu, 17 Nov 2022 10:54:17 +0100, Nicolas Frayer wrote:
>> In order for the TI K3 SoC info driver to be built as a module, the
>> following changes have been made:
>> - Converted memory allocations to devm and added the remove callback
>> - Added necessary code to build the driver as a module
>> 
>> v2->v3:
>> dropped module conversion part of this series while other driver
>> dependencies on socinfo are worked out.
>> A dependency issue is introduced by changing subsys_initcall()
>> to module_platform_driver(). Some drivers using the socinfo information
>> probe before the socinfo driver itself and it makes their probe fail.
>> 
>> [...]
>
> I have applied the following to branch ti-drivers-soc-next on [1].
> Thank you!

Sorry for the churn here, but I think these need to be reverted.

We've discoverd some more complexities/issues when socinfo is modular,
and I think the socinfo core code needs some work before this can
actually work reliably for all socinfo users.

Basically, I think we need to finish converting all the socinfo users to
modules before we can be sure of all the corner cases when socinfo
itself is a module.

Sorry about this churn, but I think it's better to be a bit conservative
here and revert before this lands in mainline.

Thanks,

Kevin

  reply	other threads:[~2022-11-22 20:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  9:54 [PATCH v6 0/2] soc: ti: k3-socinfo: Add module build support to the k3 socinfo driver Nicolas Frayer
2022-11-17  9:54 ` Nicolas Frayer
2022-11-17  9:54 ` [PATCH v6 1/2] soc: ti: k3-socinfo: Convert allocations to devm Nicolas Frayer
2022-11-17  9:54   ` Nicolas Frayer
2022-11-17  9:54 ` [PATCH v6 2/2] soc: ti: k3-socinfo: Add module build support Nicolas Frayer
2022-11-17  9:54   ` Nicolas Frayer
2022-11-18 20:09 ` [PATCH v6 0/2] soc: ti: k3-socinfo: Add module build support to the k3 socinfo driver Kevin Hilman
2022-11-18 20:09   ` Kevin Hilman
2022-11-21 21:55 ` Nishanth Menon
2022-11-21 21:55   ` Nishanth Menon
2022-11-22 20:48   ` Kevin Hilman [this message]
2022-11-22 20:48     ` Kevin Hilman
2022-11-22 22:41     ` Nishanth Menon
2022-11-22 22:41       ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ha64iaf6t.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=glaroque@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfrayer@baylibre.com \
    --cc=nm@ti.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.