All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH] arm64: meson: ship only the necessary clock controllers
Date: Tue, 20 Oct 2020 08:03:16 -0700	[thread overview]
Message-ID: <7hblgxkki3.fsf@baylibre.com> (raw)
In-Reply-To: <20201020075034.172825-1-jbrunet@baylibre.com>

Jerome Brunet <jbrunet@baylibre.com> writes:

> There now the menu entries for the amlogic clock controllers.
> Do not select these when ARM64 is enabled so it possible to ship only the
> required.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  arch/arm64/Kconfig.platforms | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index cd58f8495c45..b22d1bdd6eb6 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -154,9 +154,6 @@ config ARCH_MESON
>  	bool "Amlogic Platforms"
>  	select PINCTRL
>  	select PINCTRL_MESON
> -	select COMMON_CLK_GXBB
> -	select COMMON_CLK_AXG
> -	select COMMON_CLK_G12A

This patch alone will break boot when using the default, upstream
defconfig because these options will all now be disabled and we'll have
no clock providers.

I think you also need a default value (e.g. `default y`) in
drivers/clk/meson/Kconfig for each of these entries to keep the same
defaults.   But these defaults could be overridden by SoC-specific
defconfigs leading to more flexibilty.

So, assuming you queue up a drivers/clk patch to go in when this
lands...

Acked-by: Kevin Hilman <khilman@baylibre.com>


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH] arm64: meson: ship only the necessary clock controllers
Date: Tue, 20 Oct 2020 08:03:16 -0700	[thread overview]
Message-ID: <7hblgxkki3.fsf@baylibre.com> (raw)
In-Reply-To: <20201020075034.172825-1-jbrunet@baylibre.com>

Jerome Brunet <jbrunet@baylibre.com> writes:

> There now the menu entries for the amlogic clock controllers.
> Do not select these when ARM64 is enabled so it possible to ship only the
> required.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  arch/arm64/Kconfig.platforms | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index cd58f8495c45..b22d1bdd6eb6 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -154,9 +154,6 @@ config ARCH_MESON
>  	bool "Amlogic Platforms"
>  	select PINCTRL
>  	select PINCTRL_MESON
> -	select COMMON_CLK_GXBB
> -	select COMMON_CLK_AXG
> -	select COMMON_CLK_G12A

This patch alone will break boot when using the default, upstream
defconfig because these options will all now be disabled and we'll have
no clock providers.

I think you also need a default value (e.g. `default y`) in
drivers/clk/meson/Kconfig for each of these entries to keep the same
defaults.   But these defaults could be overridden by SoC-specific
defconfigs leading to more flexibilty.

So, assuming you queue up a drivers/clk patch to go in when this
lands...

Acked-by: Kevin Hilman <khilman@baylibre.com>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: meson: ship only the necessary clock controllers
Date: Tue, 20 Oct 2020 08:03:16 -0700	[thread overview]
Message-ID: <7hblgxkki3.fsf@baylibre.com> (raw)
In-Reply-To: <20201020075034.172825-1-jbrunet@baylibre.com>

Jerome Brunet <jbrunet@baylibre.com> writes:

> There now the menu entries for the amlogic clock controllers.
> Do not select these when ARM64 is enabled so it possible to ship only the
> required.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  arch/arm64/Kconfig.platforms | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index cd58f8495c45..b22d1bdd6eb6 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -154,9 +154,6 @@ config ARCH_MESON
>  	bool "Amlogic Platforms"
>  	select PINCTRL
>  	select PINCTRL_MESON
> -	select COMMON_CLK_GXBB
> -	select COMMON_CLK_AXG
> -	select COMMON_CLK_G12A

This patch alone will break boot when using the default, upstream
defconfig because these options will all now be disabled and we'll have
no clock providers.

I think you also need a default value (e.g. `default y`) in
drivers/clk/meson/Kconfig for each of these entries to keep the same
defaults.   But these defaults could be overridden by SoC-specific
defconfigs leading to more flexibilty.

So, assuming you queue up a drivers/clk patch to go in when this
lands...

Acked-by: Kevin Hilman <khilman@baylibre.com>


  parent reply	other threads:[~2020-10-20 15:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20  7:50 [PATCH] arm64: meson: ship only the necessary clock controllers Jerome Brunet
2020-10-20  7:50 ` Jerome Brunet
2020-10-20  7:50 ` Jerome Brunet
2020-10-20 13:13 ` Neil Armstrong
2020-10-20 13:13   ` Neil Armstrong
2020-10-20 13:13   ` Neil Armstrong
2020-10-20 15:03 ` Kevin Hilman [this message]
2020-10-20 15:03   ` Kevin Hilman
2020-10-20 15:03   ` Kevin Hilman
2020-10-20 15:28   ` Jerome Brunet
2020-10-20 15:28     ` Jerome Brunet
2020-10-20 15:28     ` Jerome Brunet
2020-11-09 23:23 ` Kevin Hilman
2020-11-09 23:23   ` Kevin Hilman
2020-11-09 23:23   ` Kevin Hilman
2020-11-20 19:12 ` Kevin Hilman
2020-11-20 19:12   ` Kevin Hilman
2020-11-20 19:12   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hblgxkki3.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=catalin.marinas@arm.com \
    --cc=jbrunet@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.