From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com
Cc: jernej.skrabec@siol.net, jonas@kwiboo.se,
maxime.ripard@bootlin.com,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
hverkuil@xs4all.nl, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 5/5] drm/meson: Output in YUV444 if sink supports it
Date: Thu, 06 Jun 2019 10:16:20 -0700 [thread overview]
Message-ID: <7hblzaeisb.fsf@baylibre.com> (raw)
In-Reply-To: <20190520133753.23871-6-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> With the YUV420 handling, we can dynamically setup the HDMI output
> pixel format depending on the mode and connector info.
> So now, we can output in YUV444, which is the native video pipeline
> format, directly to the HDMI Sink if it's supported without
> necessarily involving the HDMI Controller CSC.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/gpu/drm/meson/meson_dw_hdmi.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index 5d67e2beba58..8bf9db7f39a4 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -723,12 +723,23 @@ static int meson_venc_hdmi_encoder_atomic_check(struct drm_encoder *encoder,
> struct drm_display_mode *mode = &crtc_state->mode;
> bool is_hdmi2_sink =
> conn_state->connector->display_info.hdmi.scdc.supported;
> + bool specify_out_format = false;
> + u32 out_format;
>
> if (drm_mode_is_420_only(info, mode) ||
> (!is_hdmi2_sink && drm_mode_is_420_also(info, mode)))
> dw_hdmi->input_bus_format = MEDIA_BUS_FMT_UYYVYY8_0_5X24;
> - else
> + else {
nit: if the else has {} you should add to the 'if' (even if the if side
is a single statement): c.f. end of this section of CodingStyle:
https://www.kernel.org/doc/html/latest/process/coding-style.html#placing-braces-and-spaces
> dw_hdmi->input_bus_format = MEDIA_BUS_FMT_YUV8_1X24;
> + if (info->color_formats & DRM_COLOR_FORMAT_YCRCB444) {
> + out_format = MEDIA_BUS_FMT_YUV8_1X24;
> + specify_out_format = true;
> + }
> + }
> +
> + /* Set a connector bus format if required */
> + drm_display_info_set_bus_formats(info, &out_format,
> + (specify_out_format ? 1 : 0));
>
Otherwise,
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com
Cc: jernej.skrabec@siol.net, Neil Armstrong <narmstrong@baylibre.com>,
maxime.ripard@bootlin.com, jonas@kwiboo.se,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
hverkuil@xs4all.nl, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 5/5] drm/meson: Output in YUV444 if sink supports it
Date: Thu, 06 Jun 2019 10:16:20 -0700 [thread overview]
Message-ID: <7hblzaeisb.fsf@baylibre.com> (raw)
In-Reply-To: <20190520133753.23871-6-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> With the YUV420 handling, we can dynamically setup the HDMI output
> pixel format depending on the mode and connector info.
> So now, we can output in YUV444, which is the native video pipeline
> format, directly to the HDMI Sink if it's supported without
> necessarily involving the HDMI Controller CSC.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/gpu/drm/meson/meson_dw_hdmi.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index 5d67e2beba58..8bf9db7f39a4 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -723,12 +723,23 @@ static int meson_venc_hdmi_encoder_atomic_check(struct drm_encoder *encoder,
> struct drm_display_mode *mode = &crtc_state->mode;
> bool is_hdmi2_sink =
> conn_state->connector->display_info.hdmi.scdc.supported;
> + bool specify_out_format = false;
> + u32 out_format;
>
> if (drm_mode_is_420_only(info, mode) ||
> (!is_hdmi2_sink && drm_mode_is_420_also(info, mode)))
> dw_hdmi->input_bus_format = MEDIA_BUS_FMT_UYYVYY8_0_5X24;
> - else
> + else {
nit: if the else has {} you should add to the 'if' (even if the if side
is a single statement): c.f. end of this section of CodingStyle:
https://www.kernel.org/doc/html/latest/process/coding-style.html#placing-braces-and-spaces
> dw_hdmi->input_bus_format = MEDIA_BUS_FMT_YUV8_1X24;
> + if (info->color_formats & DRM_COLOR_FORMAT_YCRCB444) {
> + out_format = MEDIA_BUS_FMT_YUV8_1X24;
> + specify_out_format = true;
> + }
> + }
> +
> + /* Set a connector bus format if required */
> + drm_display_info_set_bus_formats(info, &out_format,
> + (specify_out_format ? 1 : 0));
>
Otherwise,
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com
Cc: jernej.skrabec@siol.net, Neil Armstrong <narmstrong@baylibre.com>,
maxime.ripard@bootlin.com, jonas@kwiboo.se,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
hverkuil@xs4all.nl, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 5/5] drm/meson: Output in YUV444 if sink supports it
Date: Thu, 06 Jun 2019 10:16:20 -0700 [thread overview]
Message-ID: <7hblzaeisb.fsf@baylibre.com> (raw)
In-Reply-To: <20190520133753.23871-6-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> With the YUV420 handling, we can dynamically setup the HDMI output
> pixel format depending on the mode and connector info.
> So now, we can output in YUV444, which is the native video pipeline
> format, directly to the HDMI Sink if it's supported without
> necessarily involving the HDMI Controller CSC.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/gpu/drm/meson/meson_dw_hdmi.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index 5d67e2beba58..8bf9db7f39a4 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -723,12 +723,23 @@ static int meson_venc_hdmi_encoder_atomic_check(struct drm_encoder *encoder,
> struct drm_display_mode *mode = &crtc_state->mode;
> bool is_hdmi2_sink =
> conn_state->connector->display_info.hdmi.scdc.supported;
> + bool specify_out_format = false;
> + u32 out_format;
>
> if (drm_mode_is_420_only(info, mode) ||
> (!is_hdmi2_sink && drm_mode_is_420_also(info, mode)))
> dw_hdmi->input_bus_format = MEDIA_BUS_FMT_UYYVYY8_0_5X24;
> - else
> + else {
nit: if the else has {} you should add to the 'if' (even if the if side
is a single statement): c.f. end of this section of CodingStyle:
https://www.kernel.org/doc/html/latest/process/coding-style.html#placing-braces-and-spaces
> dw_hdmi->input_bus_format = MEDIA_BUS_FMT_YUV8_1X24;
> + if (info->color_formats & DRM_COLOR_FORMAT_YCRCB444) {
> + out_format = MEDIA_BUS_FMT_YUV8_1X24;
> + specify_out_format = true;
> + }
> + }
> +
> + /* Set a connector bus format if required */
> + drm_display_info_set_bus_formats(info, &out_format,
> + (specify_out_format ? 1 : 0));
>
Otherwise,
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Kevin
next prev parent reply other threads:[~2019-06-06 17:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 13:37 [PATCH 0/5] drm/meson: Add support for HDMI2.0 YUV420 4k60 Neil Armstrong
2019-05-20 13:37 ` Neil Armstrong
2019-05-20 13:37 ` [PATCH 1/5] drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a Neil Armstrong
2019-05-20 13:37 ` Neil Armstrong
2019-05-22 6:07 ` Andrzej Hajda
2019-05-22 6:07 ` Andrzej Hajda
2019-06-05 12:59 ` Neil Armstrong
2019-06-05 12:59 ` Neil Armstrong
2019-05-20 13:37 ` [PATCH 2/5] drm/bridge: add encoder support to specify bridge input format Neil Armstrong
2019-05-20 13:37 ` Neil Armstrong
2019-05-27 15:29 ` Jernej Škrabec
2019-05-27 15:29 ` Jernej Škrabec
2019-06-07 13:38 ` Laurent Pinchart
2019-06-07 13:38 ` Laurent Pinchart
2019-06-07 14:11 ` Neil Armstrong
2019-06-07 14:11 ` Neil Armstrong
2019-05-20 13:37 ` [PATCH 3/5] drm/bridge: dw-hdmi: Add support for dynamic output format setup Neil Armstrong
2019-05-20 13:37 ` Neil Armstrong
2019-05-27 15:30 ` Jernej Škrabec
2019-05-27 15:30 ` Jernej Škrabec
2019-05-20 13:37 ` [PATCH 4/5] drm/meson: Add YUV420 output support Neil Armstrong
2019-05-20 13:37 ` Neil Armstrong
2019-05-20 13:37 ` Neil Armstrong
2019-06-06 17:11 ` Kevin Hilman
2019-06-06 17:11 ` Kevin Hilman
2019-06-06 17:11 ` Kevin Hilman
2019-05-20 13:37 ` [PATCH 5/5] drm/meson: Output in YUV444 if sink supports it Neil Armstrong
2019-05-20 13:37 ` Neil Armstrong
2019-06-06 17:16 ` Kevin Hilman [this message]
2019-06-06 17:16 ` Kevin Hilman
2019-06-06 17:16 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hblzaeisb.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.