All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 00/12] firmware: arm_scpi: series with smaller improvements
Date: Fri, 19 Jan 2018 10:04:19 -0800	[thread overview]
Message-ID: <7hbmhpybbw.fsf@baylibre.com> (raw)
In-Reply-To: <db85dc34-5755-c48d-8a23-379d95fc0342@arm.com> (Sudeep Holla's message of "Wed, 10 Jan 2018 16:56:49 +0000")

Sudeep Holla <sudeep.holla@arm.com> writes:

> Hi Heiner,
>
> (Sorry for the late response, was off for a month)
>
> On 05/12/17 21:54, Heiner Kallweit wrote:
>> After recent revert of all changes since 4.14 this is a resubmit of
>> the patch series, reduced to patches which should not cause any
>> regression.
>> Based on a remark from Kevin I added one patch for improving the
>> version info for pre-1.0 firmware that doesn't provide version
>> information.
>> 
>> Best should be to apply it to a devel branch first so that the
>> Baylibre Amlogic team can test before mainlining.
>> 
>
> I am still waiting for tested by from Amlogic team for this series.

I (finally) tested this series on a few of the boards that were failing
last time, and those issues are gone.

So, for the series...

Tested-by: Kevin Hilman <khilman@baylibre.com>


> However I prefer even the patch you dropped as causing the issue to
> be tested as it's nice cleanup to have. I strongly think that the issue
> Kevin reported was due to broken DVFS in the scp firmware in which case
> the solution is to have the dvfs node in DT removed or disabled rather
> than not having that patch at all.

Yes, I suspect we're up against broken firmware also.

> Please post that patch on rebased on top of this series and get it
> tested with DVFS nodes disabled.

I'll give that a test as well,

Thanks,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/12] firmware: arm_scpi: series with smaller improvements
Date: Fri, 19 Jan 2018 10:04:19 -0800	[thread overview]
Message-ID: <7hbmhpybbw.fsf@baylibre.com> (raw)
In-Reply-To: <db85dc34-5755-c48d-8a23-379d95fc0342@arm.com> (Sudeep Holla's message of "Wed, 10 Jan 2018 16:56:49 +0000")

Sudeep Holla <sudeep.holla@arm.com> writes:

> Hi Heiner,
>
> (Sorry for the late response, was off for a month)
>
> On 05/12/17 21:54, Heiner Kallweit wrote:
>> After recent revert of all changes since 4.14 this is a resubmit of
>> the patch series, reduced to patches which should not cause any
>> regression.
>> Based on a remark from Kevin I added one patch for improving the
>> version info for pre-1.0 firmware that doesn't provide version
>> information.
>> 
>> Best should be to apply it to a devel branch first so that the
>> Baylibre Amlogic team can test before mainlining.
>> 
>
> I am still waiting for tested by from Amlogic team for this series.

I (finally) tested this series on a few of the boards that were failing
last time, and those issues are gone.

So, for the series...

Tested-by: Kevin Hilman <khilman@baylibre.com>


> However I prefer even the patch you dropped as causing the issue to
> be tested as it's nice cleanup to have. I strongly think that the issue
> Kevin reported was due to broken DVFS in the scp firmware in which case
> the solution is to have the dvfs node in DT removed or disabled rather
> than not having that patch at all.

Yes, I suspect we're up against broken firmware also.

> Please post that patch on rebased on top of this series and get it
> tested with DVFS nodes disabled.

I'll give that a test as well,

Thanks,

Kevin

  reply	other threads:[~2018-01-19 18:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 21:54 [PATCH 00/12] firmware: arm_scpi: series with smaller improvements Heiner Kallweit
2017-12-05 21:54 ` Heiner Kallweit
2017-12-05 22:16 ` [PATCH 01/12] firmware: arm_scpi: remove two unneeded devm_kfree's in scpi_remove Heiner Kallweit
2017-12-05 22:16   ` Heiner Kallweit
2017-12-05 22:16 ` [PATCH 02/12] firmware: arm_scpi: make freeing mbox channels device-managed Heiner Kallweit
2017-12-05 22:16   ` Heiner Kallweit
2017-12-05 22:16 ` [PATCH 03/12] firmware: arm_scpi: make scpi_probe completely device-managed Heiner Kallweit
2017-12-05 22:16   ` Heiner Kallweit
2017-12-05 22:16 ` [PATCH 04/12] firmware: arm_scpi: improve struct dvfs_info to make code better readable Heiner Kallweit
2017-12-05 22:16   ` Heiner Kallweit
2017-12-05 22:16 ` [PATCH 05/12] firmware: arm_scpi: improve handling of protocol and firmware version subfields Heiner Kallweit
2017-12-05 22:16   ` Heiner Kallweit
2017-12-05 22:16 ` [PATCH 06/12] firmware: arm_scpi: improve struct sensor_value Heiner Kallweit
2017-12-05 22:16   ` Heiner Kallweit
2017-12-05 22:17 ` [PATCH 07/12] firmware: arm_scpi: drop unnecessary type cast to scpi_shared_mem Heiner Kallweit
2017-12-05 22:17   ` Heiner Kallweit
2017-12-05 22:17 ` [PATCH 08/12] firmware: arm_scpi: remove all single element structures Heiner Kallweit
2017-12-05 22:17   ` Heiner Kallweit
2017-12-05 22:17 ` [PATCH 09/12] firmware: arm_scpi: silence sparse warnings Heiner Kallweit
2017-12-05 22:17   ` Heiner Kallweit
2017-12-05 22:17 ` [PATCH 10/12] firmware: arm_scpi: remove struct sensor_capabilities Heiner Kallweit
2017-12-05 22:17   ` Heiner Kallweit
2017-12-05 22:17 ` [PATCH 11/12] firmware: arm_scpi: use FIELD_GET/_PREP to simplify macro definitions Heiner Kallweit
2017-12-05 22:17   ` Heiner Kallweit
2017-12-05 22:17 ` [PATCH 12/12] firmware: arm_scpi: improve info message for pre-1.0 firmware Heiner Kallweit
2017-12-05 22:17   ` Heiner Kallweit
2018-01-10 16:56 ` [PATCH 00/12] firmware: arm_scpi: series with smaller improvements Sudeep Holla
2018-01-10 16:56   ` Sudeep Holla
2018-01-19 18:04   ` Kevin Hilman [this message]
2018-01-19 18:04     ` Kevin Hilman
2018-02-28 16:32     ` Sudeep Holla
2018-02-28 16:32       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hbmhpybbw.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.