From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, ulf.hansson@linaro.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
baylibre-upstreaming@groups.io, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] mmc: meson-gx: add ddr-access-quirk
Date: Mon, 13 May 2019 10:47:45 -0700 [thread overview]
Message-ID: <7hd0kmckla.fsf@baylibre.com> (raw)
In-Reply-To: <20190513091548.16674-3-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> On the Amlogic G12A SoC family, (only) the SDIO controller fails to access
> the data from DDR, leading to a broken controller.
>
> But each MMC controller has 1,5KiB of SRAM after the registers, that can
> be used as bounce buffer to avoid direct DDR access from the integrated
> DMAs (this SRAM may be used by the boot ROM when DDR is not yet initialized).
>
> The quirk is to disable the chained descriptor for this controller, and
> use this SRAM memory zone as buffer for the bounce buffer fallback mode.
>
> The performance hit hasn't been evaluated, but the fix has been tested
> using a WiFi AP6398S SDIO module, and the iperf3 Bandwidth measurement gave
> 55.2 Mbits/sec over a 63 Hours long test, with the SDIO ios set as High-Speed
> at 50MHz clock. It gave 170 Mbits/sec as SDR104 and 200MHz clock.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: ulf.hansson@linaro.org
Cc: baylibre-upstreaming@groups.io,
Neil Armstrong <narmstrong@baylibre.com>,
linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mmc: meson-gx: add ddr-access-quirk
Date: Mon, 13 May 2019 10:47:45 -0700 [thread overview]
Message-ID: <7hd0kmckla.fsf@baylibre.com> (raw)
In-Reply-To: <20190513091548.16674-3-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> On the Amlogic G12A SoC family, (only) the SDIO controller fails to access
> the data from DDR, leading to a broken controller.
>
> But each MMC controller has 1,5KiB of SRAM after the registers, that can
> be used as bounce buffer to avoid direct DDR access from the integrated
> DMAs (this SRAM may be used by the boot ROM when DDR is not yet initialized).
>
> The quirk is to disable the chained descriptor for this controller, and
> use this SRAM memory zone as buffer for the bounce buffer fallback mode.
>
> The performance hit hasn't been evaluated, but the fix has been tested
> using a WiFi AP6398S SDIO module, and the iperf3 Bandwidth measurement gave
> 55.2 Mbits/sec over a 63 Hours long test, with the SDIO ios set as High-Speed
> at 50MHz clock. It gave 170 Mbits/sec as SDR104 and 200MHz clock.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, ulf.hansson@linaro.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
baylibre-upstreaming@groups.io, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] mmc: meson-gx: add ddr-access-quirk
Date: Mon, 13 May 2019 10:47:45 -0700 [thread overview]
Message-ID: <7hd0kmckla.fsf@baylibre.com> (raw)
In-Reply-To: <20190513091548.16674-3-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> On the Amlogic G12A SoC family, (only) the SDIO controller fails to access
> the data from DDR, leading to a broken controller.
>
> But each MMC controller has 1,5KiB of SRAM after the registers, that can
> be used as bounce buffer to avoid direct DDR access from the integrated
> DMAs (this SRAM may be used by the boot ROM when DDR is not yet initialized).
>
> The quirk is to disable the chained descriptor for this controller, and
> use this SRAM memory zone as buffer for the bounce buffer fallback mode.
>
> The performance hit hasn't been evaluated, but the fix has been tested
> using a WiFi AP6398S SDIO module, and the iperf3 Bandwidth measurement gave
> 55.2 Mbits/sec over a 63 Hours long test, with the SDIO ios set as High-Speed
> at 50MHz clock. It gave 170 Mbits/sec as SDR104 and 200MHz clock.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, ulf.hansson@linaro.org
Cc: baylibre-upstreaming@groups.io,
Neil Armstrong <narmstrong@baylibre.com>,
linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mmc: meson-gx: add ddr-access-quirk
Date: Mon, 13 May 2019 10:47:45 -0700 [thread overview]
Message-ID: <7hd0kmckla.fsf@baylibre.com> (raw)
In-Reply-To: <20190513091548.16674-3-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> On the Amlogic G12A SoC family, (only) the SDIO controller fails to access
> the data from DDR, leading to a broken controller.
>
> But each MMC controller has 1,5KiB of SRAM after the registers, that can
> be used as bounce buffer to avoid direct DDR access from the integrated
> DMAs (this SRAM may be used by the boot ROM when DDR is not yet initialized).
>
> The quirk is to disable the chained descriptor for this controller, and
> use this SRAM memory zone as buffer for the bounce buffer fallback mode.
>
> The performance hit hasn't been evaluated, but the fix has been tested
> using a WiFi AP6398S SDIO module, and the iperf3 Bandwidth measurement gave
> 55.2 Mbits/sec over a 63 Hours long test, with the SDIO ios set as High-Speed
> at 50MHz clock. It gave 170 Mbits/sec as SDR104 and 200MHz clock.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
next prev parent reply other threads:[~2019-05-13 17:47 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 9:15 [PATCH 0/3] mmc: meson-gx: add ddr-access-quirk support Neil Armstrong
2019-05-13 9:15 ` Neil Armstrong
2019-05-13 9:15 ` Neil Armstrong
2019-05-13 9:15 ` [PATCH 1/3] dt-bindings: mmc: meson-gx: add ddr-access-quirk property Neil Armstrong
2019-05-13 9:15 ` Neil Armstrong
2019-05-13 9:15 ` Neil Armstrong
2019-05-14 17:50 ` Martin Blumenstingl
2019-05-14 17:50 ` Martin Blumenstingl
2019-05-14 17:50 ` Martin Blumenstingl
2019-05-15 12:43 ` Neil Armstrong
2019-05-15 12:43 ` Neil Armstrong
2019-05-15 12:43 ` Neil Armstrong
2019-05-15 11:37 ` Ulf Hansson
2019-05-15 11:37 ` Ulf Hansson
2019-05-15 11:37 ` Ulf Hansson
2019-05-15 12:43 ` Neil Armstrong
2019-05-15 12:43 ` Neil Armstrong
2019-05-15 12:43 ` Neil Armstrong
2019-05-13 9:15 ` [PATCH 2/3] mmc: meson-gx: add ddr-access-quirk Neil Armstrong
2019-05-13 9:15 ` Neil Armstrong
2019-05-13 9:15 ` Neil Armstrong
2019-05-13 17:47 ` Kevin Hilman [this message]
2019-05-13 17:47 ` Kevin Hilman
2019-05-13 17:47 ` Kevin Hilman
2019-05-13 17:47 ` Kevin Hilman
2019-05-14 17:58 ` Martin Blumenstingl
2019-05-14 17:58 ` Martin Blumenstingl
2019-05-14 17:58 ` Martin Blumenstingl
2019-05-15 12:45 ` Neil Armstrong
2019-05-15 12:45 ` Neil Armstrong
2019-05-15 12:45 ` Neil Armstrong
2019-05-15 12:45 ` Neil Armstrong
2019-05-15 21:18 ` Martin Blumenstingl
2019-05-15 21:18 ` Martin Blumenstingl
2019-05-15 21:18 ` Martin Blumenstingl
2019-05-16 9:09 ` Neil Armstrong
2019-05-16 9:09 ` Neil Armstrong
2019-05-16 9:09 ` Neil Armstrong
2019-05-15 11:34 ` Ulf Hansson
2019-05-15 11:34 ` Ulf Hansson
2019-05-15 11:34 ` Ulf Hansson
2019-05-15 12:51 ` Neil Armstrong
2019-05-15 12:51 ` Neil Armstrong
2019-05-15 12:51 ` Neil Armstrong
2019-05-13 9:15 ` [PATCH 3/3] arm64: dts: meson-g12a: add ddr-access-quirk property to SDIO controller Neil Armstrong
2019-05-13 9:15 ` Neil Armstrong
2019-05-13 9:15 ` Neil Armstrong
2019-05-14 17:51 ` Martin Blumenstingl
2019-05-14 17:51 ` Martin Blumenstingl
2019-05-14 17:51 ` Martin Blumenstingl
2019-05-13 9:58 ` [PATCH 0/3] mmc: meson-gx: add ddr-access-quirk support Jerome Brunet
2019-05-13 9:58 ` Jerome Brunet
2019-05-13 9:58 ` Jerome Brunet
2019-05-13 11:28 ` Jerome Brunet
2019-05-13 11:28 ` Jerome Brunet
2019-05-13 11:28 ` Jerome Brunet
2019-05-14 9:14 ` [baylibre-upstreaming] " guillaume La Roque
2019-05-14 9:14 ` guillaume La Roque
2019-05-14 9:14 ` guillaume La Roque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hd0kmckla.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=baylibre-upstreaming@groups.io \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.