From: Kevin Hilman <khilman@baylibre.com>
To: "shunzhou.jiang@amlogic.com" <shunzhou.jiang@amlogic.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic <linux-amlogic@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
jbrunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"jianxin.pan" <jianxin.pan@amlogic.com>
Subject: Re: Re: [PATCH 2/2] soc: s4: Add support for power domains controller
Date: Wed, 09 Feb 2022 12:30:55 -0800 [thread overview]
Message-ID: <7hee4bok8w.fsf@baylibre.com> (raw)
In-Reply-To: <202202091001287547451@amlogic.com>
"shunzhou.jiang@amlogic.com" <shunzhou.jiang@amlogic.com> writes:
> Hi Kevin:
> Thanks your reply.
> Please refer to below comment,
>> S4_VPU_HDMI: for vpu domain, this domain provide power to many moudles(osd, vpp, hdr, dv, di), if close, will cause system crash
>> S4_USB_COMB domain: for usb, if not always on, all usb status will clear to 0, that's not right status for usb
Yes, I understand, this is teh same as for other SoCs (e.g. A1.) The
solution is not to set the domain to always on. The solution is for the
drivers for the devices in these domains use runtime PM so that when the
drivers are active, the power domain does not get shut off.
>> S4_ETH: for ethernet online wakeup, and if power down, status also not right
OK, this one makes sense for "always on" since it used by firmware for
wakeup.
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: "shunzhou.jiang@amlogic.com" <shunzhou.jiang@amlogic.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic <linux-amlogic@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
jbrunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"jianxin.pan" <jianxin.pan@amlogic.com>
Subject: Re: Re: [PATCH 2/2] soc: s4: Add support for power domains controller
Date: Wed, 09 Feb 2022 12:30:55 -0800 [thread overview]
Message-ID: <7hee4bok8w.fsf@baylibre.com> (raw)
In-Reply-To: <202202091001287547451@amlogic.com>
"shunzhou.jiang@amlogic.com" <shunzhou.jiang@amlogic.com> writes:
> Hi Kevin:
> Thanks your reply.
> Please refer to below comment,
>> S4_VPU_HDMI: for vpu domain, this domain provide power to many moudles(osd, vpp, hdr, dv, di), if close, will cause system crash
>> S4_USB_COMB domain: for usb, if not always on, all usb status will clear to 0, that's not right status for usb
Yes, I understand, this is teh same as for other SoCs (e.g. A1.) The
solution is not to set the domain to always on. The solution is for the
drivers for the devices in these domains use runtime PM so that when the
drivers are active, the power domain does not get shut off.
>> S4_ETH: for ethernet online wakeup, and if power down, status also not right
OK, this one makes sense for "always on" since it used by firmware for
wakeup.
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: "shunzhou.jiang@amlogic.com" <shunzhou.jiang@amlogic.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic <linux-amlogic@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
jbrunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"jianxin.pan" <jianxin.pan@amlogic.com>
Subject: Re: Re: [PATCH 2/2] soc: s4: Add support for power domains controller
Date: Wed, 09 Feb 2022 12:30:55 -0800 [thread overview]
Message-ID: <7hee4bok8w.fsf@baylibre.com> (raw)
In-Reply-To: <202202091001287547451@amlogic.com>
"shunzhou.jiang@amlogic.com" <shunzhou.jiang@amlogic.com> writes:
> Hi Kevin:
> Thanks your reply.
> Please refer to below comment,
>> S4_VPU_HDMI: for vpu domain, this domain provide power to many moudles(osd, vpp, hdr, dv, di), if close, will cause system crash
>> S4_USB_COMB domain: for usb, if not always on, all usb status will clear to 0, that's not right status for usb
Yes, I understand, this is teh same as for other SoCs (e.g. A1.) The
solution is not to set the domain to always on. The solution is for the
drivers for the devices in these domains use runtime PM so that when the
drivers are active, the power domain does not get shut off.
>> S4_ETH: for ethernet online wakeup, and if power down, status also not right
OK, this one makes sense for "always on" since it used by firmware for
wakeup.
Kevin
next prev parent reply other threads:[~2022-02-09 20:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 6:10 [PATCH 0/2] Power: meson-s4: add s4 power domain driver Shunzhou Jiang
2022-01-26 6:10 ` Shunzhou Jiang
2022-01-26 6:10 ` Shunzhou Jiang
2022-01-26 6:10 ` [PATCH 1/2] dt-bindings: power: add Amlogic s4 power domains bindings Shunzhou Jiang
2022-01-26 6:10 ` Shunzhou Jiang
2022-01-26 6:10 ` Shunzhou Jiang
2022-01-26 6:10 ` [PATCH 2/2] soc: s4: Add support for power domains controller Shunzhou Jiang
2022-01-26 6:10 ` Shunzhou Jiang
2022-01-26 6:10 ` Shunzhou Jiang
2022-02-01 19:52 ` Kevin Hilman
2022-02-01 19:52 ` Kevin Hilman
2022-02-01 19:52 ` Kevin Hilman
[not found] ` <202202091001287547451@amlogic.com>
2022-02-09 20:30 ` Kevin Hilman [this message]
2022-02-09 20:30 ` Kevin Hilman
2022-02-09 20:30 ` Kevin Hilman
[not found] ` <2022021117375354230910@amlogic.com>
2022-02-11 18:52 ` Kevin Hilman
2022-02-11 18:52 ` Kevin Hilman
2022-02-11 18:52 ` Kevin Hilman
[not found] ` <2022021510112070486315@amlogic.com>
2022-02-19 0:32 ` Kevin Hilman
2022-02-19 0:32 ` Kevin Hilman
2022-02-19 0:32 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hee4bok8w.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=shunzhou.jiang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.