From: Kevin Hilman <khilman@baylibre.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Shawn Lin <shawn.lin@rock-chips.com>, Nishanth Menon <nm@ti.com>,
linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH] PM / AVS: rockchip-io: make the log more consistent
Date: Tue, 18 Oct 2016 14:14:18 -0700 [thread overview]
Message-ID: <7heg3d9x79.fsf@baylibre.com> (raw)
In-Reply-To: <1883054.D2Rm2X9N2G@phil> (Heiko Stuebner's message of "Mon, 10 Oct 2016 22:15:50 +0200")
Heiko Stuebner <heiko@sntech.de> writes:
> Am Montag, 10. Oktober 2016, 20:44:22 CEST schrieb Shawn Lin:
>> When testing SD hotplug automatically, I got bunch of
>> useless log like this:
>>
>> [ 588.357838] mmc0: card 0007 removed
>> [ 589.492664] rockchip-iodomain ff770000.syscon:io-domains: Setting to
>> 3300000 done [ 589.500698] vccio_sd: ramp_delay not set
>> [ 589.504817] rockchip-iodomain ff770000.syscon:io-domains: Setting to
>> 3300000 done [ 589.669705] rockchip-iodomain ff770000.syscon:io-domains:
>> Setting to 3300000 done [ 589.677593] vccio_sd: ramp_delay not set
>> [ 589.681581] rockchip-iodomain ff770000.syscon:io-domains: Setting to
>> 1800000 done [ 590.032820] dwmmc_rockchip ff0c0000.dwmmc: Successfully
>> tuned phase to 140 [ 590.039725] mmc0: new ultra high speed SDR50 SDHC
>> card at address 0007 [ 590.046641] mmcblk0: mmc0:0007 SD32G 29.3 GiB
>> [ 590.052163] mmcblk0: p1
>>
>> Moreover the code is intent to print the 'uV' for debug but
>> later print it using dev_info. It looks more like to me that
>> it should be the real intention of the code. Anyway, let's
>> mark this verbose log as debug message.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> reducing the amount of logs, especially for information not generally needed
> looks sane
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Rafael, feel free to apply directly as a fix for v4.9-rc, or wait for
v4.10 if you prefer.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PM / AVS: rockchip-io: make the log more consistent
Date: Tue, 18 Oct 2016 14:14:18 -0700 [thread overview]
Message-ID: <7heg3d9x79.fsf@baylibre.com> (raw)
In-Reply-To: <1883054.D2Rm2X9N2G@phil> (Heiko Stuebner's message of "Mon, 10 Oct 2016 22:15:50 +0200")
Heiko Stuebner <heiko@sntech.de> writes:
> Am Montag, 10. Oktober 2016, 20:44:22 CEST schrieb Shawn Lin:
>> When testing SD hotplug automatically, I got bunch of
>> useless log like this:
>>
>> [ 588.357838] mmc0: card 0007 removed
>> [ 589.492664] rockchip-iodomain ff770000.syscon:io-domains: Setting to
>> 3300000 done [ 589.500698] vccio_sd: ramp_delay not set
>> [ 589.504817] rockchip-iodomain ff770000.syscon:io-domains: Setting to
>> 3300000 done [ 589.669705] rockchip-iodomain ff770000.syscon:io-domains:
>> Setting to 3300000 done [ 589.677593] vccio_sd: ramp_delay not set
>> [ 589.681581] rockchip-iodomain ff770000.syscon:io-domains: Setting to
>> 1800000 done [ 590.032820] dwmmc_rockchip ff0c0000.dwmmc: Successfully
>> tuned phase to 140 [ 590.039725] mmc0: new ultra high speed SDR50 SDHC
>> card at address 0007 [ 590.046641] mmcblk0: mmc0:0007 SD32G 29.3 GiB
>> [ 590.052163] mmcblk0: p1
>>
>> Moreover the code is intent to print the 'uV' for debug but
>> later print it using dev_info. It looks more like to me that
>> it should be the real intention of the code. Anyway, let's
>> mark this verbose log as debug message.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> reducing the amount of logs, especially for information not generally needed
> looks sane
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Rafael, feel free to apply directly as a fix for v4.9-rc, or wait for
v4.10 if you prefer.
Kevin
next prev parent reply other threads:[~2016-10-18 21:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 12:44 [PATCH] PM / AVS: rockchip-io: make the log more consistent Shawn Lin
2016-10-10 12:44 ` Shawn Lin
2016-10-10 20:15 ` Heiko Stuebner
2016-10-10 20:15 ` Heiko Stuebner
2016-10-18 21:14 ` Kevin Hilman [this message]
2016-10-18 21:14 ` Kevin Hilman
2016-11-14 0:19 ` Rafael J. Wysocki
2016-11-14 0:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7heg3d9x79.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.