All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Philipp Zabel <philipp.zabel@gmail.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	linux-sh@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 01/13] PM / Domains: Add genpd attach/detach callbacks
Date: Fri, 26 Sep 2014 08:47:34 -0700	[thread overview]
Message-ID: <7heguy4c4p.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1411662520-22795-2-git-send-email-geert+renesas@glider.be> (Geert Uytterhoeven's message of "Thu, 25 Sep 2014 18:28:28 +0200")

Geert Uytterhoeven <geert+renesas@glider.be> writes:

> While a PM domain can enable PM runtime management of its devices' module
> clocks by setting
>
> 	genpd->dev_ops.stop = pm_clk_suspend;
> 	genpd->dev_ops.start = pm_clk_resume;
>
> this also requires registering the clocks with the pm_clk subsystem.
> In the legacy case, this is handled by the platform code, after
> attaching the device to its PM domain.
>
> When the devices are instantiated from DT, devices are attached to their
> PM domains by generic code, leaving no method for the platform-specific
> PM domain code to register their clocks.
>
> Add two callbacks, allowing a PM domain to perform platform-specific
> tasks when a device is attached to or detached from a PM domain.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

I replied to the previous RFC, but just to be thorough (and because I
like this approach):

Reviewed-by: Kevin Hilman <khilman@linaro.org>

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@kernel.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 01/13] PM / Domains: Add genpd attach/detach callbacks
Date: Fri, 26 Sep 2014 15:47:34 +0000	[thread overview]
Message-ID: <7heguy4c4p.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1411662520-22795-2-git-send-email-geert+renesas@glider.be> (Geert Uytterhoeven's message of "Thu, 25 Sep 2014 18:28:28 +0200")

Geert Uytterhoeven <geert+renesas@glider.be> writes:

> While a PM domain can enable PM runtime management of its devices' module
> clocks by setting
>
> 	genpd->dev_ops.stop = pm_clk_suspend;
> 	genpd->dev_ops.start = pm_clk_resume;
>
> this also requires registering the clocks with the pm_clk subsystem.
> In the legacy case, this is handled by the platform code, after
> attaching the device to its PM domain.
>
> When the devices are instantiated from DT, devices are attached to their
> PM domains by generic code, leaving no method for the platform-specific
> PM domain code to register their clocks.
>
> Add two callbacks, allowing a PM domain to perform platform-specific
> tasks when a device is attached to or detached from a PM domain.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

I replied to the previous RFC, but just to be thorough (and because I
like this approach):

Reviewed-by: Kevin Hilman <khilman@linaro.org>

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/13] PM / Domains: Add genpd attach/detach callbacks
Date: Fri, 26 Sep 2014 08:47:34 -0700	[thread overview]
Message-ID: <7heguy4c4p.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1411662520-22795-2-git-send-email-geert+renesas@glider.be> (Geert Uytterhoeven's message of "Thu, 25 Sep 2014 18:28:28 +0200")

Geert Uytterhoeven <geert+renesas@glider.be> writes:

> While a PM domain can enable PM runtime management of its devices' module
> clocks by setting
>
> 	genpd->dev_ops.stop = pm_clk_suspend;
> 	genpd->dev_ops.start = pm_clk_resume;
>
> this also requires registering the clocks with the pm_clk subsystem.
> In the legacy case, this is handled by the platform code, after
> attaching the device to its PM domain.
>
> When the devices are instantiated from DT, devices are attached to their
> PM domains by generic code, leaving no method for the platform-specific
> PM domain code to register their clocks.
>
> Add two callbacks, allowing a PM domain to perform platform-specific
> tasks when a device is attached to or detached from a PM domain.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

I replied to the previous RFC, but just to be thorough (and because I
like this approach):

Reviewed-by: Kevin Hilman <khilman@linaro.org>

Kevin

  reply	other threads:[~2014-09-26 15:47 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 16:28 [PATCH 00/13] ARM: shmobile: R-Mobile: DT PM domain support Geert Uytterhoeven
2014-09-25 16:28 ` Geert Uytterhoeven
2014-09-25 16:28 ` Geert Uytterhoeven
     [not found] ` <1411662520-22795-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2014-09-25 16:28   ` [PATCH v3 01/13] PM / Domains: Add genpd attach/detach callbacks Geert Uytterhoeven
2014-09-25 16:28     ` Geert Uytterhoeven
2014-09-25 16:28     ` Geert Uytterhoeven
2014-09-25 16:28     ` Geert Uytterhoeven
2014-09-26 15:47     ` Kevin Hilman [this message]
2014-09-26 15:47       ` Kevin Hilman
2014-09-26 15:47       ` Kevin Hilman
2014-09-25 16:28 ` [PATCH v3 02/13] PM / Domains: Add DT bindings for power-on/off latencies Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-26  8:19   ` Ulf Hansson
2014-09-26  8:19     ` Ulf Hansson
2014-09-26  8:19     ` Ulf Hansson
2014-09-26 15:28     ` Stephen Boyd
2014-09-26 15:28       ` Stephen Boyd
2014-09-26 15:28       ` Stephen Boyd
2014-09-26 17:52       ` Geert Uytterhoeven
2014-09-26 17:52         ` Geert Uytterhoeven
2014-09-26 17:52         ` Geert Uytterhoeven
2014-09-26 17:52         ` Geert Uytterhoeven
2014-09-25 16:28 ` [PATCH v3 03/13] PM / Domains: Add DT bindings for PM QoS device latencies Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-26  8:28   ` Ulf Hansson
2014-09-26  8:28     ` Ulf Hansson
2014-09-26  8:28     ` Ulf Hansson
2014-09-25 16:28 ` [PATCH v3 04/13] PM / Domains: Add DT bindings for the R-Mobile System Controller Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-26  8:32   ` Ulf Hansson
2014-09-26  8:32     ` Ulf Hansson
2014-09-26  8:32     ` Ulf Hansson
2014-09-25 16:28 ` [PATCH v3 05/13] PM / Domains: Add helper variable np = dev->of_node Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-26  8:43   ` Ulf Hansson
2014-09-26  8:43     ` Ulf Hansson
2014-09-26  8:43     ` Ulf Hansson
2014-09-26  8:47     ` Geert Uytterhoeven
2014-09-26  8:47       ` Geert Uytterhoeven
2014-09-26  8:47       ` Geert Uytterhoeven
2014-09-25 16:28 ` [PATCH v3 06/13] PM / Domains: Retrieve PM QoS device latencies from DT Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28 ` [PATCH v3 07/13] ARM: shmobile: R-Mobile: Use generic_pm_domain.attach_dev() for pm_clk setup Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-26  8:45   ` Ulf Hansson
2014-09-26  8:45     ` Ulf Hansson
2014-09-26  8:45     ` Ulf Hansson
     [not found]   ` <1411662520-22795-8-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2014-09-26 18:04     ` Geert Uytterhoeven
2014-09-26 18:04       ` Geert Uytterhoeven
2014-09-26 18:04       ` Geert Uytterhoeven
2014-09-26 18:04       ` Geert Uytterhoeven
2014-10-03 16:01       ` Geert Uytterhoeven
2014-10-03 16:01         ` Geert Uytterhoeven
2014-10-03 16:01         ` Geert Uytterhoeven
2014-09-25 16:28 ` [PATCH v3 08/13] ARM: shmobile: R-Mobile: Store SYSC base address in rmobile_pm_domain Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-26  8:47   ` Ulf Hansson
2014-09-26  8:47     ` Ulf Hansson
2014-09-26  8:47     ` Ulf Hansson
2014-09-25 16:28 ` [PATCH v3 09/13] ARM: shmobile: R-Mobile: Add DT support for PM domains Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28 ` [PATCH v3 10/13] ARM: shmobile: r8a7740 dtsi: Add PM domain support Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-26  8:13   ` Geert Uytterhoeven
2014-09-26  8:13     ` Geert Uytterhoeven
2014-09-26  8:13     ` Geert Uytterhoeven
2014-09-25 16:28 ` [PATCH v3 11/13] drivers: sh: Disable PM runtime for multi-platform r8a7740 with genpd Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28 ` [PATCH v3 12/13] ARM: shmobile: r8a7740 dtsi: Add preliminary PM domain latencies Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28 ` [PATCH v3 13/13] ARM: shmobile: r8a7740 dtsi: Add preliminary PM QoS device latencies Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-25 16:28   ` Geert Uytterhoeven
2014-09-26  8:16   ` Geert Uytterhoeven
2014-09-26  8:16     ` Geert Uytterhoeven
2014-09-26  8:16     ` Geert Uytterhoeven
2014-09-25 19:59 ` [PATCH 00/13] ARM: shmobile: R-Mobile: DT PM domain support Rafael J. Wysocki
2014-09-25 20:19   ` Rafael J. Wysocki
2014-09-25 20:19   ` Rafael J. Wysocki
     [not found]   ` <3136347.ncZoJtR6MK-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-09-26  9:27     ` Geert Uytterhoeven
2014-09-26  9:27       ` Geert Uytterhoeven
2014-09-26  9:27       ` Geert Uytterhoeven
2014-09-26  9:27       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7heguy4c4p.fsf@deeprootsystems.com \
    --to=khilman@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=grygorii.strashko@ti.com \
    --cc=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=philipp.zabel@gmail.com \
    --cc=rjw@rjwysocki.net \
    --cc=tomasz.figa@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.