From: Kevin Hilman <khilman@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC v2 02/12] PM / Domains: Add DT bindings for PM QoS device latencies
Date: Thu, 25 Sep 2014 14:31:40 -0700 [thread overview]
Message-ID: <7heguzbd4z.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1410893339-6361-3-git-send-email-geert+renesas@glider.be> (Geert Uytterhoeven's message of "Tue, 16 Sep 2014 20:48:49 +0200")
Geert Uytterhoeven <geert+renesas@glider.be> writes:
> PM QoS device start/stop and save/restore state latencies are more or
> less properties of the hardware.
> In legacy code, they're specified from platform code.
> On DT platforms, their values should come from DT.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Should these properties be called "linux,*-latency"?
Hmm, the start/stop latencies are clearly properties of the hardware,
but the save/restore latencies seem to be a function of the driver.
e.g., some drivers may keep a shadow copy of their registers in memory
so the save time is minimized.
I don't have too strong of an opinion on this, but probably the drivers
should just add their own values to the start/stop latencies to add the
linux specific overhead.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@kernel.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RFC v2 02/12] PM / Domains: Add DT bindings for PM QoS device latencies
Date: Thu, 25 Sep 2014 21:31:40 +0000 [thread overview]
Message-ID: <7heguzbd4z.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1410893339-6361-3-git-send-email-geert+renesas@glider.be> (Geert Uytterhoeven's message of "Tue, 16 Sep 2014 20:48:49 +0200")
Geert Uytterhoeven <geert+renesas@glider.be> writes:
> PM QoS device start/stop and save/restore state latencies are more or
> less properties of the hardware.
> In legacy code, they're specified from platform code.
> On DT platforms, their values should come from DT.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Should these properties be called "linux,*-latency"?
Hmm, the start/stop latencies are clearly properties of the hardware,
but the save/restore latencies seem to be a function of the driver.
e.g., some drivers may keep a shadow copy of their registers in memory
so the save time is minimized.
I don't have too strong of an opinion on this, but probably the drivers
should just add their own values to the start/stop latencies to add the
linux specific overhead.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC v2 02/12] PM / Domains: Add DT bindings for PM QoS device latencies
Date: Thu, 25 Sep 2014 14:31:40 -0700 [thread overview]
Message-ID: <7heguzbd4z.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1410893339-6361-3-git-send-email-geert+renesas@glider.be> (Geert Uytterhoeven's message of "Tue, 16 Sep 2014 20:48:49 +0200")
Geert Uytterhoeven <geert+renesas@glider.be> writes:
> PM QoS device start/stop and save/restore state latencies are more or
> less properties of the hardware.
> In legacy code, they're specified from platform code.
> On DT platforms, their values should come from DT.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Should these properties be called "linux,*-latency"?
Hmm, the start/stop latencies are clearly properties of the hardware,
but the save/restore latencies seem to be a function of the driver.
e.g., some drivers may keep a shadow copy of their registers in memory
so the save time is minimized.
I don't have too strong of an opinion on this, but probably the drivers
should just add their own values to the start/stop latencies to add the
linux specific overhead.
Kevin
next prev parent reply other threads:[~2014-09-25 21:31 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 18:48 [PATCH/RFC v2 00/12] ARM: shmobile: R-Mobile: Prototype DT PM domain support Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` [PATCH/RFC v2 01/12] PM / Domains: Add DT bindings for power-on/off latencies Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` [PATCH/RFC v2 02/12] PM / Domains: Add DT bindings for PM QoS device latencies Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-25 21:31 ` Kevin Hilman [this message]
2014-09-25 21:31 ` Kevin Hilman
2014-09-25 21:31 ` Kevin Hilman
2014-09-26 6:25 ` Geert Uytterhoeven
2014-09-26 6:25 ` Geert Uytterhoeven
2014-09-26 6:25 ` Geert Uytterhoeven
2014-09-16 18:48 ` [PATCH/RFC v2 03/12] PM / Domains: Add DT bindings for the R-Mobile System Controller Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` [PATCH/RFC v2 04/12] PM / Domains: Add genpd attach/detach callbacks Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-17 17:44 ` Ulf Hansson
2014-09-17 17:44 ` Ulf Hansson
2014-09-17 17:44 ` Ulf Hansson
2014-09-25 21:33 ` Kevin Hilman
2014-09-25 21:33 ` Kevin Hilman
2014-09-25 21:33 ` Kevin Hilman
2014-09-16 18:48 ` [PATCH/RFC v2 05/12] PM / Domains: Add helper variable np = dev->of_node Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-25 21:36 ` Kevin Hilman
2014-09-25 21:36 ` Kevin Hilman
2014-09-25 21:36 ` Kevin Hilman
2014-09-16 18:48 ` [PATCH/RFC v2 06/12] PM / Domains: Retrieve PM QoS device latencies from DT Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` [PATCH/RFC v2 07/12] ARM: shmobile: R-Mobile: Use generic_pm_domain.attach_dev() for pm_clk setup Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` [PATCH/RFC v2 08/12] ARM: shmobile: R-Mobile: Store SYSC base address in rmobile_pm_domain Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` [PATCH/RFC v2 09/12] ARM: shmobile: R-Mobile: Add DT support for PM domains Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` [PATCH/RFC v2 10/12] ARM: shmobile: r8a7740 dtsi: Add PM domain support Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` [PATCH/RFC v2 11/12] ARM: shmobile: r8a7740 dtsi: Add PM QoS device latencies Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
[not found] ` <1410893339-6361-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2014-09-16 18:48 ` [PATCH/RFC v2 12/12] drivers: sh: Disable PM runtime for multi-platform r8a7740 with genpd Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
2014-09-16 18:48 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7heguzbd4z.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert+renesas@glider.be \
--cc=grygorii.strashko@ti.com \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=pawel.moll@arm.com \
--cc=philipp.zabel@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.