All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	kishon@ti.com, balbi@kernel.org,
	martin.blumenstingl@googlemail.com
Cc: linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH 0/5] usb: dwc-meson-g12a: Add support for USB on S400 board
Date: Mon, 14 Sep 2020 10:57:01 -0700	[thread overview]
Message-ID: <7hft7kw8b6.fsf@baylibre.com> (raw)
In-Reply-To: <20200909160409.8678-1-narmstrong@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> The Amlogic AXG is close from the GXL Glue but with a single OTG PHY.

minor grammar nit: s/close from/close to/  (also in patches 2 & 3).
Otherwise..

Reviewed-by: Kevin Hilman <khilman@baylibre.com>

Kevin



> It needs the same init sequence as GXL & GXM, but it seems it doesn't need
> the host disconnect bit.
>
> The Glue driver reuses the already implemented GXL & GXM work.
>
> The USB2 PHY driver needs a slight tweak to keep the OTG detection working.
>
> Neil Armstrong (5):
>   phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode
>   dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG
>     Families USB Glue Bindings
>   usb: dwc-meson-g12a: Add support for USB on AXG SoCs
>   arm64: dts: meson-axg: add USB nodes
>   arm64: dts: meson-axg-s400: enable USB OTG
>
>  .../usb/amlogic,meson-g12a-usb-ctrl.yaml      | 22 +++++++-
>  .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 10 ++++
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi    | 51 +++++++++++++++++++
>  drivers/phy/amlogic/phy-meson-gxl-usb2.c      |  3 +-
>  drivers/usb/dwc3/dwc3-meson-g12a.c            | 17 +++++++
>  5 files changed, 101 insertions(+), 2 deletions(-)
>
> -- 
> 2.22.0

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	kishon@ti.com, balbi@kernel.org,
	martin.blumenstingl@googlemail.com
Cc: linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Neil Armstrong <narmstrong@baylibre.com>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH 0/5] usb: dwc-meson-g12a: Add support for USB on S400 board
Date: Mon, 14 Sep 2020 10:57:01 -0700	[thread overview]
Message-ID: <7hft7kw8b6.fsf@baylibre.com> (raw)
In-Reply-To: <20200909160409.8678-1-narmstrong@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> The Amlogic AXG is close from the GXL Glue but with a single OTG PHY.

minor grammar nit: s/close from/close to/  (also in patches 2 & 3).
Otherwise..

Reviewed-by: Kevin Hilman <khilman@baylibre.com>

Kevin



> It needs the same init sequence as GXL & GXM, but it seems it doesn't need
> the host disconnect bit.
>
> The Glue driver reuses the already implemented GXL & GXM work.
>
> The USB2 PHY driver needs a slight tweak to keep the OTG detection working.
>
> Neil Armstrong (5):
>   phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode
>   dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG
>     Families USB Glue Bindings
>   usb: dwc-meson-g12a: Add support for USB on AXG SoCs
>   arm64: dts: meson-axg: add USB nodes
>   arm64: dts: meson-axg-s400: enable USB OTG
>
>  .../usb/amlogic,meson-g12a-usb-ctrl.yaml      | 22 +++++++-
>  .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 10 ++++
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi    | 51 +++++++++++++++++++
>  drivers/phy/amlogic/phy-meson-gxl-usb2.c      |  3 +-
>  drivers/usb/dwc3/dwc3-meson-g12a.c            | 17 +++++++
>  5 files changed, 101 insertions(+), 2 deletions(-)
>
> -- 
> 2.22.0

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	kishon@ti.com, balbi@kernel.org,
	martin.blumenstingl@googlemail.com
Cc: linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH 0/5] usb: dwc-meson-g12a: Add support for USB on S400 board
Date: Mon, 14 Sep 2020 10:57:01 -0700	[thread overview]
Message-ID: <7hft7kw8b6.fsf@baylibre.com> (raw)
In-Reply-To: <20200909160409.8678-1-narmstrong@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> The Amlogic AXG is close from the GXL Glue but with a single OTG PHY.

minor grammar nit: s/close from/close to/  (also in patches 2 & 3).
Otherwise..

Reviewed-by: Kevin Hilman <khilman@baylibre.com>

Kevin



> It needs the same init sequence as GXL & GXM, but it seems it doesn't need
> the host disconnect bit.
>
> The Glue driver reuses the already implemented GXL & GXM work.
>
> The USB2 PHY driver needs a slight tweak to keep the OTG detection working.
>
> Neil Armstrong (5):
>   phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode
>   dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG
>     Families USB Glue Bindings
>   usb: dwc-meson-g12a: Add support for USB on AXG SoCs
>   arm64: dts: meson-axg: add USB nodes
>   arm64: dts: meson-axg-s400: enable USB OTG
>
>  .../usb/amlogic,meson-g12a-usb-ctrl.yaml      | 22 +++++++-
>  .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 10 ++++
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi    | 51 +++++++++++++++++++
>  drivers/phy/amlogic/phy-meson-gxl-usb2.c      |  3 +-
>  drivers/usb/dwc3/dwc3-meson-g12a.c            | 17 +++++++
>  5 files changed, 101 insertions(+), 2 deletions(-)
>
> -- 
> 2.22.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-09-14 17:57 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 16:04 [PATCH 0/5] usb: dwc-meson-g12a: Add support for USB on S400 board Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-09 16:04 ` [PATCH 1/5] phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode Neil Armstrong
2020-09-09 16:04   ` Neil Armstrong
2020-09-09 16:04   ` Neil Armstrong
2020-09-15 19:53   ` Martin Blumenstingl
2020-09-15 19:53     ` Martin Blumenstingl
2020-09-15 19:53     ` Martin Blumenstingl
2020-09-09 16:04 ` [PATCH 2/5] dt-bindings: usb: amlogic, meson-g12a-usb-ctrl: add the Amlogic AXG Families USB Glue Bindings Neil Armstrong
2020-09-09 16:04   ` Neil Armstrong
2020-09-09 16:04   ` [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: " Neil Armstrong
2020-09-15 17:32   ` [PATCH 2/5] dt-bindings: usb: amlogic, meson-g12a-usb-ctrl: " Rob Herring
2020-09-15 17:32     ` Rob Herring
2020-09-15 17:32     ` Rob Herring
2020-09-15 19:56   ` [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: " Martin Blumenstingl
2020-09-15 19:56     ` Martin Blumenstingl
2020-09-15 19:56     ` Martin Blumenstingl
2020-09-09 16:04 ` [PATCH 3/5] usb: dwc-meson-g12a: Add support for USB on AXG SoCs Neil Armstrong
2020-09-09 16:04   ` Neil Armstrong
2020-09-09 16:04   ` Neil Armstrong
2020-09-15 19:59   ` Martin Blumenstingl
2020-09-15 19:59     ` Martin Blumenstingl
2020-09-15 19:59     ` Martin Blumenstingl
2020-09-16  7:11     ` Neil Armstrong
2020-09-16  7:11       ` Neil Armstrong
2020-09-16  7:11       ` Neil Armstrong
2020-09-09 16:04 ` [PATCH 4/5] arm64: dts: meson-axg: add USB nodes Neil Armstrong
2020-09-09 16:04   ` Neil Armstrong
2020-09-09 16:04   ` Neil Armstrong
2020-09-15 20:04   ` Martin Blumenstingl
2020-09-15 20:04     ` Martin Blumenstingl
2020-09-15 20:04     ` Martin Blumenstingl
2020-09-16  7:10     ` Neil Armstrong
2020-09-16  7:10       ` Neil Armstrong
2020-09-16  7:10       ` Neil Armstrong
2020-09-09 16:04 ` [PATCH 5/5] arm64: dts: meson-axg-s400: enable USB OTG Neil Armstrong
2020-09-09 16:04   ` Neil Armstrong
2020-09-09 16:04   ` Neil Armstrong
2020-09-15 20:05   ` Martin Blumenstingl
2020-09-15 20:05     ` Martin Blumenstingl
2020-09-15 20:05     ` Martin Blumenstingl
2020-09-16  7:09     ` Neil Armstrong
2020-09-16  7:09       ` Neil Armstrong
2020-09-16  7:09       ` Neil Armstrong
2020-09-14 17:57 ` Kevin Hilman [this message]
2020-09-14 17:57   ` [PATCH 0/5] usb: dwc-meson-g12a: Add support for USB on S400 board Kevin Hilman
2020-09-14 17:57   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hft7kw8b6.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=balbi@kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.