From: Kevin Hilman <khilman@baylibre.com>
To: Carlo Caione <ccaione@baylibre.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
martin.blumenstingl@googlemail.com, ingrassia@epigenesys.com
Cc: Carlo Caione <ccaione@baylibre.com>
Subject: Re: [PATCH v2 1/2] arm64: dts: meson: Fix IRQ trigger type for macirq
Date: Fri, 07 Dec 2018 16:20:02 -0800 [thread overview]
Message-ID: <7hftv8yiml.fsf@baylibre.com> (raw)
In-Reply-To: <20181207105231.25593-2-ccaione@baylibre.com>
Carlo Caione <ccaione@baylibre.com> writes:
> A long running stress test on a custom board shipping an AXG SoCs and a
> Realtek RTL8211F PHY revealed that after a few hours the connection
> speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time
> the 'macirq' (eth0) IRQ would stop being triggered at all and as
> consequence the GMAC IRQs never ACKed.
>
> After a painful investigation the problem seemed to be due to a wrong
> defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of
> EDGE_RISING.
>
> The change in the macirq IRQ type also solved another long standing
> issue affecting this SoC/PHY where EEE was causing the network
> connection to die after stressing it with iperf3 (even though much
> sooner). It's now possible to remove the 'eee-broken-1000t' quirk as
> well.
>
> Fixes: feb3cbea0946 ("ARM64: dts: meson-gxbb-odroidc2: fix GbE tx link breakage")
> Fixes: 6d28d577510f ("ARM64: dts: meson-axg: fix ethernet stability issue")
> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
> Tested-by: Jerome Brunet <jbrunet@baylibre.com>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Queuing this one for v4.21 (dt64 branch)
I'm going to wait for the dust to settle on 'PATCH v2 2/2' for the
32-bit SoCs (and will rely on Martin's recommendation for the final
decision there.)
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Carlo Caione <ccaione@baylibre.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
martin.blumenstingl@googlemail.com, ingrassia@epigenesys.com
Cc: Carlo Caione <ccaione@baylibre.com>
Subject: Re: [PATCH v2 1/2] arm64: dts: meson: Fix IRQ trigger type for macirq
Date: Fri, 07 Dec 2018 16:20:02 -0800 [thread overview]
Message-ID: <7hftv8yiml.fsf@baylibre.com> (raw)
In-Reply-To: <20181207105231.25593-2-ccaione@baylibre.com>
Carlo Caione <ccaione@baylibre.com> writes:
> A long running stress test on a custom board shipping an AXG SoCs and a
> Realtek RTL8211F PHY revealed that after a few hours the connection
> speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time
> the 'macirq' (eth0) IRQ would stop being triggered at all and as
> consequence the GMAC IRQs never ACKed.
>
> After a painful investigation the problem seemed to be due to a wrong
> defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of
> EDGE_RISING.
>
> The change in the macirq IRQ type also solved another long standing
> issue affecting this SoC/PHY where EEE was causing the network
> connection to die after stressing it with iperf3 (even though much
> sooner). It's now possible to remove the 'eee-broken-1000t' quirk as
> well.
>
> Fixes: feb3cbea0946 ("ARM64: dts: meson-gxbb-odroidc2: fix GbE tx link breakage")
> Fixes: 6d28d577510f ("ARM64: dts: meson-axg: fix ethernet stability issue")
> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
> Tested-by: Jerome Brunet <jbrunet@baylibre.com>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Queuing this one for v4.21 (dt64 branch)
I'm going to wait for the dust to settle on 'PATCH v2 2/2' for the
32-bit SoCs (and will rely on Martin's recommendation for the final
decision there.)
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
martin.blumenstingl@googlemail.com, ingrassia@epigenesys.com
Cc: Carlo Caione <ccaione@baylibre.com>
Subject: Re: [PATCH v2 1/2] arm64: dts: meson: Fix IRQ trigger type for macirq
Date: Fri, 07 Dec 2018 16:20:02 -0800 [thread overview]
Message-ID: <7hftv8yiml.fsf@baylibre.com> (raw)
In-Reply-To: <20181207105231.25593-2-ccaione@baylibre.com>
Carlo Caione <ccaione@baylibre.com> writes:
> A long running stress test on a custom board shipping an AXG SoCs and a
> Realtek RTL8211F PHY revealed that after a few hours the connection
> speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time
> the 'macirq' (eth0) IRQ would stop being triggered at all and as
> consequence the GMAC IRQs never ACKed.
>
> After a painful investigation the problem seemed to be due to a wrong
> defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of
> EDGE_RISING.
>
> The change in the macirq IRQ type also solved another long standing
> issue affecting this SoC/PHY where EEE was causing the network
> connection to die after stressing it with iperf3 (even though much
> sooner). It's now possible to remove the 'eee-broken-1000t' quirk as
> well.
>
> Fixes: feb3cbea0946 ("ARM64: dts: meson-gxbb-odroidc2: fix GbE tx link breakage")
> Fixes: 6d28d577510f ("ARM64: dts: meson-axg: fix ethernet stability issue")
> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
> Tested-by: Jerome Brunet <jbrunet@baylibre.com>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Queuing this one for v4.21 (dt64 branch)
I'm going to wait for the dust to settle on 'PATCH v2 2/2' for the
32-bit SoCs (and will rely on Martin's recommendation for the final
decision there.)
Kevin
next prev parent reply other threads:[~2018-12-08 0:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 10:52 [PATCH v2 0/2] meson: Fix IRQ trigger type Carlo Caione
2018-12-07 10:52 ` Carlo Caione
2018-12-07 10:52 ` Carlo Caione
2018-12-07 10:52 ` [PATCH v2 1/2] arm64: dts: meson: Fix IRQ trigger type for macirq Carlo Caione
2018-12-07 10:52 ` Carlo Caione
2018-12-07 10:52 ` Carlo Caione
2018-12-08 0:20 ` Kevin Hilman [this message]
2018-12-08 0:20 ` Kevin Hilman
2018-12-08 0:20 ` Kevin Hilman
2018-12-07 10:52 ` [PATCH v2 2/2] arm: " Carlo Caione
2018-12-07 10:52 ` Carlo Caione
2018-12-07 10:52 ` Carlo Caione
2018-12-07 18:51 ` Emiliano Ingrassia
2018-12-07 18:51 ` Emiliano Ingrassia
2018-12-07 18:51 ` Emiliano Ingrassia
2018-12-08 10:46 ` Carlo Caione
2018-12-08 10:46 ` Carlo Caione
2018-12-08 10:46 ` Carlo Caione
2018-12-12 10:49 ` Emiliano Ingrassia
2018-12-12 10:49 ` Emiliano Ingrassia
2018-12-12 10:49 ` Emiliano Ingrassia
2018-12-07 22:06 ` Martin Blumenstingl
2018-12-07 22:06 ` Martin Blumenstingl
2018-12-07 22:06 ` Martin Blumenstingl
2018-12-29 0:17 ` Martin Blumenstingl
2018-12-29 0:17 ` Martin Blumenstingl
2018-12-29 0:17 ` Martin Blumenstingl
2019-01-11 0:21 ` Kevin Hilman
2019-01-11 0:21 ` Kevin Hilman
2019-01-11 0:21 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hftv8yiml.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=ccaione@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=ingrassia@epigenesys.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.