From: Kevin Hilman <khilman@baylibre.com>
To: linus-amlogic@lists.infradead.org
Subject: Re: [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static
Date: Fri, 09 Feb 2018 00:49:52 +0000 [thread overview]
Message-ID: <7hh8qr9ebz.fsf@baylibre.com> (raw)
In-Reply-To: <3cb83737-bb60-7648-e72e-2d39590c8418@baylibre.com> (Neil Armstrong's message of "Tue, 6 Feb 2018 13:25:19 +0100")
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 10/01/2018 15:19, Wei Yongjun wrote:
>> Fixes the following sparse warnings:
>>
>> drivers/soc/amlogic/meson-gx-socinfo.c:100:12: warning:
>> symbol 'meson_gx_socinfo_init' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
>> index f2d8c3c..ea091f1 100644
>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
>> @@ -97,7 +97,7 @@ static const char *socinfo_to_soc_id(u32 socinfo)
>> return "Unknown";
>> }
>>
>> -int __init meson_gx_socinfo_init(void)
>> +static int __init meson_gx_socinfo_init(void)
>> {
>> struct soc_device_attribute *soc_dev_attr;
>> struct soc_device *soc_dev;
>>
>>
>>
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Applied for v4.17, with Neil's ack.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static
Date: Thu, 08 Feb 2018 16:49:52 -0800 [thread overview]
Message-ID: <7hh8qr9ebz.fsf@baylibre.com> (raw)
In-Reply-To: <3cb83737-bb60-7648-e72e-2d39590c8418@baylibre.com> (Neil Armstrong's message of "Tue, 6 Feb 2018 13:25:19 +0100")
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 10/01/2018 15:19, Wei Yongjun wrote:
>> Fixes the following sparse warnings:
>>
>> drivers/soc/amlogic/meson-gx-socinfo.c:100:12: warning:
>> symbol 'meson_gx_socinfo_init' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
>> index f2d8c3c..ea091f1 100644
>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
>> @@ -97,7 +97,7 @@ static const char *socinfo_to_soc_id(u32 socinfo)
>> return "Unknown";
>> }
>>
>> -int __init meson_gx_socinfo_init(void)
>> +static int __init meson_gx_socinfo_init(void)
>> {
>> struct soc_device_attribute *soc_dev_attr;
>> struct soc_device *soc_dev;
>>
>>
>>
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Applied for v4.17, with Neil's ack.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static
Date: Thu, 08 Feb 2018 16:49:52 -0800 [thread overview]
Message-ID: <7hh8qr9ebz.fsf@baylibre.com> (raw)
In-Reply-To: <3cb83737-bb60-7648-e72e-2d39590c8418@baylibre.com> (Neil Armstrong's message of "Tue, 6 Feb 2018 13:25:19 +0100")
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 10/01/2018 15:19, Wei Yongjun wrote:
>> Fixes the following sparse warnings:
>>
>> drivers/soc/amlogic/meson-gx-socinfo.c:100:12: warning:
>> symbol 'meson_gx_socinfo_init' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
>> index f2d8c3c..ea091f1 100644
>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
>> @@ -97,7 +97,7 @@ static const char *socinfo_to_soc_id(u32 socinfo)
>> return "Unknown";
>> }
>>
>> -int __init meson_gx_socinfo_init(void)
>> +static int __init meson_gx_socinfo_init(void)
>> {
>> struct soc_device_attribute *soc_dev_attr;
>> struct soc_device *soc_dev;
>>
>>
>>
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Applied for v4.17, with Neil's ack.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
Carlo Caione <carlo@caione.org>,
Arnaud Patard <arnaud.patard@rtp-net.org>,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static
Date: Thu, 08 Feb 2018 16:49:52 -0800 [thread overview]
Message-ID: <7hh8qr9ebz.fsf@baylibre.com> (raw)
In-Reply-To: <3cb83737-bb60-7648-e72e-2d39590c8418@baylibre.com> (Neil Armstrong's message of "Tue, 6 Feb 2018 13:25:19 +0100")
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 10/01/2018 15:19, Wei Yongjun wrote:
>> Fixes the following sparse warnings:
>>
>> drivers/soc/amlogic/meson-gx-socinfo.c:100:12: warning:
>> symbol 'meson_gx_socinfo_init' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
>> index f2d8c3c..ea091f1 100644
>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
>> @@ -97,7 +97,7 @@ static const char *socinfo_to_soc_id(u32 socinfo)
>> return "Unknown";
>> }
>>
>> -int __init meson_gx_socinfo_init(void)
>> +static int __init meson_gx_socinfo_init(void)
>> {
>> struct soc_device_attribute *soc_dev_attr;
>> struct soc_device *soc_dev;
>>
>>
>>
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Applied for v4.17, with Neil's ack.
Kevin
next prev parent reply other threads:[~2018-02-09 0:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 14:19 [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static Wei Yongjun
2018-01-10 14:19 ` Wei Yongjun
2018-01-10 14:19 ` Wei Yongjun
2018-01-10 14:19 ` Wei Yongjun
2018-02-06 12:25 ` Neil Armstrong
2018-02-06 12:25 ` Neil Armstrong
2018-02-06 12:25 ` Neil Armstrong
2018-02-06 12:25 ` Neil Armstrong
2018-02-09 0:49 ` Kevin Hilman [this message]
2018-02-09 0:49 ` Kevin Hilman
2018-02-09 0:49 ` Kevin Hilman
2018-02-09 0:49 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hh8qr9ebz.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.