From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] MMC: meson: remove unused variable
Date: Thu, 15 Sep 2016 09:37:26 -0700 [thread overview]
Message-ID: <7hh99hktkp.fsf@baylibre.com> (raw)
In-Reply-To: <20160915154349.3005248-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 15 Sep 2016 17:43:35 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> The newly added meson mmc driver causes a build warning from an unused
> variable:
>
> drivers/mmc/host/meson-gxbb.c: In function 'meson_mmc_request_done':
> drivers/mmc/host/meson-gxbb.c:411:22: error: unused variable 'cmd' [-Werror=unused-variable]
>
> This removes the variable.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4b331229dda9 ("MMC: meson: initial support for GXBB platforms")
kbuild test robot reported this also, so I already fixed it for linux-next.
Kevin
> ---
> drivers/mmc/host/meson-gxbb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gxbb.c b/drivers/mmc/host/meson-gxbb.c
> index c73c62178764..193d343d0afe 100644
> --- a/drivers/mmc/host/meson-gxbb.c
> +++ b/drivers/mmc/host/meson-gxbb.c
> @@ -408,7 +408,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
> {
> struct meson_host *host = mmc_priv(mmc);
> - struct mmc_command *cmd = host->cmd;
>
> WARN_ON(host->mrq != mrq);
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Carlo Caione <carlo@caione.org>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MMC: meson: remove unused variable
Date: Thu, 15 Sep 2016 09:37:26 -0700 [thread overview]
Message-ID: <7hh99hktkp.fsf@baylibre.com> (raw)
In-Reply-To: <20160915154349.3005248-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 15 Sep 2016 17:43:35 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> The newly added meson mmc driver causes a build warning from an unused
> variable:
>
> drivers/mmc/host/meson-gxbb.c: In function 'meson_mmc_request_done':
> drivers/mmc/host/meson-gxbb.c:411:22: error: unused variable 'cmd' [-Werror=unused-variable]
>
> This removes the variable.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4b331229dda9 ("MMC: meson: initial support for GXBB platforms")
kbuild test robot reported this also, so I already fixed it for linux-next.
Kevin
> ---
> drivers/mmc/host/meson-gxbb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gxbb.c b/drivers/mmc/host/meson-gxbb.c
> index c73c62178764..193d343d0afe 100644
> --- a/drivers/mmc/host/meson-gxbb.c
> +++ b/drivers/mmc/host/meson-gxbb.c
> @@ -408,7 +408,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
> {
> struct meson_host *host = mmc_priv(mmc);
> - struct mmc_command *cmd = host->cmd;
>
> WARN_ON(host->mrq != mrq);
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MMC: meson: remove unused variable
Date: Thu, 15 Sep 2016 09:37:26 -0700 [thread overview]
Message-ID: <7hh99hktkp.fsf@baylibre.com> (raw)
In-Reply-To: <20160915154349.3005248-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 15 Sep 2016 17:43:35 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> The newly added meson mmc driver causes a build warning from an unused
> variable:
>
> drivers/mmc/host/meson-gxbb.c: In function 'meson_mmc_request_done':
> drivers/mmc/host/meson-gxbb.c:411:22: error: unused variable 'cmd' [-Werror=unused-variable]
>
> This removes the variable.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4b331229dda9 ("MMC: meson: initial support for GXBB platforms")
kbuild test robot reported this also, so I already fixed it for linux-next.
Kevin
> ---
> drivers/mmc/host/meson-gxbb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gxbb.c b/drivers/mmc/host/meson-gxbb.c
> index c73c62178764..193d343d0afe 100644
> --- a/drivers/mmc/host/meson-gxbb.c
> +++ b/drivers/mmc/host/meson-gxbb.c
> @@ -408,7 +408,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
> {
> struct meson_host *host = mmc_priv(mmc);
> - struct mmc_command *cmd = host->cmd;
>
> WARN_ON(host->mrq != mrq);
next prev parent reply other threads:[~2016-09-15 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 15:43 [PATCH] MMC: meson: remove unused variable Arnd Bergmann
2016-09-15 15:43 ` Arnd Bergmann
2016-09-15 15:43 ` Arnd Bergmann
2016-09-15 16:37 ` Kevin Hilman [this message]
2016-09-15 16:37 ` Kevin Hilman
2016-09-15 16:37 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hh99hktkp.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.