From: Kevin Hilman <khilman@baylibre.com>
To: Rong Chen <rong.chen@amlogic.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
1131046452@qq.com, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: 45581586@qq.com, Rong Chen <rong.chen@amlogic.com>
Subject: Re: [PATCH v2] mmc: meson: Fix usage of meson_mmc_post_req()
Date: Fri, 18 Feb 2022 16:34:12 -0800 [thread overview]
Message-ID: <7hiltbitiz.fsf@baylibre.com> (raw)
In-Reply-To: <20220216124239.4007667-1-rong.chen@amlogic.com>
Rong Chen <rong.chen@amlogic.com> writes:
> Currently meson_mmc_post_req() is called in meson_mmc_request() right
> after meson_mmc_start_cmd(). This could lead to DMA unmapping before the request
> is actually finished.
>
> To fix, don't call meson_mmc_post_req() until meson_mmc_request_done().
>
> Signed-off-by: Rong Chen <rong.chen@amlogic.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Rong Chen <rong.chen@amlogic.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
1131046452@qq.com, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: 45581586@qq.com, Rong Chen <rong.chen@amlogic.com>
Subject: Re: [PATCH v2] mmc: meson: Fix usage of meson_mmc_post_req()
Date: Fri, 18 Feb 2022 16:34:12 -0800 [thread overview]
Message-ID: <7hiltbitiz.fsf@baylibre.com> (raw)
In-Reply-To: <20220216124239.4007667-1-rong.chen@amlogic.com>
Rong Chen <rong.chen@amlogic.com> writes:
> Currently meson_mmc_post_req() is called in meson_mmc_request() right
> after meson_mmc_start_cmd(). This could lead to DMA unmapping before the request
> is actually finished.
>
> To fix, don't call meson_mmc_post_req() until meson_mmc_request_done().
>
> Signed-off-by: Rong Chen <rong.chen@amlogic.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Rong Chen <rong.chen@amlogic.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
1131046452@qq.com, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: 45581586@qq.com, Rong Chen <rong.chen@amlogic.com>
Subject: Re: [PATCH v2] mmc: meson: Fix usage of meson_mmc_post_req()
Date: Fri, 18 Feb 2022 16:34:12 -0800 [thread overview]
Message-ID: <7hiltbitiz.fsf@baylibre.com> (raw)
In-Reply-To: <20220216124239.4007667-1-rong.chen@amlogic.com>
Rong Chen <rong.chen@amlogic.com> writes:
> Currently meson_mmc_post_req() is called in meson_mmc_request() right
> after meson_mmc_start_cmd(). This could lead to DMA unmapping before the request
> is actually finished.
>
> To fix, don't call meson_mmc_post_req() until meson_mmc_request_done().
>
> Signed-off-by: Rong Chen <rong.chen@amlogic.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-19 0:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 12:42 [PATCH v2] mmc: meson: Fix usage of meson_mmc_post_req() Rong Chen
2022-02-16 12:42 ` Rong Chen
2022-02-16 12:42 ` Rong Chen
2022-02-19 0:34 ` Kevin Hilman [this message]
2022-02-19 0:34 ` Kevin Hilman
2022-02-19 0:34 ` Kevin Hilman
2022-02-28 17:05 ` Ulf Hansson
2022-02-28 17:05 ` Ulf Hansson
2022-02-28 17:05 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hiltbitiz.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=1131046452@qq.com \
--cc=45581586@qq.com \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=rong.chen@amlogic.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.