All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	Carlo Caione <ccaione@baylibre.com>,
	robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	martin.blumenstingl@googlemail.com
Subject: Re: [PATCH 1/2] arm64: dts: meson: Fix IRQ trigger type for macirq
Date: Tue, 04 Dec 2018 17:12:19 -0800	[thread overview]
Message-ID: <7hin08bwuk.fsf@baylibre.com> (raw)
In-Reply-To: <5C06DB0D.3010306@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> Hi Carlo,
>
> Le 04/12/2018 17:04, Carlo Caione a écrit :
>> A long running stress test on a custom board shipping an AXG SoCs and a
>> Realtek RTL8211F PHY revealed that after a few hours the connection
>> speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time
>> the 'macirq' (eth0) IRQ would stop being triggered at all and as
>> consequence the GMAC IRQs never ACKed.
>> 
>> After a painful investigation the problem seemed to be due to a wrong
>> defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of
>> EDGE_RISING.
>
> This is a good news !
>
> Kevin,
> What's the best procedure here to make it apply on the 4.19, 4.14 and 4.9 stable
> trees ? for 4.14 and 4.9 it will need to be reworked to apply correctly.

Adding a Fixes: tag where the original bug was introduce is the best way
for it to automatically get applied.

However, if rework is required, that will have to be manually done and
sent to the stable list.

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	Carlo Caione <ccaione@baylibre.com>,
	robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	martin.blumenstingl@googlemail.com
Subject: Re: [PATCH 1/2] arm64: dts: meson: Fix IRQ trigger type for macirq
Date: Tue, 04 Dec 2018 17:12:19 -0800	[thread overview]
Message-ID: <7hin08bwuk.fsf@baylibre.com> (raw)
In-Reply-To: <5C06DB0D.3010306@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> Hi Carlo,
>
> Le 04/12/2018 17:04, Carlo Caione a écrit :
>> A long running stress test on a custom board shipping an AXG SoCs and a
>> Realtek RTL8211F PHY revealed that after a few hours the connection
>> speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time
>> the 'macirq' (eth0) IRQ would stop being triggered at all and as
>> consequence the GMAC IRQs never ACKed.
>> 
>> After a painful investigation the problem seemed to be due to a wrong
>> defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of
>> EDGE_RISING.
>
> This is a good news !
>
> Kevin,
> What's the best procedure here to make it apply on the 4.19, 4.14 and 4.9 stable
> trees ? for 4.14 and 4.9 it will need to be reworked to apply correctly.

Adding a Fixes: tag where the original bug was introduce is the best way
for it to automatically get applied.

However, if rework is required, that will have to be manually done and
sent to the stable list.

Kevin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-12-05  1:12 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 16:04 [PATCH 0/2] meson: Fix IRQ trigger type Carlo Caione
2018-12-04 16:04 ` Carlo Caione
2018-12-04 16:04 ` Carlo Caione
2018-12-04 16:04 ` [PATCH 1/2] arm64: dts: meson: Fix IRQ trigger type for macirq Carlo Caione
2018-12-04 16:04   ` Carlo Caione
2018-12-04 16:04   ` Carlo Caione
2018-12-04 19:52   ` Neil Armstrong
2018-12-04 19:52     ` Neil Armstrong
2018-12-04 19:52     ` Neil Armstrong
2018-12-05  1:12     ` Kevin Hilman [this message]
2018-12-05  1:12       ` Kevin Hilman
2018-12-04 16:04 ` [PATCH 2/2] arm64: dts: meson: Remove eee-broken-1000t quirk Carlo Caione
2018-12-04 16:04   ` Carlo Caione
2018-12-04 16:04   ` Carlo Caione
2018-12-04 19:59 ` [PATCH 0/2] meson: Fix IRQ trigger type Martin Blumenstingl
2018-12-04 19:59   ` Martin Blumenstingl
2018-12-04 19:59   ` Martin Blumenstingl
2018-12-04 20:51   ` Carlo Caione
2018-12-04 20:51     ` Carlo Caione
2018-12-04 20:51     ` Carlo Caione
2018-12-06 12:43   ` Emiliano Ingrassia
2018-12-06 12:43     ` Emiliano Ingrassia
2018-12-06 12:43     ` Emiliano Ingrassia
2018-12-06 13:17     ` Carlo Caione
2018-12-06 13:17       ` Carlo Caione
2018-12-06 13:17       ` Carlo Caione
2018-12-06 15:52       ` Emiliano Ingrassia
2018-12-06 15:52         ` Emiliano Ingrassia
2018-12-06 15:52         ` Emiliano Ingrassia
2018-12-06 18:51         ` Emiliano Ingrassia
2018-12-06 18:51           ` Emiliano Ingrassia
2018-12-06 18:51           ` Emiliano Ingrassia
2018-12-07 10:49           ` Jerome Brunet
2018-12-07 10:49             ` Jerome Brunet
2018-12-07 10:49             ` Jerome Brunet
2018-12-07 11:03             ` Carlo Caione
2018-12-07 11:03               ` Carlo Caione
2018-12-07 11:03               ` Carlo Caione
2018-12-07 18:33               ` Emiliano Ingrassia
2018-12-07 18:33                 ` Emiliano Ingrassia
2018-12-07 18:33                 ` Emiliano Ingrassia
2018-12-07 18:28             ` Emiliano Ingrassia
2018-12-07 18:28               ` Emiliano Ingrassia
2018-12-07 18:28               ` Emiliano Ingrassia
2018-12-07 19:58               ` Jerome Brunet
2018-12-07 19:58                 ` Jerome Brunet
2018-12-07 19:58                 ` Jerome Brunet
2018-12-07 21:56               ` Martin Blumenstingl
2018-12-07 21:56                 ` Martin Blumenstingl
2018-12-07 21:56                 ` Martin Blumenstingl
2018-12-06 13:26     ` Jerome Brunet
2018-12-06 13:26       ` Jerome Brunet
2018-12-06 13:26       ` Jerome Brunet
2018-12-06 16:24       ` Emiliano Ingrassia
2018-12-06 16:24         ` Emiliano Ingrassia
2018-12-06 16:24         ` Emiliano Ingrassia
2018-12-06 13:26 ` Jerome Brunet
2018-12-06 13:26   ` Jerome Brunet
2018-12-06 13:26   ` Jerome Brunet
2018-12-07  4:17 ` Kevin Hilman
2018-12-07  4:17   ` Kevin Hilman
2018-12-07  4:17   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hin08bwuk.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=ccaione@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.