From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4] MMC: meson: initial support for GX platforms
Date: Wed, 19 Oct 2016 11:01:53 -0700 [thread overview]
Message-ID: <7hinso8bfy.fsf@baylibre.com> (raw)
In-Reply-To: <CABxcv=kQBAdXtks-tX1t-CkPnvFx0SWa3JzLRYK4KWk+EGZedw@mail.gmail.com> (Javier Martinez Canillas's message of "Wed, 19 Oct 2016 13:20:54 -0300")
Javier Martinez Canillas <javier@dowhile0.org> writes:
> Hello Kevin,
>
> On Tue, Oct 18, 2016 at 4:56 PM, Kevin Hilman <khilman@baylibre.com> wrote:
>> Initial support for the SD/eMMC controller in the Amlogic S905/GX*
>> family of SoCs.
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>
> [snip]
>
>> +
>> +MODULE_ALIAS("platform:" DRIVER_NAME);
>
> Why is this module alias needed? I thought that the Amlogic was a
> DT-only platform and so devices will always be registered from OF (and
> the OF modalias used).
You're right, I probably copy/pasted it from another driver.
Testing without it also made me realize that the module filename (meson_gx)
isn't really useful when listed in lsmod, so I 'll respin to have mmc in
the filename so the module name also shows mmc.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-amlogic@lists.infradead.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4] MMC: meson: initial support for GX platforms
Date: Wed, 19 Oct 2016 11:01:53 -0700 [thread overview]
Message-ID: <7hinso8bfy.fsf@baylibre.com> (raw)
In-Reply-To: <CABxcv=kQBAdXtks-tX1t-CkPnvFx0SWa3JzLRYK4KWk+EGZedw@mail.gmail.com> (Javier Martinez Canillas's message of "Wed, 19 Oct 2016 13:20:54 -0300")
Javier Martinez Canillas <javier@dowhile0.org> writes:
> Hello Kevin,
>
> On Tue, Oct 18, 2016 at 4:56 PM, Kevin Hilman <khilman@baylibre.com> wrote:
>> Initial support for the SD/eMMC controller in the Amlogic S905/GX*
>> family of SoCs.
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>
> [snip]
>
>> +
>> +MODULE_ALIAS("platform:" DRIVER_NAME);
>
> Why is this module alias needed? I thought that the Amlogic was a
> DT-only platform and so devices will always be registered from OF (and
> the OF modalias used).
You're right, I probably copy/pasted it from another driver.
Testing without it also made me realize that the module filename (meson_gx)
isn't really useful when listed in lsmod, so I 'll respin to have mmc in
the filename so the module name also shows mmc.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] MMC: meson: initial support for GX platforms
Date: Wed, 19 Oct 2016 11:01:53 -0700 [thread overview]
Message-ID: <7hinso8bfy.fsf@baylibre.com> (raw)
In-Reply-To: <CABxcv=kQBAdXtks-tX1t-CkPnvFx0SWa3JzLRYK4KWk+EGZedw@mail.gmail.com> (Javier Martinez Canillas's message of "Wed, 19 Oct 2016 13:20:54 -0300")
Javier Martinez Canillas <javier@dowhile0.org> writes:
> Hello Kevin,
>
> On Tue, Oct 18, 2016 at 4:56 PM, Kevin Hilman <khilman@baylibre.com> wrote:
>> Initial support for the SD/eMMC controller in the Amlogic S905/GX*
>> family of SoCs.
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>
> [snip]
>
>> +
>> +MODULE_ALIAS("platform:" DRIVER_NAME);
>
> Why is this module alias needed? I thought that the Amlogic was a
> DT-only platform and so devices will always be registered from OF (and
> the OF modalias used).
You're right, I probably copy/pasted it from another driver.
Testing without it also made me realize that the module filename (meson_gx)
isn't really useful when listed in lsmod, so I 'll respin to have mmc in
the filename so the module name also shows mmc.
Kevin
next prev parent reply other threads:[~2016-10-19 18:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 19:56 [PATCH v4] MMC: meson: initial support for GX platforms Kevin Hilman
2016-10-18 19:56 ` Kevin Hilman
2016-10-18 19:56 ` Kevin Hilman
2016-10-19 7:19 ` Ulf Hansson
2016-10-19 7:19 ` Ulf Hansson
2016-10-19 7:19 ` Ulf Hansson
2016-10-19 16:12 ` Kevin Hilman
2016-10-19 16:12 ` Kevin Hilman
2016-10-19 16:12 ` Kevin Hilman
2016-10-19 16:20 ` Javier Martinez Canillas
2016-10-19 16:20 ` Javier Martinez Canillas
2016-10-19 16:20 ` Javier Martinez Canillas
2016-10-19 18:01 ` Kevin Hilman [this message]
2016-10-19 18:01 ` Kevin Hilman
2016-10-19 18:01 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hinso8bfy.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.