From: Kevin Hilman <khilman@baylibre.com>
To: Guillaume La Roque <glaroque@baylibre.com>,
linus.walleij@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com
Cc: linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: pinctrl: add a 'drive-strength-uA' property
Date: Mon, 29 Apr 2019 12:19:48 -0700 [thread overview]
Message-ID: <7hk1fcr54b.fsf@baylibre.com> (raw)
In-Reply-To: <20190418124758.24022-2-glaroque@baylibre.com>
Rob,
Guillaume La Roque <glaroque@baylibre.com> writes:
> This property allow drive-strength parameter in uA instead of mA.
>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> index cef2b5855d60..fc7018459aa2 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> @@ -258,6 +258,7 @@ drive-push-pull - drive actively high and low
> drive-open-drain - drive with open drain
> drive-open-source - drive with open source
> drive-strength - sink or source at most X mA
> +drive-strength-uA - sink or source at most X uA
> input-enable - enable input on pin (no effect on output, such as
> enabling an input buffer)
> input-disable - disable input on pin (no effect on output, such as
> @@ -326,6 +327,8 @@ arguments are described below.
>
> - drive-strength takes as argument the target strength in mA.
>
> +- drive-strength-uA takes as argument the target strength in uA.
> +
> - input-debounce takes the debounce time in usec as argument
> or 0 to disable debouncing
Can we get your input on this?
Linus W. is OK with this[1], but wants opinion/approval from DT
maintainers first.
Thanks,
Kevin
[1] https://lore.kernel.org/lkml/CACRpkdZ2dPzrtJQkxmN7V=f6+qYZAvrF+b0J77cN9hoRAgFqrw@mail.gmail.com/T/#u
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Guillaume La Roque <glaroque@baylibre.com>,
linus.walleij@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: pinctrl: add a 'drive-strength-uA' property
Date: Mon, 29 Apr 2019 12:19:48 -0700 [thread overview]
Message-ID: <7hk1fcr54b.fsf@baylibre.com> (raw)
In-Reply-To: <20190418124758.24022-2-glaroque@baylibre.com>
Rob,
Guillaume La Roque <glaroque@baylibre.com> writes:
> This property allow drive-strength parameter in uA instead of mA.
>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> index cef2b5855d60..fc7018459aa2 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> @@ -258,6 +258,7 @@ drive-push-pull - drive actively high and low
> drive-open-drain - drive with open drain
> drive-open-source - drive with open source
> drive-strength - sink or source at most X mA
> +drive-strength-uA - sink or source at most X uA
> input-enable - enable input on pin (no effect on output, such as
> enabling an input buffer)
> input-disable - disable input on pin (no effect on output, such as
> @@ -326,6 +327,8 @@ arguments are described below.
>
> - drive-strength takes as argument the target strength in mA.
>
> +- drive-strength-uA takes as argument the target strength in uA.
> +
> - input-debounce takes the debounce time in usec as argument
> or 0 to disable debouncing
Can we get your input on this?
Linus W. is OK with this[1], but wants opinion/approval from DT
maintainers first.
Thanks,
Kevin
[1] https://lore.kernel.org/lkml/CACRpkdZ2dPzrtJQkxmN7V=f6+qYZAvrF+b0J77cN9hoRAgFqrw@mail.gmail.com/T/#u
next prev parent reply other threads:[~2019-04-29 19:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 12:47 [PATCH v2 0/4] Add drive-strength in Meson pinctrl driver Guillaume La Roque
2019-04-18 12:47 ` Guillaume La Roque
2019-04-18 12:47 ` [PATCH v2 1/4] dt-bindings: pinctrl: add a 'drive-strength-uA' property Guillaume La Roque
2019-04-18 12:47 ` Guillaume La Roque
2019-04-23 11:13 ` Linus Walleij
2019-04-23 11:13 ` Linus Walleij
2019-04-27 19:19 ` Martin Blumenstingl
2019-04-27 19:19 ` Martin Blumenstingl
2019-04-29 19:19 ` Kevin Hilman [this message]
2019-04-29 19:19 ` Kevin Hilman
2019-04-30 15:12 ` Rob Herring
2019-04-30 15:12 ` Rob Herring
2019-04-30 15:24 ` guillaume La Roque
2019-04-30 15:24 ` guillaume La Roque
2019-04-18 12:47 ` [PATCH v2 2/4] pinctrl: generic: add new 'drive-strength-uA' property support Guillaume La Roque
2019-04-18 12:47 ` Guillaume La Roque
2019-04-18 12:47 ` [PATCH v2 3/4] dt-bindings: pinctrl: meson: Add drive-strength-uA property Guillaume La Roque
2019-04-18 12:47 ` Guillaume La Roque
2019-04-27 19:21 ` Martin Blumenstingl
2019-04-27 19:21 ` Martin Blumenstingl
2019-04-30 6:38 ` guillaume La Roque
2019-04-30 6:38 ` guillaume La Roque
2019-04-18 12:47 ` [PATCH v2 4/4] pinctrl: meson: add support of drive-strength-uA Guillaume La Roque
2019-04-18 12:47 ` Guillaume La Roque
2019-04-27 19:44 ` Martin Blumenstingl
2019-04-27 19:44 ` Martin Blumenstingl
2019-04-30 7:20 ` guillaume La Roque
2019-04-30 7:20 ` guillaume La Roque
2019-04-30 20:28 ` Martin Blumenstingl
2019-04-30 20:28 ` Martin Blumenstingl
2019-05-06 13:16 ` guillaume La Roque
2019-05-06 13:16 ` guillaume La Roque
2019-04-23 11:13 ` [PATCH v2 0/4] Add drive-strength in Meson pinctrl driver Linus Walleij
2019-04-23 11:13 ` Linus Walleij
2019-04-27 19:46 ` Martin Blumenstingl
2019-04-27 19:46 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hk1fcr54b.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.