From: Kevin Hilman <khilman@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
linaro-kernel <linaro-kernel@lists.linaro.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled
Date: Fri, 14 Nov 2014 09:27:41 -0800 [thread overview]
Message-ID: <7hk32x8zg2.fsf@deeprootsystems.com> (raw)
In-Reply-To: <CAPDyKFou5iwX2Oe9K6n=2u6xRAqUtVNRrDn736oo0kGf0GgaLQ@mail.gmail.com> (Ulf Hansson's message of "Fri, 14 Nov 2014 08:26:58 +0100")
Hi Ulf,
Ulf Hansson <ulf.hansson@linaro.org> writes:
> On 13 November 2014 23:28, Kevin Hilman <khilman@kernel.org> wrote:
>> From: Kevin Hilman <khilman@linaro.org>
>>
>> It makes little sense to use generic power domains without runtime PM.
>> Also, since the complexities of handling the !PM_RUNTIME case are
>> causing more trouble and confusion than they're worth, let's simplify
>> the world by making genpd always enable runtime PM.
>
> I do agree that your above statement seems reasonable, even if can't
> really tell if that would break some SOCs use-cases.
Break in what way?
> My concern is though, that I fear we will be taking short-cuts in
> genpd that might bite us later on, but I might be wrong.
>
> The reason for my concern is that on every other place, like in the
> subsystem level, driver core, PM core and of course in drivers - we
> need to cope with all the combinations of CONFIG_PM_SLEEP and
> CONFIG_PM_SLEEP. So theoretically, why shouldn't genpd be able to do
> that as well?
Good question, and one we need to figure out. (I meant to mark this
patch as RFC for that reason.)
I think the primary question is: why would one want to use genpd without
runtime PM?
I understand why one might want to use/test drivers with various
combinations of PM_SLEEP and PM_RUNTIME, but I'm not seeing why we
should need to support genpd without PM_RUNTIME enabled.
In fact, on all the SoCs I've worked closely with, power domains,
suspend/resume and runtime PM are all so closely intertwined that I
can't imagine a useful scenario where they they are not all used
together. If you care about PM, you turn them all on. If you don't,
you turn them all off and ensure everything is enabled at boot.
IMO, we're spending a lot of cycles supporting these various
combinations and permutations and as a result are not really able to
solve the real problems people are raising.
Seems like most of the time a new feature/fixup/cleanup is proposed, the
discussion always ends up around how to support things when this or that
option is disabled, or some combination of kconfig options that weren't
considered.
I think we should simplify the config space permuations so we can focus
on improving the frameworks.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-pm\@vger.kernel.org" <linux-pm@vger.kernel.org>,
linaro-kernel <linaro-kernel@lists.linaro.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled
Date: Fri, 14 Nov 2014 09:27:41 -0800 [thread overview]
Message-ID: <7hk32x8zg2.fsf@deeprootsystems.com> (raw)
In-Reply-To: <CAPDyKFou5iwX2Oe9K6n=2u6xRAqUtVNRrDn736oo0kGf0GgaLQ@mail.gmail.com> (Ulf Hansson's message of "Fri, 14 Nov 2014 08:26:58 +0100")
Hi Ulf,
Ulf Hansson <ulf.hansson@linaro.org> writes:
> On 13 November 2014 23:28, Kevin Hilman <khilman@kernel.org> wrote:
>> From: Kevin Hilman <khilman@linaro.org>
>>
>> It makes little sense to use generic power domains without runtime PM.
>> Also, since the complexities of handling the !PM_RUNTIME case are
>> causing more trouble and confusion than they're worth, let's simplify
>> the world by making genpd always enable runtime PM.
>
> I do agree that your above statement seems reasonable, even if can't
> really tell if that would break some SOCs use-cases.
Break in what way?
> My concern is though, that I fear we will be taking short-cuts in
> genpd that might bite us later on, but I might be wrong.
>
> The reason for my concern is that on every other place, like in the
> subsystem level, driver core, PM core and of course in drivers - we
> need to cope with all the combinations of CONFIG_PM_SLEEP and
> CONFIG_PM_SLEEP. So theoretically, why shouldn't genpd be able to do
> that as well?
Good question, and one we need to figure out. (I meant to mark this
patch as RFC for that reason.)
I think the primary question is: why would one want to use genpd without
runtime PM?
I understand why one might want to use/test drivers with various
combinations of PM_SLEEP and PM_RUNTIME, but I'm not seeing why we
should need to support genpd without PM_RUNTIME enabled.
In fact, on all the SoCs I've worked closely with, power domains,
suspend/resume and runtime PM are all so closely intertwined that I
can't imagine a useful scenario where they they are not all used
together. If you care about PM, you turn them all on. If you don't,
you turn them all off and ensure everything is enabled at boot.
IMO, we're spending a lot of cycles supporting these various
combinations and permutations and as a result are not really able to
solve the real problems people are raising.
Seems like most of the time a new feature/fixup/cleanup is proposed, the
discussion always ends up around how to support things when this or that
option is disabled, or some combination of kconfig options that weren't
considered.
I think we should simplify the config space permuations so we can focus
on improving the frameworks.
Kevin
next prev parent reply other threads:[~2014-11-14 17:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 22:28 [PATCH] PM / Runtime: Kconfig: move ia64 dependency to arch/ia64/Kconfig Kevin Hilman
2014-11-13 22:28 ` Kevin Hilman
2014-11-13 22:28 ` Kevin Hilman
2014-11-13 22:28 ` [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled Kevin Hilman
2014-11-13 22:28 ` Kevin Hilman
2014-11-14 7:26 ` Ulf Hansson
2014-11-14 7:28 ` Ulf Hansson
2014-11-14 17:27 ` Kevin Hilman [this message]
2014-11-14 17:27 ` Kevin Hilman
2014-11-14 22:35 ` Rafael J. Wysocki
2014-11-14 7:29 ` Geert Uytterhoeven
2014-11-14 17:36 ` Kevin Hilman
2014-11-14 22:41 ` Rafael J. Wysocki
2014-11-15 20:54 ` Pavel Machek
2014-11-15 12:32 ` Geert Uytterhoeven
2014-11-17 1:22 ` Rafael J. Wysocki
2014-11-17 8:01 ` Geert Uytterhoeven
2014-11-17 18:25 ` Kevin Hilman
2014-11-18 0:39 ` [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected (was: Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled) Rafael J. Wysocki
2014-11-18 3:52 ` [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected Kevin Hilman
2014-11-18 8:32 ` Geert Uytterhoeven
2014-11-18 8:34 ` [PATCH] PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected (was: Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled) Pavel Machek
2014-11-18 20:40 ` Rafael J. Wysocki
2014-11-14 7:30 ` [PATCH] PM / Runtime: Kconfig: move ia64 dependency to arch/ia64/Kconfig Ulf Hansson
2014-11-14 7:30 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hk32x8zg2.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=geert+renesas@glider.be \
--cc=grygorii.strashko@ti.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.