From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
jbrunet@baylibre.com, linux-amlogic@lists.infradead.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] dt-bindings: clock: meson8b: drop the "ABP" clock definition
Date: Fri, 22 Mar 2019 16:53:33 -0700 [thread overview]
Message-ID: <7hmulmzcsi.fsf@baylibre.com> (raw)
In-Reply-To: <b7d2edf1-da66-a09f-5f29-28f37ce3f06b@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 19/03/2019 22:41, Martin Blumenstingl wrote:
>> Commit 8e1dd17c8b0e3f ("dt-bindings: clock: meson8b: export the CPU post
>> dividers") added a new clock ID "CLKID_ABP" which contains a typo. This
>> was fixed by adding a new (typo-free) #define CLKID_APB in
>> commit 40d08f774c17ad ("dt-bindings: clock: meson8b: add APB clock
>> definition").
>> Now that the new #define is used by the driver we can remove the old
>> one (because the old one is not used anywhere).
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> ---
>> include/dt-bindings/clock/meson8b-clkc.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/clock/meson8b-clkc.h b/include/dt-bindings/clock/meson8b-clkc.h
>> index 8067077a62ca..cd11628f50f8 100644
>> --- a/include/dt-bindings/clock/meson8b-clkc.h
>> +++ b/include/dt-bindings/clock/meson8b-clkc.h
>> @@ -103,7 +103,6 @@
>> #define CLKID_MPLL1 94
>> #define CLKID_MPLL2 95
>> #define CLKID_NAND_CLK 112
>> -#define CLKID_ABP 124
>> #define CLKID_APB 124
>> #define CLKID_PERIPH 126
>> #define CLKID_AXI 128
>>
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Neil / Jerome, I'm assuming you will queue this via the clk-meson tree?
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
jbrunet@baylibre.com, linux-amlogic@lists.infradead.org
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: clock: meson8b: drop the "ABP" clock definition
Date: Fri, 22 Mar 2019 16:53:33 -0700 [thread overview]
Message-ID: <7hmulmzcsi.fsf@baylibre.com> (raw)
In-Reply-To: <b7d2edf1-da66-a09f-5f29-28f37ce3f06b@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 19/03/2019 22:41, Martin Blumenstingl wrote:
>> Commit 8e1dd17c8b0e3f ("dt-bindings: clock: meson8b: export the CPU post
>> dividers") added a new clock ID "CLKID_ABP" which contains a typo. This
>> was fixed by adding a new (typo-free) #define CLKID_APB in
>> commit 40d08f774c17ad ("dt-bindings: clock: meson8b: add APB clock
>> definition").
>> Now that the new #define is used by the driver we can remove the old
>> one (because the old one is not used anywhere).
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> ---
>> include/dt-bindings/clock/meson8b-clkc.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/clock/meson8b-clkc.h b/include/dt-bindings/clock/meson8b-clkc.h
>> index 8067077a62ca..cd11628f50f8 100644
>> --- a/include/dt-bindings/clock/meson8b-clkc.h
>> +++ b/include/dt-bindings/clock/meson8b-clkc.h
>> @@ -103,7 +103,6 @@
>> #define CLKID_MPLL1 94
>> #define CLKID_MPLL2 95
>> #define CLKID_NAND_CLK 112
>> -#define CLKID_ABP 124
>> #define CLKID_APB 124
>> #define CLKID_PERIPH 126
>> #define CLKID_AXI 128
>>
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Neil / Jerome, I'm assuming you will queue this via the clk-meson tree?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
jbrunet@baylibre.com, linux-amlogic@lists.infradead.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] dt-bindings: clock: meson8b: drop the "ABP" clock definition
Date: Fri, 22 Mar 2019 16:53:33 -0700 [thread overview]
Message-ID: <7hmulmzcsi.fsf@baylibre.com> (raw)
In-Reply-To: <b7d2edf1-da66-a09f-5f29-28f37ce3f06b@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 19/03/2019 22:41, Martin Blumenstingl wrote:
>> Commit 8e1dd17c8b0e3f ("dt-bindings: clock: meson8b: export the CPU post
>> dividers") added a new clock ID "CLKID_ABP" which contains a typo. This
>> was fixed by adding a new (typo-free) #define CLKID_APB in
>> commit 40d08f774c17ad ("dt-bindings: clock: meson8b: add APB clock
>> definition").
>> Now that the new #define is used by the driver we can remove the old
>> one (because the old one is not used anywhere).
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> ---
>> include/dt-bindings/clock/meson8b-clkc.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/clock/meson8b-clkc.h b/include/dt-bindings/clock/meson8b-clkc.h
>> index 8067077a62ca..cd11628f50f8 100644
>> --- a/include/dt-bindings/clock/meson8b-clkc.h
>> +++ b/include/dt-bindings/clock/meson8b-clkc.h
>> @@ -103,7 +103,6 @@
>> #define CLKID_MPLL1 94
>> #define CLKID_MPLL2 95
>> #define CLKID_NAND_CLK 112
>> -#define CLKID_ABP 124
>> #define CLKID_APB 124
>> #define CLKID_PERIPH 126
>> #define CLKID_AXI 128
>>
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Neil / Jerome, I'm assuming you will queue this via the clk-meson tree?
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
jbrunet@baylibre.com, linux-amlogic@lists.infradead.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] dt-bindings: clock: meson8b: drop the "ABP" clock definition
Date: Fri, 22 Mar 2019 16:53:33 -0700 [thread overview]
Message-ID: <7hmulmzcsi.fsf@baylibre.com> (raw)
In-Reply-To: <b7d2edf1-da66-a09f-5f29-28f37ce3f06b@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 19/03/2019 22:41, Martin Blumenstingl wrote:
>> Commit 8e1dd17c8b0e3f ("dt-bindings: clock: meson8b: export the CPU post
>> dividers") added a new clock ID "CLKID_ABP" which contains a typo. This
>> was fixed by adding a new (typo-free) #define CLKID_APB in
>> commit 40d08f774c17ad ("dt-bindings: clock: meson8b: add APB clock
>> definition").
>> Now that the new #define is used by the driver we can remove the old
>> one (because the old one is not used anywhere).
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> ---
>> include/dt-bindings/clock/meson8b-clkc.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/clock/meson8b-clkc.h b/include/dt-bindings/clock/meson8b-clkc.h
>> index 8067077a62ca..cd11628f50f8 100644
>> --- a/include/dt-bindings/clock/meson8b-clkc.h
>> +++ b/include/dt-bindings/clock/meson8b-clkc.h
>> @@ -103,7 +103,6 @@
>> #define CLKID_MPLL1 94
>> #define CLKID_MPLL2 95
>> #define CLKID_NAND_CLK 112
>> -#define CLKID_ABP 124
>> #define CLKID_APB 124
>> #define CLKID_PERIPH 126
>> #define CLKID_AXI 128
>>
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Neil / Jerome, I'm assuming you will queue this via the clk-meson tree?
Kevin
next prev parent reply other threads:[~2019-03-22 23:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 21:41 [PATCH 0/1] clk: meson8b: remove CLKID with typo ("ABP" -> "APB") Martin Blumenstingl
2019-03-19 21:41 ` Martin Blumenstingl
2019-03-19 21:41 ` Martin Blumenstingl
2019-03-19 21:41 ` Martin Blumenstingl
2019-03-19 21:41 ` [PATCH 1/1] dt-bindings: clock: meson8b: drop the "ABP" clock definition Martin Blumenstingl
2019-03-19 21:41 ` Martin Blumenstingl
2019-03-19 21:41 ` Martin Blumenstingl
2019-03-19 21:41 ` Martin Blumenstingl
2019-03-20 8:12 ` Neil Armstrong
2019-03-20 8:12 ` Neil Armstrong
2019-03-20 8:12 ` Neil Armstrong
2019-03-20 8:12 ` Neil Armstrong
2019-03-22 23:53 ` Kevin Hilman [this message]
2019-03-22 23:53 ` Kevin Hilman
2019-03-22 23:53 ` Kevin Hilman
2019-03-22 23:53 ` Kevin Hilman
2019-03-23 9:54 ` Neil Armstrong
2019-03-23 9:54 ` Neil Armstrong
2019-03-23 9:54 ` Neil Armstrong
2019-03-23 9:54 ` Neil Armstrong
2019-03-31 6:41 ` Rob Herring
2019-03-31 6:41 ` Rob Herring
2019-03-31 6:41 ` Rob Herring
2019-03-31 6:41 ` Rob Herring
2019-04-01 8:34 ` [PATCH 0/1] clk: meson8b: remove CLKID with typo ("ABP" -> "APB") Neil Armstrong
2019-04-01 8:34 ` Neil Armstrong
2019-04-01 8:34 ` Neil Armstrong
2019-04-01 8:34 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hmulmzcsi.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.