All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Prathu Baronia <quic_pbaronia@quicinc.com>,
	Kevin Hilman <khilman@kernel.org>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Prathu Baronia <quic_pbaronia@quicinc.com>
Subject: Re: [PATCH] arm: omap1: replace printk() with pr_err macro
Date: Fri, 19 May 2023 10:56:55 -0700	[thread overview]
Message-ID: <7ho7mgyzko.fsf@baylibre.com> (raw)
In-Reply-To: <20230518103324.881394-1-quic_pbaronia@quicinc.com>

Prathu Baronia <quic_pbaronia@quicinc.com> writes:

> Use pr_err() macro instead of printk(KERN_ERR "...").
>
> Signed-off-by: Prathu Baronia <quic_pbaronia@quicinc.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  arch/arm/mach-omap1/pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
> index 9761d8404949..6a5815aa05e6 100644
> --- a/arch/arm/mach-omap1/pm.c
> +++ b/arch/arm/mach-omap1/pm.c
> @@ -632,7 +632,7 @@ static int __init omap_pm_init(void)
>  
>  	error = sysfs_create_file(power_kobj, &sleep_while_idle_attr.attr);
>  	if (error)
> -		printk(KERN_ERR "sysfs_create_file failed: %d\n", error);
> +		pr_err("sysfs_create_file failed: %d\n", error);
>  
>  	if (cpu_is_omap16xx()) {
>  		/* configure LOW_PWR pin */
> -- 
> 2.25.1

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Prathu Baronia <quic_pbaronia@quicinc.com>,
	Kevin Hilman <khilman@kernel.org>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Prathu Baronia <quic_pbaronia@quicinc.com>
Subject: Re: [PATCH] arm: omap1: replace printk() with pr_err macro
Date: Fri, 19 May 2023 10:56:55 -0700	[thread overview]
Message-ID: <7ho7mgyzko.fsf@baylibre.com> (raw)
In-Reply-To: <20230518103324.881394-1-quic_pbaronia@quicinc.com>

Prathu Baronia <quic_pbaronia@quicinc.com> writes:

> Use pr_err() macro instead of printk(KERN_ERR "...").
>
> Signed-off-by: Prathu Baronia <quic_pbaronia@quicinc.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  arch/arm/mach-omap1/pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
> index 9761d8404949..6a5815aa05e6 100644
> --- a/arch/arm/mach-omap1/pm.c
> +++ b/arch/arm/mach-omap1/pm.c
> @@ -632,7 +632,7 @@ static int __init omap_pm_init(void)
>  
>  	error = sysfs_create_file(power_kobj, &sleep_while_idle_attr.attr);
>  	if (error)
> -		printk(KERN_ERR "sysfs_create_file failed: %d\n", error);
> +		pr_err("sysfs_create_file failed: %d\n", error);
>  
>  	if (cpu_is_omap16xx()) {
>  		/* configure LOW_PWR pin */
> -- 
> 2.25.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-05-19 17:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 10:33 [PATCH] arm: omap1: replace printk() with pr_err macro Prathu Baronia
2023-05-18 10:33 ` Prathu Baronia
2023-05-19 17:56 ` Kevin Hilman [this message]
2023-05-19 17:56   ` Kevin Hilman
2023-05-31  5:32 ` Tony Lindgren
2023-05-31  5:32   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ho7mgyzko.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=jmkrzyszt@gmail.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=quic_pbaronia@quicinc.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.