Re: [PATCH] clk: meson: enable building as modules

[Kevin Hilman <khilman@baylibre.com>]

Jerome Brunet <jbrunet@baylibre.com> writes:

> On Tue 10 Nov 2020 at 00:36, Kevin Hilman <khilman@baylibre.com> wrote:
>
>> Make it possible to build all clk drivers as modules, but default
>> remains built-in.
>>
>> No functional changes.
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>> ---
>> Depends on series adding new API to get clk consumer from clk_hw:
>> https://lore.kernel.org/linux-amlogic/20201021162147.563655-1-jbrunet@baylibre.com/
>
> and
>
> https://lore.kernel.org/r/20201021163847.595189-1-jbrunet@baylibre.com
>
> Once these notifier allocations are dealt with, I'm happy to take this.
>
> One minor details though ...

[...]

>>  config COMMON_CLK_G12A
>> -	bool "G12 and SM1 SoC clock controllers support"
>> +	tristate "G12 and SM1 SoC clock controllers support"
>>  	depends on ARM64
>>  	default y
>>  	select COMMON_CLK_MESON_REGMAP
>> @@ -110,6 +110,7 @@ config COMMON_CLK_G12A
>>  	select COMMON_CLK_MESON_AO_CLKC
>>  	select COMMON_CLK_MESON_EE_CLKC
>>  	select COMMON_CLK_MESON_CPU_DYNDIV
>> +	select COMMON_CLK_MESON_VID_PLL_DIV
>
> This looks like a fix which could be sent separately with a fix tag,
> doesn't it ?

Ah, yes.  This is a fix which should be sent separately.  I'll split it
out and resend.

Thanks for the review,

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic