From: Kevin Hilman <khilman@baylibre.com>
To: Wolfram Sang <wsa@the-dreams.de>, Jian Hu <jian.hu@amlogic.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Hanjie Lin <hanjie.lin@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller
Date: Tue, 11 Dec 2018 13:41:25 -0800 [thread overview]
Message-ID: <7hsgz3u4fu.fsf@baylibre.com> (raw)
In-Reply-To: <20181211203652.rogajl4ajwu7cs6f@ninjato>
Wolfram Sang <wsa@the-dreams.de> writes:
>> I am okay if it is reasonable below in file
>> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi. I2c controller node just uses
>> axg's compatible.
>>
>> i2c0: i2c@1f000 {
>> compatible = "amlogic,meson-axg-i2c";
>
> Actually, you should have
>
> compatible = "amlogic,meson-g12a-i2c", "amlogic,meson-axg-i2c";
>
> in the DT to have support for future SoC specific additions. And then,
> patch 1 is needed.
>
> Or do you handle this differently? I'd think this is DT standard.
It's a DT standard *if* there are actual hardware differences. In this
case, the IP block is identical, so there are no driver changes.
We prefer to add a new compatible if and when there are actual
driver/hardware changes.
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Wolfram Sang <wsa@the-dreams.de>, Jian Hu <jian.hu@amlogic.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Carlo Caione <carlo@caione.org>, Rob Herring <robh@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Hanjie Lin <hanjie.lin@amlogic.com>,
linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller
Date: Tue, 11 Dec 2018 13:41:25 -0800 [thread overview]
Message-ID: <7hsgz3u4fu.fsf@baylibre.com> (raw)
In-Reply-To: <20181211203652.rogajl4ajwu7cs6f@ninjato>
Wolfram Sang <wsa@the-dreams.de> writes:
>> I am okay if it is reasonable below in file
>> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi. I2c controller node just uses
>> axg's compatible.
>>
>> i2c0: i2c@1f000 {
>> compatible = "amlogic,meson-axg-i2c";
>
> Actually, you should have
>
> compatible = "amlogic,meson-g12a-i2c", "amlogic,meson-axg-i2c";
>
> in the DT to have support for future SoC specific additions. And then,
> patch 1 is needed.
>
> Or do you handle this differently? I'd think this is DT standard.
It's a DT standard *if* there are actual hardware differences. In this
case, the IP block is identical, so there are no driver changes.
We prefer to add a new compatible if and when there are actual
driver/hardware changes.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Wolfram Sang <wsa@the-dreams.de>, Jian Hu <jian.hu@amlogic.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Hanjie Lin <hanjie.lin@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller
Date: Tue, 11 Dec 2018 13:41:25 -0800 [thread overview]
Message-ID: <7hsgz3u4fu.fsf@baylibre.com> (raw)
In-Reply-To: <20181211203652.rogajl4ajwu7cs6f@ninjato>
Wolfram Sang <wsa@the-dreams.de> writes:
>> I am okay if it is reasonable below in file
>> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi. I2c controller node just uses
>> axg's compatible.
>>
>> i2c0: i2c@1f000 {
>> compatible = "amlogic,meson-axg-i2c";
>
> Actually, you should have
>
> compatible = "amlogic,meson-g12a-i2c", "amlogic,meson-axg-i2c";
>
> in the DT to have support for future SoC specific additions. And then,
> patch 1 is needed.
>
> Or do you handle this differently? I'd think this is DT standard.
It's a DT standard *if* there are actual hardware differences. In this
case, the IP block is identical, so there are no driver changes.
We prefer to add a new compatible if and when there are actual
driver/hardware changes.
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-11 21:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 10:59 [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller Jian Hu
2018-11-29 10:59 ` Jian Hu
2018-11-29 10:59 ` Jian Hu
2018-11-29 10:59 ` Jian Hu
2018-11-29 10:59 ` [PATCH 1/2] dt-bindings: i2c: meson: add Meson G12A SoC i2c compatible string Jian Hu
2018-11-29 10:59 ` Jian Hu
2018-11-29 10:59 ` Jian Hu
2018-11-29 10:59 ` Jian Hu
2018-11-29 10:59 ` [PATCH 2/2] i2c: meson: add support for Meson G12A SoC I2C controller Jian Hu
2018-11-29 10:59 ` Jian Hu
2018-11-29 10:59 ` Jian Hu
2018-11-29 10:59 ` Jian Hu
2018-11-29 11:26 ` Neil Armstrong
2018-11-29 11:26 ` Neil Armstrong
2018-11-29 12:18 ` Jian Hu
2018-11-29 12:18 ` Jian Hu
2018-11-29 12:18 ` Jian Hu
2018-11-29 11:02 ` [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller Jerome Brunet
2018-11-29 11:02 ` Jerome Brunet
2018-11-29 11:02 ` Jerome Brunet
2018-11-29 11:55 ` Jian Hu
2018-11-29 11:55 ` Jian Hu
2018-11-29 11:55 ` Jian Hu
2018-12-11 20:36 ` Wolfram Sang
2018-12-11 20:36 ` Wolfram Sang
2018-12-11 20:36 ` Wolfram Sang
2018-12-11 21:41 ` Kevin Hilman [this message]
2018-12-11 21:41 ` Kevin Hilman
2018-12-11 21:41 ` Kevin Hilman
2018-12-11 21:45 ` Wolfram Sang
2018-12-11 21:45 ` Wolfram Sang
2018-12-11 21:45 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hsgz3u4fu.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=hanjie.lin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.