All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 0/2] fix clock controller register size on Meson8/Meson8b
Date: Tue, 24 Jul 2018 17:49:13 -0500	[thread overview]
Message-ID: <7hsh482qs6.fsf@baylibre.com> (raw)
In-Reply-To: <20180721190553.13940-1-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sat, 21 Jul 2018 21:05:51 +0200")

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> While working on some clock controller changes I found that the
> register size cannot be correct as it overlaps with the reset
> controller.
> Amlogic's GPL kernel sources confirm this, as well as a discussion
> I had (privately) with Yixun Lan a while ago:
>> I think 0x460 is too big, and we could narrow it down (to a small
>> size) but I haven't looked at the meson8 datasheet for what the
>> exact size of this
>
> The clock controller itself doesn't have a dedicated size because
> (just like on GXBB/GXL/GXM) the clock controller is part of a
> register area called "HHI". On GXBB this is 0x400 wide, which
> matches Meson8/Meson8b/Meson8m2 because the reset controller
> begins at CBUS + 0x4404 (0x4400 is some kind of version register),
> so "HHI" starting at 0x4000 and ending at 0x4400 sounds reasonable.

Agreed.

Applied to v4.19/dt.  Not sure if I'll get another PR out for the v4.19
merge window, but if not, I'll queue with fixes v4.19-rc.

Thanks for the fixes,

Kevin

      parent reply	other threads:[~2018-07-24 22:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-21 19:05 [PATCH 0/2] fix clock controller register size on Meson8/Meson8b Martin Blumenstingl
2018-07-21 19:05 ` [PATCH 1/2] ARM: dts: meson8: fix the clock controller register size Martin Blumenstingl
2018-07-23  7:50   ` Neil Armstrong
2018-07-21 19:05 ` [PATCH 2/2] ARM: dts: meson8b: " Martin Blumenstingl
2018-07-23  7:50   ` Neil Armstrong
2018-07-24 22:49 ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hsh482qs6.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.