All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	Chuanhong Guo <gch981213@gmail.com>,
	devicetree@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	linux-amlogic@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED
Date: Thu, 14 Mar 2019 11:08:50 -0700	[thread overview]
Message-ID: <7hva0lwcp9.fsf@baylibre.com> (raw)
In-Reply-To: <5c580f1b-1038-2c34-7047-e504eb4ac323@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> Hi Chuanhong,
>
> On 12/03/2019 09:33, Chuanhong Guo wrote:
>> There is a white LED on the front panel behind the logo and the
>> manufacturer uses that LED to indicate network and USB drive status.
>> 
>> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
>> ---
>>  .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts    | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> index 9a8a8a7e4b53..b5667f1fb2c8 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> @@ -14,6 +14,16 @@
>>  	cvbs-connector {
>>  		status = "disabled";
>>  	};
>> +
>> +	leds {
>> +		compatible = "gpio-leds";
>> +
>> +		status {
>> +			label = "n1:white:status";
>> +			gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
>> +			default-state = "on";
>> +		};
>> +	};
>>  };
>>  
>>  &cvbs_vdac_port {
>> 
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Queued for v5.2 with Neil's tag (branch: v5.2/dt64)

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	Chuanhong Guo <gch981213@gmail.com>,
	devicetree@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED
Date: Thu, 14 Mar 2019 11:08:50 -0700	[thread overview]
Message-ID: <7hva0lwcp9.fsf@baylibre.com> (raw)
In-Reply-To: <5c580f1b-1038-2c34-7047-e504eb4ac323@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> Hi Chuanhong,
>
> On 12/03/2019 09:33, Chuanhong Guo wrote:
>> There is a white LED on the front panel behind the logo and the
>> manufacturer uses that LED to indicate network and USB drive status.
>> 
>> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
>> ---
>>  .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts    | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> index 9a8a8a7e4b53..b5667f1fb2c8 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> @@ -14,6 +14,16 @@
>>  	cvbs-connector {
>>  		status = "disabled";
>>  	};
>> +
>> +	leds {
>> +		compatible = "gpio-leds";
>> +
>> +		status {
>> +			label = "n1:white:status";
>> +			gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
>> +			default-state = "on";
>> +		};
>> +	};
>>  };
>>  
>>  &cvbs_vdac_port {
>> 
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Queued for v5.2 with Neil's tag (branch: v5.2/dt64)

Kevin

  parent reply	other threads:[~2019-03-14 18:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12  8:33 [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED Chuanhong Guo
2019-03-12  8:33 ` Chuanhong Guo
2019-03-12  8:59 ` Neil Armstrong
2019-03-12  8:59   ` Neil Armstrong
2019-03-12 10:29   ` Chuanhong Guo
2019-03-12 10:29     ` Chuanhong Guo
2019-03-14 18:08   ` Kevin Hilman [this message]
2019-03-14 18:08     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hva0lwcp9.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gch981213@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.