All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Nishanth Menon <nm@ti.com>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: omap: Fix interrupt names
Date: Fri, 22 Aug 2014 21:00:27 -0700	[thread overview]
Message-ID: <7hvbpj6ejo.fsf@paris.lan> (raw)
In-Reply-To: <1408627195-18421-1-git-send-email-nm@ti.com> (Nishanth Menon's message of "Thu, 21 Aug 2014 08:19:55 -0500")

Nishanth Menon <nm@ti.com> writes:

> When viewing the /proc/interrupts, there is no information about which
> GPIO bank a specific gpio interrupt is hooked on to. This is more than a
> bit irritating as such information can esily be provided back to the
> user and at times, can be crucial for debug.
>
> So, instead of displaying something like:
> 31:	0	0  GPIO   0  palmas
> 32:	0	0  GPIO  27  mmc0
>
> Display the following with appropriate device name:
> 31:	0	0  4ae10000.gpio   0  palmas
> 32:	0	0  4805d000.gpio  27  mmc0
>
> This requires that we create irq_chip instance specific for each GPIO
> bank which is trivial to achieve.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Acked-by: Kevin Hilman <khilman@linaro.org>

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: Nishanth Menon <nm@ti.com>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	<linux-omap@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: omap: Fix interrupt names
Date: Fri, 22 Aug 2014 21:00:27 -0700	[thread overview]
Message-ID: <7hvbpj6ejo.fsf@paris.lan> (raw)
In-Reply-To: <1408627195-18421-1-git-send-email-nm@ti.com> (Nishanth Menon's message of "Thu, 21 Aug 2014 08:19:55 -0500")

Nishanth Menon <nm@ti.com> writes:

> When viewing the /proc/interrupts, there is no information about which
> GPIO bank a specific gpio interrupt is hooked on to. This is more than a
> bit irritating as such information can esily be provided back to the
> user and at times, can be crucial for debug.
>
> So, instead of displaying something like:
> 31:	0	0  GPIO   0  palmas
> 32:	0	0  GPIO  27  mmc0
>
> Display the following with appropriate device name:
> 31:	0	0  4ae10000.gpio   0  palmas
> 32:	0	0  4805d000.gpio  27  mmc0
>
> This requires that we create irq_chip instance specific for each GPIO
> bank which is trivial to achieve.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Acked-by: Kevin Hilman <khilman@linaro.org>

  parent reply	other threads:[~2014-08-23  4:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21 13:19 [PATCH] gpio: omap: Fix interrupt names Nishanth Menon
2014-08-21 13:19 ` Nishanth Menon
2014-08-21 13:37 ` Santosh Shilimkar
2014-08-21 13:37   ` Santosh Shilimkar
2014-08-21 13:57   ` Javier Martinez Canillas
2014-08-23  4:00 ` Kevin Hilman [this message]
2014-08-23  4:00   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hvbpj6ejo.fsf@paris.lan \
    --to=khilman@linaro.org \
    --cc=javier@dowhile0.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.