From: Kevin Hilman <khilman@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] arm64: dts: add support for SM1 based SEI Robotics SEI610
Date: Tue, 20 Aug 2019 13:32:40 -0700 [thread overview]
Message-ID: <7hwof7d1cn.fsf@baylibre.com> (raw)
In-Reply-To: <CAFBinCCNN_DBiriJRjw-AA-OCMFc+UgYi4oSJasJSypYFSbw9g@mail.gmail.com>
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> Hi Neil,
>
> On Tue, Aug 20, 2019 at 4:43 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Add support for the Amlogic SM1 Based SEI610 board.
>>
>> The SM1 SoC is a derivative of the G12A SoC Family with :
>> - Cortex-A55 core instead of A53
>> - more power domains, including USB & PCIe
>> - a neural network co-processor (NNA)
>> - a CSI input and image processor
>> - some changes in the audio complex, thus not yet enabled
>>
>> The SEI610 board is a derivative of the SEI510 board with :
>> - removed ADC based touch button, replaced with 3x GPIO buttons
>> - physical switch disabling on-board MICs
>> - USB-C port for USB 2.0 OTG
>> - On-board FTDI USB2SERIAL port for Linux console
>>
>> Audio, Display and USB support will be added later when support of the
>> corresponding power domains will be added, for now they are kept disabled.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> I don't have any details about this board but overall this looks sane, so:
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> [...]
>> + /* Used by Tuner, RGB Led & IR Emitter LED array */
>> + vddao_3v3_t: regultor-vddao_3v3_t {
> that should be regulator-vddao_3v3_t - maybe Kevin can fix this up, if
> not then we can still fix it with a follow-up patch
I fixed it up while applying,
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] arm64: dts: add support for SM1 based SEI Robotics SEI610
Date: Tue, 20 Aug 2019 13:32:40 -0700 [thread overview]
Message-ID: <7hwof7d1cn.fsf@baylibre.com> (raw)
In-Reply-To: <CAFBinCCNN_DBiriJRjw-AA-OCMFc+UgYi4oSJasJSypYFSbw9g@mail.gmail.com>
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> Hi Neil,
>
> On Tue, Aug 20, 2019 at 4:43 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Add support for the Amlogic SM1 Based SEI610 board.
>>
>> The SM1 SoC is a derivative of the G12A SoC Family with :
>> - Cortex-A55 core instead of A53
>> - more power domains, including USB & PCIe
>> - a neural network co-processor (NNA)
>> - a CSI input and image processor
>> - some changes in the audio complex, thus not yet enabled
>>
>> The SEI610 board is a derivative of the SEI510 board with :
>> - removed ADC based touch button, replaced with 3x GPIO buttons
>> - physical switch disabling on-board MICs
>> - USB-C port for USB 2.0 OTG
>> - On-board FTDI USB2SERIAL port for Linux console
>>
>> Audio, Display and USB support will be added later when support of the
>> corresponding power domains will be added, for now they are kept disabled.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> I don't have any details about this board but overall this looks sane, so:
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> [...]
>> + /* Used by Tuner, RGB Led & IR Emitter LED array */
>> + vddao_3v3_t: regultor-vddao_3v3_t {
> that should be regulator-vddao_3v3_t - maybe Kevin can fix this up, if
> not then we can still fix it with a follow-up patch
I fixed it up while applying,
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] arm64: dts: add support for SM1 based SEI Robotics SEI610
Date: Tue, 20 Aug 2019 13:32:40 -0700 [thread overview]
Message-ID: <7hwof7d1cn.fsf@baylibre.com> (raw)
In-Reply-To: <CAFBinCCNN_DBiriJRjw-AA-OCMFc+UgYi4oSJasJSypYFSbw9g@mail.gmail.com>
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> Hi Neil,
>
> On Tue, Aug 20, 2019 at 4:43 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Add support for the Amlogic SM1 Based SEI610 board.
>>
>> The SM1 SoC is a derivative of the G12A SoC Family with :
>> - Cortex-A55 core instead of A53
>> - more power domains, including USB & PCIe
>> - a neural network co-processor (NNA)
>> - a CSI input and image processor
>> - some changes in the audio complex, thus not yet enabled
>>
>> The SEI610 board is a derivative of the SEI510 board with :
>> - removed ADC based touch button, replaced with 3x GPIO buttons
>> - physical switch disabling on-board MICs
>> - USB-C port for USB 2.0 OTG
>> - On-board FTDI USB2SERIAL port for Linux console
>>
>> Audio, Display and USB support will be added later when support of the
>> corresponding power domains will be added, for now they are kept disabled.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> I don't have any details about this board but overall this looks sane, so:
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> [...]
>> + /* Used by Tuner, RGB Led & IR Emitter LED array */
>> + vddao_3v3_t: regultor-vddao_3v3_t {
> that should be regulator-vddao_3v3_t - maybe Kevin can fix this up, if
> not then we can still fix it with a follow-up patch
I fixed it up while applying,
Kevin
next prev parent reply other threads:[~2019-08-20 20:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 14:40 [PATCH 0/6] arm64: Add support for Amlogic SM1 SoC Family Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` [PATCH 1/6] soc: amlogic: meson-gx-socinfo: Add SM1 and S905X3 IDs Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` [PATCH 2/6] dt-bindings: soc: amlogic: clk-measure: Add SM1 compatible Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` [PATCH 3/6] soc: amlogic: clk-measure: Add support for SM1 Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` [PATCH 4/6] dt-bindings: arm: amlogic: add SM1 bindings Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 16:15 ` Rob Herring
2019-08-20 16:15 ` Rob Herring
2019-08-20 16:15 ` Rob Herring
2019-08-20 14:40 ` [PATCH 5/6] dt-bindings: arm: amlogic: add SEI Robotics SEI610 bindings Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 16:16 ` Rob Herring
2019-08-20 16:16 ` Rob Herring
2019-08-20 16:16 ` Rob Herring
2019-08-20 14:40 ` [PATCH 6/6] arm64: dts: add support for SM1 based SEI Robotics SEI610 Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 14:40 ` Neil Armstrong
2019-08-20 20:11 ` Martin Blumenstingl
2019-08-20 20:11 ` Martin Blumenstingl
2019-08-20 20:11 ` Martin Blumenstingl
2019-08-20 20:32 ` Kevin Hilman [this message]
2019-08-20 20:32 ` Kevin Hilman
2019-08-20 20:32 ` Kevin Hilman
2019-08-20 19:25 ` [PATCH 0/6] arm64: Add support for Amlogic SM1 SoC Family Kevin Hilman
2019-08-20 19:25 ` Kevin Hilman
2019-08-20 19:25 ` Kevin Hilman
2019-08-20 23:06 ` Kevin Hilman
2019-08-20 23:06 ` Kevin Hilman
2019-08-20 23:06 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hwof7d1cn.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.