* [PATCH 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU @ 2018-12-10 13:22 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: khilman Cc: linux-amlogic, linux-kernel, linux-arm-kernel, dri-devel, Neil Armstrong This patchset adds : - Optional reset properties in the midgard bindings - Mali T820 Node in Amlogic Meson GXM DTSI Christian Hewitt (1): arm64: dts: meson-gxm: Add Mali-T820 node Neil Armstrong (1): dt-bindings: gpu: mali-midgard: Add resets property .../bindings/gpu/arm,mali-midgard.txt | 2 ++ arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 +++++++++++++++++++ 2 files changed, 29 insertions(+) -- 2.19.2 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU @ 2018-12-10 13:22 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: khilman Cc: Neil Armstrong, dri-devel, linux-amlogic, linux-arm-kernel, linux-kernel This patchset adds : - Optional reset properties in the midgard bindings - Mali T820 Node in Amlogic Meson GXM DTSI Christian Hewitt (1): arm64: dts: meson-gxm: Add Mali-T820 node Neil Armstrong (1): dt-bindings: gpu: mali-midgard: Add resets property .../bindings/gpu/arm,mali-midgard.txt | 2 ++ arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 +++++++++++++++++++ 2 files changed, 29 insertions(+) -- 2.19.2 ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU @ 2018-12-10 13:22 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: khilman Cc: linux-amlogic, linux-kernel, linux-arm-kernel, dri-devel, Neil Armstrong This patchset adds : - Optional reset properties in the midgard bindings - Mali T820 Node in Amlogic Meson GXM DTSI Christian Hewitt (1): arm64: dts: meson-gxm: Add Mali-T820 node Neil Armstrong (1): dt-bindings: gpu: mali-midgard: Add resets property .../bindings/gpu/arm,mali-midgard.txt | 2 ++ arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 +++++++++++++++++++ 2 files changed, 29 insertions(+) -- 2.19.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU @ 2018-12-10 13:22 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: khilman Cc: linux-amlogic, linux-kernel, linux-arm-kernel, dri-devel, Neil Armstrong This patchset adds : - Optional reset properties in the midgard bindings - Mali T820 Node in Amlogic Meson GXM DTSI Christian Hewitt (1): arm64: dts: meson-gxm: Add Mali-T820 node Neil Armstrong (1): dt-bindings: gpu: mali-midgard: Add resets property .../bindings/gpu/arm,mali-midgard.txt | 2 ++ arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 +++++++++++++++++++ 2 files changed, 29 insertions(+) -- 2.19.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property 2018-12-10 13:22 ` Neil Armstrong (?) @ 2018-12-10 13:22 ` Neil Armstrong -1 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: devicetree, khilman Cc: linux-amlogic, linux-kernel, linux-arm-kernel, dri-devel, Neil Armstrong The Amlogic ARM Mali Midgard requires reset controls to power on and software reset the GPU, adds these as optional in the bindings. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt index 18a2cde2e5f3..24d83ec952f1 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt @@ -37,6 +37,8 @@ Optional properties: - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt for details. +- resets : Phandle to the reset controls for the Mali Midgard device. + Example for a Mali-T760: -- 2.19.2 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property @ 2018-12-10 13:22 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: devicetree, khilman Cc: Neil Armstrong, dri-devel, linux-amlogic, linux-arm-kernel, linux-kernel The Amlogic ARM Mali Midgard requires reset controls to power on and software reset the GPU, adds these as optional in the bindings. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt index 18a2cde2e5f3..24d83ec952f1 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt @@ -37,6 +37,8 @@ Optional properties: - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt for details. +- resets : Phandle to the reset controls for the Mali Midgard device. + Example for a Mali-T760: -- 2.19.2 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property @ 2018-12-10 13:22 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: devicetree, khilman Cc: linux-amlogic, linux-kernel, linux-arm-kernel, dri-devel, Neil Armstrong The Amlogic ARM Mali Midgard requires reset controls to power on and software reset the GPU, adds these as optional in the bindings. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt index 18a2cde2e5f3..24d83ec952f1 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt @@ -37,6 +37,8 @@ Optional properties: - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt for details. +- resets : Phandle to the reset controls for the Mali Midgard device. + Example for a Mali-T760: -- 2.19.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property 2018-12-10 13:22 ` Neil Armstrong (?) (?) @ 2018-12-11 16:58 ` Rob Herring -1 siblings, 0 replies; 23+ messages in thread From: Rob Herring @ 2018-12-11 16:58 UTC (permalink / raw) To: Neil Armstrong Cc: devicetree, Kevin Hilman, linux-kernel@vger.kernel.org, dri-devel, linux-amlogic, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE On Mon, Dec 10, 2018 at 7:22 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > The Amlogic ARM Mali Midgard requires reset controls to power on and > software reset the GPU, adds these as optional in the bindings. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > index 18a2cde2e5f3..24d83ec952f1 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -37,6 +37,8 @@ Optional properties: > - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt > for details. > > +- resets : Phandle to the reset controls for the Mali Midgard device. How many? Sounds like 1, but the dts has 2. There's also a similar patch for Allwinner[1]. I don't want to see a different number of resets and different names for each vendor. So first figure out how many resets the IP block has. You'll have to find someone with access to the TRM. Rob [1] https://patchwork.ozlabs.org/patch/1003654/ _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property @ 2018-12-11 16:58 ` Rob Herring 0 siblings, 0 replies; 23+ messages in thread From: Rob Herring @ 2018-12-11 16:58 UTC (permalink / raw) To: Neil Armstrong Cc: devicetree, Kevin Hilman, dri-devel, linux-amlogic, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-kernel@vger.kernel.org On Mon, Dec 10, 2018 at 7:22 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > The Amlogic ARM Mali Midgard requires reset controls to power on and > software reset the GPU, adds these as optional in the bindings. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > index 18a2cde2e5f3..24d83ec952f1 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -37,6 +37,8 @@ Optional properties: > - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt > for details. > > +- resets : Phandle to the reset controls for the Mali Midgard device. How many? Sounds like 1, but the dts has 2. There's also a similar patch for Allwinner[1]. I don't want to see a different number of resets and different names for each vendor. So first figure out how many resets the IP block has. You'll have to find someone with access to the TRM. Rob [1] https://patchwork.ozlabs.org/patch/1003654/ ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property @ 2018-12-11 16:58 ` Rob Herring 0 siblings, 0 replies; 23+ messages in thread From: Rob Herring @ 2018-12-11 16:58 UTC (permalink / raw) To: Neil Armstrong Cc: devicetree, Kevin Hilman, linux-kernel@vger.kernel.org, dri-devel, linux-amlogic, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE On Mon, Dec 10, 2018 at 7:22 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > The Amlogic ARM Mali Midgard requires reset controls to power on and > software reset the GPU, adds these as optional in the bindings. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > index 18a2cde2e5f3..24d83ec952f1 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -37,6 +37,8 @@ Optional properties: > - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt > for details. > > +- resets : Phandle to the reset controls for the Mali Midgard device. How many? Sounds like 1, but the dts has 2. There's also a similar patch for Allwinner[1]. I don't want to see a different number of resets and different names for each vendor. So first figure out how many resets the IP block has. You'll have to find someone with access to the TRM. Rob [1] https://patchwork.ozlabs.org/patch/1003654/ _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property @ 2018-12-11 16:58 ` Rob Herring 0 siblings, 0 replies; 23+ messages in thread From: Rob Herring @ 2018-12-11 16:58 UTC (permalink / raw) To: Neil Armstrong Cc: devicetree, Kevin Hilman, linux-kernel@vger.kernel.org, dri-devel, linux-amlogic, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE On Mon, Dec 10, 2018 at 7:22 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > The Amlogic ARM Mali Midgard requires reset controls to power on and > software reset the GPU, adds these as optional in the bindings. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > index 18a2cde2e5f3..24d83ec952f1 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -37,6 +37,8 @@ Optional properties: > - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt > for details. > > +- resets : Phandle to the reset controls for the Mali Midgard device. How many? Sounds like 1, but the dts has 2. There's also a similar patch for Allwinner[1]. I don't want to see a different number of resets and different names for each vendor. So first figure out how many resets the IP block has. You'll have to find someone with access to the TRM. Rob [1] https://patchwork.ozlabs.org/patch/1003654/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property 2018-12-11 16:58 ` Rob Herring (?) (?) @ 2018-12-12 9:48 ` Neil Armstrong -1 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-12 9:48 UTC (permalink / raw) To: Rob Herring Cc: devicetree, Kevin Hilman, linux-kernel@vger.kernel.org, dri-devel, linux-amlogic, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE On 11/12/2018 17:58, Rob Herring wrote: > On Mon, Dec 10, 2018 at 7:22 AM Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> The Amlogic ARM Mali Midgard requires reset controls to power on and >> software reset the GPU, adds these as optional in the bindings. >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> index 18a2cde2e5f3..24d83ec952f1 100644 >> --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> @@ -37,6 +37,8 @@ Optional properties: >> - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt >> for details. >> >> +- resets : Phandle to the reset controls for the Mali Midgard device. > > How many? Sounds like 1, but the dts has 2. There's also a similar > patch for Allwinner[1]. I don't want to see a different number of > resets and different names for each vendor. So first figure out how > many resets the IP block has. You'll have to find someone with access > to the TRM. I can answer for Amlogic, they have a reset for the bus interface and the GPU IP itself. You are asking something impossible ;-) We can assume it has a single reset interface, but vendors can add more to reset some glue HW. So we will need some variant per-vendor, sorry to annoy you ! Neil > > Rob > > [1] https://patchwork.ozlabs.org/patch/1003654/ > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property @ 2018-12-12 9:48 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-12 9:48 UTC (permalink / raw) To: Rob Herring Cc: devicetree, Kevin Hilman, dri-devel, linux-amlogic, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-kernel@vger.kernel.org On 11/12/2018 17:58, Rob Herring wrote: > On Mon, Dec 10, 2018 at 7:22 AM Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> The Amlogic ARM Mali Midgard requires reset controls to power on and >> software reset the GPU, adds these as optional in the bindings. >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> index 18a2cde2e5f3..24d83ec952f1 100644 >> --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> @@ -37,6 +37,8 @@ Optional properties: >> - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt >> for details. >> >> +- resets : Phandle to the reset controls for the Mali Midgard device. > > How many? Sounds like 1, but the dts has 2. There's also a similar > patch for Allwinner[1]. I don't want to see a different number of > resets and different names for each vendor. So first figure out how > many resets the IP block has. You'll have to find someone with access > to the TRM. I can answer for Amlogic, they have a reset for the bus interface and the GPU IP itself. You are asking something impossible ;-) We can assume it has a single reset interface, but vendors can add more to reset some glue HW. So we will need some variant per-vendor, sorry to annoy you ! Neil > > Rob > > [1] https://patchwork.ozlabs.org/patch/1003654/ > ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property @ 2018-12-12 9:48 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-12 9:48 UTC (permalink / raw) To: Rob Herring Cc: devicetree, Kevin Hilman, linux-kernel@vger.kernel.org, dri-devel, linux-amlogic, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE On 11/12/2018 17:58, Rob Herring wrote: > On Mon, Dec 10, 2018 at 7:22 AM Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> The Amlogic ARM Mali Midgard requires reset controls to power on and >> software reset the GPU, adds these as optional in the bindings. >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> index 18a2cde2e5f3..24d83ec952f1 100644 >> --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> @@ -37,6 +37,8 @@ Optional properties: >> - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt >> for details. >> >> +- resets : Phandle to the reset controls for the Mali Midgard device. > > How many? Sounds like 1, but the dts has 2. There's also a similar > patch for Allwinner[1]. I don't want to see a different number of > resets and different names for each vendor. So first figure out how > many resets the IP block has. You'll have to find someone with access > to the TRM. I can answer for Amlogic, they have a reset for the bus interface and the GPU IP itself. You are asking something impossible ;-) We can assume it has a single reset interface, but vendors can add more to reset some glue HW. So we will need some variant per-vendor, sorry to annoy you ! Neil > > Rob > > [1] https://patchwork.ozlabs.org/patch/1003654/ > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property @ 2018-12-12 9:48 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-12 9:48 UTC (permalink / raw) To: Rob Herring Cc: devicetree, Kevin Hilman, linux-kernel@vger.kernel.org, dri-devel, linux-amlogic, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE On 11/12/2018 17:58, Rob Herring wrote: > On Mon, Dec 10, 2018 at 7:22 AM Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> The Amlogic ARM Mali Midgard requires reset controls to power on and >> software reset the GPU, adds these as optional in the bindings. >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> index 18a2cde2e5f3..24d83ec952f1 100644 >> --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt >> @@ -37,6 +37,8 @@ Optional properties: >> - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt >> for details. >> >> +- resets : Phandle to the reset controls for the Mali Midgard device. > > How many? Sounds like 1, but the dts has 2. There's also a similar > patch for Allwinner[1]. I don't want to see a different number of > resets and different names for each vendor. So first figure out how > many resets the IP block has. You'll have to find someone with access > to the TRM. I can answer for Amlogic, they have a reset for the bus interface and the GPU IP itself. You are asking something impossible ;-) We can assume it has a single reset interface, but vendors can add more to reset some glue HW. So we will need some variant per-vendor, sorry to annoy you ! Neil > > Rob > > [1] https://patchwork.ozlabs.org/patch/1003654/ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 2/2] arm64: dts: meson-gxm: Add Mali-T820 node 2018-12-10 13:22 ` Neil Armstrong (?) (?) @ 2018-12-10 13:22 ` Neil Armstrong -1 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: khilman Cc: Neil Armstrong, Christian Hewitt, linux-kernel, dri-devel, linux-amlogic, linux-arm-kernel From: Christian Hewitt <christianshewitt@gmail.com> The Amlogic Meson GXM SoC embeds an ARM Mali T820 GPU. This patch adds the node with all the needed properties to power on the GPU. This has been tested with the work-in-progress PanFrost project aiming support for ARM Mali Midgard and later GPUs. Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi index 247888d68a3a..35e59d390903 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi @@ -91,6 +91,33 @@ reset-names = "phy"; status = "okay"; }; + + mali: gpu@c0000 { + compatible = "amlogic,meson-gxm-mali", "arm,mali-t820"; + reg = <0x0 0xc0000 0x0 0x40000>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "gpu", "mmu", "job"; + clocks = <&clkc CLKID_MALI>; + resets = <&reset RESET_MALI_CAPB3>, <&reset RESET_MALI>; + + /* + * Mali clocking is provided by two identical clock paths + * MALI_0 and MALI_1 muxed to a single clock by a glitch + * free mux to safely change frequency while running. + */ + assigned-clocks = <&clkc CLKID_MALI_0_SEL>, + <&clkc CLKID_MALI_0>, + <&clkc CLKID_MALI>; /* Glitch free mux */ + assigned-clock-parents = <&clkc CLKID_FCLK_DIV3>, + <0>, /* Do Nothing */ + <&clkc CLKID_MALI_0>; + assigned-clock-rates = <0>, /* Do Nothing */ + <666666666>, + <0>; /* Do Nothing */ + }; }; &clkc_AO { -- 2.19.2 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/2] arm64: dts: meson-gxm: Add Mali-T820 node @ 2018-12-10 13:22 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: khilman Cc: Christian Hewitt, dri-devel, linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong From: Christian Hewitt <christianshewitt@gmail.com> The Amlogic Meson GXM SoC embeds an ARM Mali T820 GPU. This patch adds the node with all the needed properties to power on the GPU. This has been tested with the work-in-progress PanFrost project aiming support for ARM Mali Midgard and later GPUs. Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi index 247888d68a3a..35e59d390903 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi @@ -91,6 +91,33 @@ reset-names = "phy"; status = "okay"; }; + + mali: gpu@c0000 { + compatible = "amlogic,meson-gxm-mali", "arm,mali-t820"; + reg = <0x0 0xc0000 0x0 0x40000>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "gpu", "mmu", "job"; + clocks = <&clkc CLKID_MALI>; + resets = <&reset RESET_MALI_CAPB3>, <&reset RESET_MALI>; + + /* + * Mali clocking is provided by two identical clock paths + * MALI_0 and MALI_1 muxed to a single clock by a glitch + * free mux to safely change frequency while running. + */ + assigned-clocks = <&clkc CLKID_MALI_0_SEL>, + <&clkc CLKID_MALI_0>, + <&clkc CLKID_MALI>; /* Glitch free mux */ + assigned-clock-parents = <&clkc CLKID_FCLK_DIV3>, + <0>, /* Do Nothing */ + <&clkc CLKID_MALI_0>; + assigned-clock-rates = <0>, /* Do Nothing */ + <666666666>, + <0>; /* Do Nothing */ + }; }; &clkc_AO { -- 2.19.2 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/2] arm64: dts: meson-gxm: Add Mali-T820 node @ 2018-12-10 13:22 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: khilman Cc: Neil Armstrong, Christian Hewitt, linux-kernel, dri-devel, linux-amlogic, linux-arm-kernel From: Christian Hewitt <christianshewitt@gmail.com> The Amlogic Meson GXM SoC embeds an ARM Mali T820 GPU. This patch adds the node with all the needed properties to power on the GPU. This has been tested with the work-in-progress PanFrost project aiming support for ARM Mali Midgard and later GPUs. Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi index 247888d68a3a..35e59d390903 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi @@ -91,6 +91,33 @@ reset-names = "phy"; status = "okay"; }; + + mali: gpu@c0000 { + compatible = "amlogic,meson-gxm-mali", "arm,mali-t820"; + reg = <0x0 0xc0000 0x0 0x40000>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "gpu", "mmu", "job"; + clocks = <&clkc CLKID_MALI>; + resets = <&reset RESET_MALI_CAPB3>, <&reset RESET_MALI>; + + /* + * Mali clocking is provided by two identical clock paths + * MALI_0 and MALI_1 muxed to a single clock by a glitch + * free mux to safely change frequency while running. + */ + assigned-clocks = <&clkc CLKID_MALI_0_SEL>, + <&clkc CLKID_MALI_0>, + <&clkc CLKID_MALI>; /* Glitch free mux */ + assigned-clock-parents = <&clkc CLKID_FCLK_DIV3>, + <0>, /* Do Nothing */ + <&clkc CLKID_MALI_0>; + assigned-clock-rates = <0>, /* Do Nothing */ + <666666666>, + <0>; /* Do Nothing */ + }; }; &clkc_AO { -- 2.19.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/2] arm64: dts: meson-gxm: Add Mali-T820 node @ 2018-12-10 13:22 ` Neil Armstrong 0 siblings, 0 replies; 23+ messages in thread From: Neil Armstrong @ 2018-12-10 13:22 UTC (permalink / raw) To: khilman Cc: Neil Armstrong, Christian Hewitt, linux-kernel, dri-devel, linux-amlogic, linux-arm-kernel From: Christian Hewitt <christianshewitt@gmail.com> The Amlogic Meson GXM SoC embeds an ARM Mali T820 GPU. This patch adds the node with all the needed properties to power on the GPU. This has been tested with the work-in-progress PanFrost project aiming support for ARM Mali Midgard and later GPUs. Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi index 247888d68a3a..35e59d390903 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi @@ -91,6 +91,33 @@ reset-names = "phy"; status = "okay"; }; + + mali: gpu@c0000 { + compatible = "amlogic,meson-gxm-mali", "arm,mali-t820"; + reg = <0x0 0xc0000 0x0 0x40000>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "gpu", "mmu", "job"; + clocks = <&clkc CLKID_MALI>; + resets = <&reset RESET_MALI_CAPB3>, <&reset RESET_MALI>; + + /* + * Mali clocking is provided by two identical clock paths + * MALI_0 and MALI_1 muxed to a single clock by a glitch + * free mux to safely change frequency while running. + */ + assigned-clocks = <&clkc CLKID_MALI_0_SEL>, + <&clkc CLKID_MALI_0>, + <&clkc CLKID_MALI>; /* Glitch free mux */ + assigned-clock-parents = <&clkc CLKID_FCLK_DIV3>, + <0>, /* Do Nothing */ + <&clkc CLKID_MALI_0>; + assigned-clock-rates = <0>, /* Do Nothing */ + <666666666>, + <0>; /* Do Nothing */ + }; }; &clkc_AO { -- 2.19.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU 2018-12-10 13:22 ` Neil Armstrong (?) (?) @ 2018-12-10 21:15 ` Kevin Hilman -1 siblings, 0 replies; 23+ messages in thread From: Kevin Hilman @ 2018-12-10 21:15 UTC (permalink / raw) To: Neil Armstrong Cc: linux-amlogic, linux-kernel, linux-arm-kernel, dri-devel, Neil Armstrong Neil Armstrong <narmstrong@baylibre.com> writes: > This patchset adds : > - Optional reset properties in the midgard bindings > - Mali T820 Node in Amlogic Meson GXM DTSI > > Christian Hewitt (1): > arm64: dts: meson-gxm: Add Mali-T820 node > > Neil Armstrong (1): > dt-bindings: gpu: mali-midgard: Add resets property Queued for v4.21 (branch: dt64) Thanks, Kevin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU @ 2018-12-10 21:15 ` Kevin Hilman 0 siblings, 0 replies; 23+ messages in thread From: Kevin Hilman @ 2018-12-10 21:15 UTC (permalink / raw) To: Neil Armstrong Cc: Neil Armstrong, dri-devel, linux-amlogic, linux-arm-kernel, linux-kernel Neil Armstrong <narmstrong@baylibre.com> writes: > This patchset adds : > - Optional reset properties in the midgard bindings > - Mali T820 Node in Amlogic Meson GXM DTSI > > Christian Hewitt (1): > arm64: dts: meson-gxm: Add Mali-T820 node > > Neil Armstrong (1): > dt-bindings: gpu: mali-midgard: Add resets property Queued for v4.21 (branch: dt64) Thanks, Kevin ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU @ 2018-12-10 21:15 ` Kevin Hilman 0 siblings, 0 replies; 23+ messages in thread From: Kevin Hilman @ 2018-12-10 21:15 UTC (permalink / raw) Cc: linux-amlogic, linux-kernel, linux-arm-kernel, dri-devel, Neil Armstrong Neil Armstrong <narmstrong@baylibre.com> writes: > This patchset adds : > - Optional reset properties in the midgard bindings > - Mali T820 Node in Amlogic Meson GXM DTSI > > Christian Hewitt (1): > arm64: dts: meson-gxm: Add Mali-T820 node > > Neil Armstrong (1): > dt-bindings: gpu: mali-midgard: Add resets property Queued for v4.21 (branch: dt64) Thanks, Kevin _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU @ 2018-12-10 21:15 ` Kevin Hilman 0 siblings, 0 replies; 23+ messages in thread From: Kevin Hilman @ 2018-12-10 21:15 UTC (permalink / raw) To: Neil Armstrong Cc: linux-amlogic, linux-kernel, linux-arm-kernel, dri-devel, Neil Armstrong Neil Armstrong <narmstrong@baylibre.com> writes: > This patchset adds : > - Optional reset properties in the midgard bindings > - Mali T820 Node in Amlogic Meson GXM DTSI > > Christian Hewitt (1): > arm64: dts: meson-gxm: Add Mali-T820 node > > Neil Armstrong (1): > dt-bindings: gpu: mali-midgard: Add resets property Queued for v4.21 (branch: dt64) Thanks, Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2018-12-12 9:48 UTC | newest] Thread overview: 23+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-12-10 13:22 [PATCH 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU Neil Armstrong 2018-12-10 13:22 ` Neil Armstrong 2018-12-10 13:22 ` Neil Armstrong 2018-12-10 13:22 ` Neil Armstrong 2018-12-10 13:22 ` [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property Neil Armstrong 2018-12-10 13:22 ` Neil Armstrong 2018-12-10 13:22 ` Neil Armstrong 2018-12-11 16:58 ` Rob Herring 2018-12-11 16:58 ` Rob Herring 2018-12-11 16:58 ` Rob Herring 2018-12-11 16:58 ` Rob Herring 2018-12-12 9:48 ` Neil Armstrong 2018-12-12 9:48 ` Neil Armstrong 2018-12-12 9:48 ` Neil Armstrong 2018-12-12 9:48 ` Neil Armstrong 2018-12-10 13:22 ` [PATCH 2/2] arm64: dts: meson-gxm: Add Mali-T820 node Neil Armstrong 2018-12-10 13:22 ` Neil Armstrong 2018-12-10 13:22 ` Neil Armstrong 2018-12-10 13:22 ` Neil Armstrong 2018-12-10 21:15 ` [PATCH 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU Kevin Hilman 2018-12-10 21:15 ` Kevin Hilman 2018-12-10 21:15 ` Kevin Hilman 2018-12-10 21:15 ` Kevin Hilman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.