From: Junio C Hamano <gitster@pobox.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Git Mailinglist <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [RFC PATCH] Teach rebase to rebase even if upstream is up to date with -f
Date: Thu, 12 Feb 2009 23:15:10 -0800 [thread overview]
Message-ID: <7v1vu2g64h.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <bd6139dc0902122251j24696806xb89de3e338d49cb@mail.gmail.com> (Sverre Rabbelier's message of "Fri, 13 Feb 2009 07:51:17 +0100")
Sverre Rabbelier <srabbelier@gmail.com> writes:
> On Fri, Feb 13, 2009 at 07:22, Junio C Hamano <gitster@pobox.com> wrote:
> ...
>> One more thing. I kept saying "detect --whitespace=fix (or its synonym
>> strip)" because people can have "apply.whitespace = fix" in their
>> configuration file for use with "git am", and countermand the
>> configuration with "git rebase --whitespace=warn". Such a usage should
>> not imply --force.
>
> Ok, so having 'apply.whitespace = fix' in your config _should_ imply
> -f, and '--whitespace=[no]warn' as commandline option should not
> affect '-f'.
Well, that is actually not quite what I meant.
The intention of the user who runs "git rebase" without an explicit option
(-f nor --whitespace) with such a config is ambiguous.
But "git rebase --whitespace=fix" *is* unambiguously "I'd like to fix it",
with or without a config. It should imply --force.
Similarly "git rebase --whitespace=warn" *is* unambiguously "I do not want
the rebasing process to touch it, just warn, if necessary". It should not
imply --force.
So I think it would be the most natural to look only at command line
option --whitespace=*, and make fix/strip imply --force, without looking
at config.
prev parent reply other threads:[~2009-02-13 7:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 19:47 [RFC PATCH] Teach rebase to rebase even if upstream is up to date with -f Sverre Rabbelier
2009-02-12 20:28 ` Johannes Schindelin
2009-02-12 20:30 ` Sverre Rabbelier
2009-02-12 20:37 ` Johannes Schindelin
2009-02-12 20:44 ` Sverre Rabbelier
2009-02-12 21:34 ` Junio C Hamano
2009-02-12 21:57 ` Sverre Rabbelier
2009-02-12 23:22 ` Junio C Hamano
2009-02-12 23:24 ` Sverre Rabbelier
2009-02-13 1:32 ` Junio C Hamano
2009-02-13 6:02 ` Sverre Rabbelier
2009-02-13 6:22 ` Junio C Hamano
2009-02-13 6:51 ` Sverre Rabbelier
2009-02-13 7:15 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1vu2g64h.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.