From: Junio C Hamano <gitster@pobox.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Git Mailinglist <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Eric Wong <normalperson@yhbt.net>,
"Shawn O. Pear,
Sverre Rabbelier
<srabbelier@gmail.com>"@b-sasl-quonix.sasl.smtp.pobox.com
Subject: Re: [RFC PATCH] Teach rebase to rebase even if upstream is up to date with -f
Date: Thu, 12 Feb 2009 15:22:09 -0800 [thread overview]
Message-ID: <7viqnfi6la.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <bd6139dc0902121357l1eea7b8xe890513b756e97c2@mail.gmail.com> (Sverre Rabbelier's message of "Thu, 12 Feb 2009 22:57:17 +0100")
Sverre Rabbelier <srabbelier@gmail.com> writes:
> On Thu, Feb 12, 2009 at 22:34, Junio C Hamano <gitster@pobox.com> wrote:
>> For that, I would prefer to see:
>> (1) git format-patch --stdout origin >my.mbox
>> (2) git fetch origin
>> (3) git checkout origin ;# yes, detach
>> (4) git am --whitespace=fix my.mbox
>> (5) make test
>> (6) git format-patch -o to-send-out origin
>> (7) git send-email ..options.. to-send-out
>
> If I understand things correctly 'git rebase -f --whitespace=fix
> origin' does only 1 and 4, yes? In my workflow I do 2 and 5 as 'git
> pull --rebase' before I push anything, and since I push rather then
> send-email, I never use 6 and 7. That leaves 3, which I guess is
> specific to your workflow? I am guessing you detach to make it easier
> to easily test many different topic branches.
>
>> It fixes whitespace breakages, but more importantly, the procedure makes
>> sure that what you will be sending out will apply cleanly to the origin
>> that may have progressed since you last looked at it.
>
> Mhhh, would 'git fetch && git rebase -f whitespace=fix orgin' do the
> same? Do you see any other problems with the patch?
No, because I didn't read the patch text; I don't read patches that are
larger than 20 lines during the day-job hours.
I was only commenting on your "rebase does not work if I am up to date
with respect to origin and here is my workaround".
Obviously neither the "fetch origin and reapply" nor "pull --rebase" would
make any difference if you were indeed up to date.
next prev parent reply other threads:[~2009-02-12 23:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 19:47 [RFC PATCH] Teach rebase to rebase even if upstream is up to date with -f Sverre Rabbelier
2009-02-12 20:28 ` Johannes Schindelin
2009-02-12 20:30 ` Sverre Rabbelier
2009-02-12 20:37 ` Johannes Schindelin
2009-02-12 20:44 ` Sverre Rabbelier
2009-02-12 21:34 ` Junio C Hamano
2009-02-12 21:57 ` Sverre Rabbelier
2009-02-12 23:22 ` Junio C Hamano [this message]
2009-02-12 23:24 ` Sverre Rabbelier
2009-02-13 1:32 ` Junio C Hamano
2009-02-13 6:02 ` Sverre Rabbelier
2009-02-13 6:22 ` Junio C Hamano
2009-02-13 6:51 ` Sverre Rabbelier
2009-02-13 7:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqnfi6la.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc="Shawn O. Pear, Sverre Rabbelier <srabbelier@gmail.com>"@b-sasl-quonix.sasl.smtp.pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.