From: Junio C Hamano <gitster@pobox.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 3/2] pretty: support right alignment
Date: Thu, 20 Sep 2012 09:40:49 -0700 [thread overview]
Message-ID: <7v392cd4vi.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120920143803.GA9527@lanh> (Nguyen Thai Ngoc Duy's message of "Thu, 20 Sep 2012 21:38:03 +0700")
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
> And this is a for-fun patch that adds %| to right align everything
> after that. I'm ignoring problems with line wrapping, i18n and so
> on. "%C+%h %s%|%d" looks quite nice. I'm not sure how much useful it
> is beyond --oneline though. It looks something like this
> ...
> [oneline output ellided]
> ...
I think this is a great feature at the conceptual level, and you
know "but" is coming ;-).
- Shouldn't it be "everything from there until the end of the
current line" than "everything after that"?
- How is the display width determined and is it fixed once it gets
computed?
- How does this interact with the wrapped output? Should it?
- I am wondering if somebody ever want to do this with a follow-up
patch:
Left %h%|Center %cd%|Right %ad
Is %| a sensible choice for "flush right"? I am wondering if it
makes more sense to make %|, %< and %> as "multi-column
introducer" (the example defines output with three columns) that
also tells how text inside each column is flushed inside the
column, e.g.
%>col 1 right flushed%|col 2 centered%< col 3 left flushed
or something like that (we may want explicit "column width"
specifiers if we were to do this kind of thing).
next prev parent reply other threads:[~2012-09-20 16:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 11:52 [PATCH] log --oneline: put decoration at the end of the line Nguyễn Thái Ngọc Duy
2012-09-19 18:20 ` Jeff King
2012-09-19 19:57 ` Junio C Hamano
2012-09-19 20:05 ` Jeff King
2012-09-19 23:34 ` Junio C Hamano
2012-09-19 23:42 ` Jeff King
2012-09-20 0:18 ` Junio C Hamano
2012-09-20 10:43 ` Nguyen Thai Ngoc Duy
2012-09-20 12:26 ` [PATCH 0/2] New pretty format color specifiers %C+ and %C- Nguyễn Thái Ngọc Duy
2012-09-20 12:26 ` [PATCH 1/2] pretty: share code between format_decoration and show_decorations Nguyễn Thái Ngọc Duy
2012-09-20 12:26 ` [PATCH 2/2] pretty: support placeholders %C+ and %C- Nguyễn Thái Ngọc Duy
2012-09-20 14:38 ` [PATCH 3/2] pretty: support right alignment Nguyen Thai Ngoc Duy
2012-09-20 16:40 ` Junio C Hamano [this message]
2012-09-21 8:55 ` Nguyen Thai Ngoc Duy
2012-09-21 17:46 ` Junio C Hamano
2012-09-23 8:17 ` Junio C Hamano
2012-09-25 0:27 ` Jeff King
2012-09-21 13:03 ` Nguyen Thai Ngoc Duy
2012-09-20 16:47 ` [PATCH 2/2] pretty: support placeholders %C+ and %C- Junio C Hamano
2012-09-20 17:47 ` Junio C Hamano
2012-09-21 8:36 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v392cd4vi.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.