All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] log --oneline: put decoration at the end of the line
Date: Wed, 19 Sep 2012 17:18:14 -0700	[thread overview]
Message-ID: <7v392deed5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120919234226.GA27626@sigill.intra.peff.net> (Jeff King's message of "Wed, 19 Sep 2012 19:42:26 -0400")

Jeff King <peff@peff.net> writes:

> On Wed, Sep 19, 2012 at 04:34:19PM -0700, Junio C Hamano wrote:
>
>> > Yeah, I do not think it is likely.  Among the in-tree scripts,
>> > git-stash does use rev-list --oneline but the purpose of the call
>> > exactly is to grab a human readable one line summary, and it will be
>> > happy with any change to make --oneline more human readble.
>> 
>> Having said that, one of my often used alias is
>> 
>>     [alias] recent = log --branches --oneline --no-merges --decorate --since=3.weeks
>> 
>> to help me see what topics in flight may potentially interact with
>> an incoming patch, when deciding on which commit to base the patch
>> on.  Pushing the decoration at the end to let it fall off the right
>> edge of the screen severely reduces the usefulness of it and defeats
>> the point of using --decorate, at least for this use.
>> 
>> I could use --source instead, though, if it is not moved by the
>> patch.
>
> If you are particular about the exact format, how about using
> --format="%h%d %s" instead?
>
> Obviously Duy could do the same to achieve his format,...

It indeed was the first reaction when I saw the patch under
discussion that came without RFC/ in the subject.

> but I think there
> is still value in considering what the default for --oneline should be.

Yes.  And I was reasonably sure that having the decoration at the
tail is a better default, but no longer.

  reply	other threads:[~2012-09-20  0:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19 11:52 [PATCH] log --oneline: put decoration at the end of the line Nguyễn Thái Ngọc Duy
2012-09-19 18:20 ` Jeff King
2012-09-19 19:57   ` Junio C Hamano
2012-09-19 20:05     ` Jeff King
2012-09-19 23:34     ` Junio C Hamano
2012-09-19 23:42       ` Jeff King
2012-09-20  0:18         ` Junio C Hamano [this message]
2012-09-20 10:43         ` Nguyen Thai Ngoc Duy
2012-09-20 12:26           ` [PATCH 0/2] New pretty format color specifiers %C+ and %C- Nguyễn Thái Ngọc Duy
2012-09-20 12:26             ` [PATCH 1/2] pretty: share code between format_decoration and show_decorations Nguyễn Thái Ngọc Duy
2012-09-20 12:26             ` [PATCH 2/2] pretty: support placeholders %C+ and %C- Nguyễn Thái Ngọc Duy
2012-09-20 14:38               ` [PATCH 3/2] pretty: support right alignment Nguyen Thai Ngoc Duy
2012-09-20 16:40                 ` Junio C Hamano
2012-09-21  8:55                   ` Nguyen Thai Ngoc Duy
2012-09-21 17:46                     ` Junio C Hamano
2012-09-23  8:17                     ` Junio C Hamano
2012-09-25  0:27                       ` Jeff King
2012-09-21 13:03                   ` Nguyen Thai Ngoc Duy
2012-09-20 16:47               ` [PATCH 2/2] pretty: support placeholders %C+ and %C- Junio C Hamano
2012-09-20 17:47                 ` Junio C Hamano
2012-09-21  8:36                   ` Nguyen Thai Ngoc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v392deed5.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.