All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org
Subject: Re: Octopus merge: unique (?) to git, but is it useful?
Date: Mon, 02 Jun 2008 20:56:52 -0700	[thread overview]
Message-ID: <7v3anv5fy3.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0806021845210.3473@woody.linux-foundation.org> (Linus Torvalds's message of "Mon, 2 Jun 2008 19:05:03 -0700 (PDT)")

Linus Torvalds <torvalds@linux-foundation.org> writes:

> Junio: see kernel commits a733a5da9 and 52b097fff89, done as lately as 
> February of this year. We shouldn't allow that kind of thing,...

Well, we even allow fast-forwrad to be recorded as a true merge if the
user asks these days.

And the thing is, that "a733a5da9" commit has a smoking-gun evidence that
a nonsense is asked by the committer.

    commit a733a5da97b238e3e3167d3d0aee8fe1e8d04e97
    Merge: 299cfe3... 299cfe3... 9e52797...
    Author:     Len Brown <len.brown@intel.com>
    AuthorDate: Thu Feb 7 03:38:22 2008 -0500
    Commit:     Len Brown <len.brown@intel.com>
    CommitDate: Thu Feb 7 03:38:22 2008 -0500

        Merge branches 'release' and 'fluff' into release

        Conflicts:

            drivers/acpi/scan.c
            include/linux/acpi.h

        Signed-off-by: Len Brown <len.brown@intel.com>

"Merge branches 'RELEASE' and 'fluff' into RELEASE"?  That happens if you
are _on_ release branch and say "git merge release fluff".

Having said that, I think what is happening is that the final set of
"other parents" is computed inside git-merge out of MERGE_HEAD and that is
usually what is recorded in the resulting merge, but if the merge results
in a conflict with manual resolution, that information is not given to the
final "git commit".  The resulting commit records the parents out of HEAD
and MERGE_HEAD.  I do not think this part has changed from scripted
version of git-commit.

  reply	other threads:[~2008-06-03  3:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03  1:14 Octopus merge: unique (?) to git, but is it useful? Jakub Narebski
2008-06-03  2:05 ` Linus Torvalds
2008-06-03  3:56   ` Junio C Hamano [this message]
2008-06-03  5:17     ` Junio C Hamano
2008-06-03  5:28       ` Johannes Schindelin
2008-06-03  5:42         ` Junio C Hamano
2008-06-03  8:31           ` Johannes Schindelin
2008-06-03 10:40       ` SZEDER Gábor
2008-06-03 19:30         ` Junio C Hamano
2008-06-03 20:39           ` SZEDER Gábor
2008-06-03 22:08             ` Junio C Hamano
2008-06-03 23:10               ` SZEDER Gábor
2008-06-04  0:35                 ` Jeff King
2008-06-04  1:02                 ` Junio C Hamano
2008-06-03 14:40     ` Linus Torvalds
2008-06-03 23:11       ` Miklos Vajna
2008-06-04  0:33         ` Junio C Hamano
2008-06-03  4:29   ` Junio C Hamano
2008-06-03  6:39     ` Jakub Narebski
2008-06-03  7:11       ` Junio C Hamano
2008-06-03  7:32   ` Jakub Narebski
2008-06-03  7:53     ` Junio C Hamano
2008-06-03 19:54     ` Linus Torvalds
2008-06-03 20:27       ` Commit annotations (was:: Octopus merge: unique (?) to git, but is it useful?) Jakub Narebski
2008-06-03 20:33         ` Johannes Schindelin
2008-06-03 23:59           ` Johan Herland
2008-06-03  2:16 ` Octopus merge: unique (?) to git, but is it useful? Daniel Villeneuve
2008-06-03 10:06 ` Matthieu Moy
2008-06-03 11:27   ` Jakub Narebski
2008-06-03 11:53     ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v3anv5fy3.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.