From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Pierre Habouzit <madcoder@debian.org>,
Daniel Barkalow <barkalow@iabervon.org>,
Alex Riesen <raa.lkml@gmail.com>
Subject: Re: [PATCH v2 3/3] send-pack: assign remote errors to each ref
Date: Tue, 13 Nov 2007 22:12:06 -0800 [thread overview]
Message-ID: <7vabphnyo9.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0711140159550.4362@racer.site> (Johannes Schindelin's message of "Wed, 14 Nov 2007 02:01:14 +0000 (GMT)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> > 2. the status parsing is not foolproof. We get a line like
>> >
>> > ng refs/heads/master arbitrary msg
>> >
>> > which cannot be parsed unambiguously in the face of
>> > refnames with spaces.
>
> Since when can refnames contain spaces? In my copy of git, bad_ref_char()
> in refs.c returns 1 if ch <= ' '. It's the first error path, even.
Bah. You are right.
next prev parent reply other threads:[~2007-11-14 6:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 10:25 [RFC/PATCH 0/3] tracking per-ref errors on push Jeff King
2007-11-13 10:27 ` [PATCH/RFC 1/3] send-pack: track errors for each ref Jeff King
2007-11-13 11:32 ` Jeff King
2007-11-13 19:04 ` Alex Riesen
2007-11-13 22:30 ` Jeff King
2007-11-13 20:18 ` Alex Riesen
2007-11-13 10:27 ` [PATCH/RFC 2/3] send-pack: check ref->status before updating tracking refs Jeff King
2007-11-13 10:29 ` [PATCH/RFC 3/3] send-pack: assign remote errors to each ref Jeff King
2007-11-13 10:29 ` Jeff King
2007-11-13 11:34 ` [RFC/PATCH 0/3] tracking per-ref errors on push Jeff King
2007-11-13 11:36 ` [PATCH v2 1/3] send-pack: track errors for each ref Jeff King
2007-11-13 11:36 ` [PATCH v2 2/3] send-pack: check ref->status before updating tracking refs Jeff King
2007-11-13 11:37 ` [PATCH v2 3/3] send-pack: assign remote errors to each ref Jeff King
2007-11-14 1:41 ` Junio C Hamano
2007-11-14 1:56 ` Junio C Hamano
2007-11-14 2:01 ` Johannes Schindelin
2007-11-14 6:12 ` Junio C Hamano [this message]
2007-11-15 4:54 ` Jeff King
2007-11-16 5:05 ` Junio C Hamano
2007-11-15 4:47 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabphnyo9.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.