From: Junio C Hamano <junkio@cox.net>
To: Peter Baumann <waste.manager@gmx.de>
Cc: Julian Phillips <julian@quantumfyre.co.uk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add test for symlinked .git/packed-refs
Date: Wed, 18 Apr 2007 23:06:45 -0700 [thread overview]
Message-ID: <7vabx499u2.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070419053518.GK5913@xp.machine.xx> (Peter Baumann's message of "Thu, 19 Apr 2007 07:35:18 +0200")
Peter Baumann <waste.manager@gmx.de> writes:
> Signed-off-by: Peter Baumann <waste.manager@gmx.de>
> ---
> On Wed, Apr 18, 2007 at 02:31:29PM -0700, Junio C Hamano wrote:
>>
>> Oh, I never questioned that you made that basic case work. I
>> was worried about not making sure the symlink we are looking at
>> really is the case we are willing to handle, and not erroring
>> out if that is not the case, perhaps like the attached patch on
>> top of yours.
>>
>> An additional test or two in t/t3210 would be nice to accompany
>> this change.
>>
>
> Something like this?
That's a good start, but I expected to see at least tests for
two cases: a case in which .git/packed-refs symlink points at an
actual file (i.e. the original repository has run pack-refs) and
another case in which .git/packed-refs symlink is dangling
(i.e. the original repository hasn't run pack-refs). I
understand that the borrower "worktree" can have .git/packed-refs
symlink pointing at the repositories .git/packed-refs yet to be
born.
next prev parent reply other threads:[~2007-04-19 6:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 16:17 [BUG] git-new-workdir doesn't understand packed refs Peter Baumann
2007-04-17 21:55 ` Julian Phillips
2007-04-18 5:52 ` Peter Baumann
2007-04-18 7:26 ` Julian Phillips
2007-04-18 7:40 ` Junio C Hamano
2007-04-18 8:11 ` Peter Baumann
2007-04-18 11:55 ` Julian Phillips
2007-04-18 16:23 ` Junio C Hamano
2007-04-18 17:43 ` Peter Baumann
2007-04-18 18:17 ` Junio C Hamano
2007-04-18 18:31 ` Peter Baumann
2007-04-18 18:42 ` Junio C Hamano
2007-04-18 21:08 ` Peter Baumann
2007-04-18 21:31 ` Junio C Hamano
2007-04-19 5:35 ` [PATCH] Add test for symlinked .git/packed-refs Peter Baumann
2007-04-19 6:06 ` Junio C Hamano [this message]
2007-04-20 16:52 ` [PATCH] pack-refs: dereference .git/packed-refs if it is a symlink Peter Baumann
2007-04-21 20:05 ` Junio C Hamano
2007-04-18 18:43 ` [BUG] git-new-workdir doesn't understand packed refs Julian Phillips
2007-04-18 10:28 ` [PATCH] pack-refs: dereference .git/packed-refs if it is a symlink Peter Baumann
2007-04-18 16:09 ` Linus Torvalds
2007-04-18 17:47 ` Peter Baumann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabx499u2.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=julian@quantumfyre.co.uk \
--cc=waste.manager@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.