All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Petr Baudis <pasky@suse.cz>
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>, git@vger.kernel.org
Subject: Re: [PATCH] Mention the fact that 'git annotate' is only for backward compatibility.
Date: Thu, 04 Sep 2008 12:12:40 -0700	[thread overview]
Message-ID: <7vd4jj3etz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20080904123046.GX10544@machine.or.cz

Petr Baudis <pasky@suse.cz> writes:

> I'm also curious about
>
>                 if (suspect->commit->object.flags & UNINTERESTING) {
>                         if (blank_boundary)
>                                 memset(hex, ' ', length);
>                         else if (!cmd_is_annotate) {
>                                 length--;
>                                 putchar('^');
>                         }
>                 }
>
> in builtin-blame.c. Junio, you introduced this in e68989a739d - why
> do you use a separate flag instead of OUTPUT_ANNOTATE_COMPAT? The fact
> that git annotate == git blame -c does not hold true because of this
> (admittedly obscure case).

I do not recall the context of this change, but I do not think this is a
deliberate omission.  The breakage the quoted commit fixed was about
cvsserver that does run "git-annotate" not "git-blame -c" and that must be
the reason this has been unnoticed for a long time.

Oh, by the way, somebody should update cvsserver to run "git annotate" and
send in a tested patch, please?

  parent reply	other threads:[~2008-09-04 19:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03 16:43 blame vs annotate? Jonathan del Strother
2008-09-03 17:49 ` Miklos Vajna
2008-09-03 17:54   ` Petr Baudis
2008-09-03 18:10 ` Junio C Hamano
2008-09-04  9:09   ` Matthieu Moy
2008-09-04  9:16     ` Sverre Rabbelier
2008-09-04 12:00       ` [PATCH] Mention the fact that 'git annotate' is only for backward compatibility Matthieu Moy
2008-09-04 12:30         ` Petr Baudis
2008-09-04 13:03           ` Matthieu Moy
2008-09-04 19:12           ` Junio C Hamano [this message]
2008-09-04 19:17           ` Junio C Hamano
2008-09-05  6:31             ` Matthieu Moy
2008-09-05  7:29               ` Junio C Hamano
2008-09-05  8:07                 ` Petr Baudis
2008-09-05 12:06                   ` Matthieu Moy
2008-09-05  7:56           ` Junio C Hamano
2008-09-03 18:11 ` blame vs annotate? Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd4jj3etz.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@imag.fr \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.