From: Junio C Hamano <gitster@pobox.com>
To: Michal Rokos <michal.rokos@nextsoft.cz>
Cc: GIT <git@vger.kernel.org>
Subject: Re: [PATCH] Configure test for FREAD_READS_DIRECTORIES
Date: Wed, 05 Mar 2008 09:57:22 -0800 [thread overview]
Message-ID: <7vd4q9njel.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 200803041248.54197.michal.rokos@nextsoft.cz
Michal Rokos <michal.rokos@nextsoft.cz> writes:
> Will do... Did that.
>
> Do you think that there's some reason not-to merge it?
Yes, if you meant "apply as-is" by "merge it". No, if you meant "apply
after an initial round of sanity checks, even if it is not perfect".
I was hoping that with this approach, in a week after you sent
out your call-for-help-in-testing, you could send a version for
inclusion with a commit log message that says "tested on X (by
Foo), Y (by Bar),...", with the patch text that is exactly the
same as what people tested. The point is not to make that list
of platforms exhaustive, but at least make it a bit more than
"works for me".
And I think that plan has worked well.
prev parent reply other threads:[~2008-03-05 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 9:48 [PATCH] Configure test for FREAD_READS_DIRECTORIES Michal Rokos
2008-03-04 11:03 ` Junio C Hamano
2008-03-04 11:17 ` Michal Rokos
2008-03-04 11:32 ` Junio C Hamano
2008-03-04 11:48 ` Michal Rokos
2008-03-04 12:17 ` Jakub Narebski
2008-03-05 17:57 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4q9njel.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=michal.rokos@nextsoft.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.