Re: [PATCH] Configure test for FREAD_READS_DIRECTORIES

[Jakub Narebski <jnareb@gmail.com>]

Michal Rokos <michal.rokos@nextsoft.cz> writes:
 
> I don't know how many people care about configure script since
> there are missing bits in it again and again. I believe it could
> receive good amount of testing only when it's merged in.

Because configure script is optional, people do tend to forget to add
test to it, when adding new compile configuration option.
Configuration is mainly done by guessing based on uname.

Unfortunately we don't have maintainer for configure script, who would
catch new make configuration options, and add appropriate tests to
./configure.

> I'm trying to make GIT working on HPUX - next patch in my queue is
> about broken vsnprintf() that returns -1 on maxsize overrun. Do you
> think that it's more likely that patch will be accepted when I omit
> "broken vsnprintf()" detection code from configure.ac?

I think it would be better to split patch into two: one adding build
option, or setting it for given operating system or operating system
version, and one adding test to ./configure script.  It is much
simplier to test first patch; the patch to configure needs more
review, as it should work correctly on all operating systems.

-- 
Jakub Narebski
Poland
ShadeHawk on #git