From: Junio C Hamano <gitster@pobox.com>
To: "Ray Chuan" <rctay89@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] http-push: remove MOVE step after PUT when sending objects to server
Date: Sat, 17 Jan 2009 16:48:57 -0800 [thread overview]
Message-ID: <7viqod5thi.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <be6fef0d0901171224y35c3d95cn2d38639ac03c3b8f@mail.gmail.com> (Ray Chuan's message of "Sat, 17 Jan 2009 20:24:47 +0000")
"Ray Chuan" <rctay89@gmail.com> writes:
> Currently, git PUTs to
>
> /repo.git/objects/1a/1a2b...9z_opaquelocktoken:1234-....
>
> then MOVEs to
>
> /repo.git/objects/1a/1a2b...9z
>
> This is needless. In fact, the only time MOVE requests are sent is for
> this sole purpose (ie. of renaming an object).
>
> A concern raised was repository corruption in the event of failure
> during PUT. "put && move" won't afford any more protection than using
> simply "put", since info/refs is not updated if a PUT fails, so there
> is no cause for concern.
That's a completely bogus reasoning. Normal operation inside the
repository that was pushed into won't look at info/refs at all.
The true reason you want to avoid put-then-move is...?
next prev parent reply other threads:[~2009-01-18 0:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 20:24 [PATCH 2/2] http-push: remove MOVE step after PUT when sending objects to server Ray Chuan
2009-01-18 0:48 ` Junio C Hamano [this message]
2009-01-18 3:19 ` Ray Chuan
2009-01-18 13:32 ` Johannes Schindelin
2009-01-18 20:05 ` Junio C Hamano
2009-01-18 21:14 ` Johannes Schindelin
2009-01-18 21:43 ` Junio C Hamano
2009-01-18 21:58 ` Johannes Schindelin
2009-01-19 0:12 ` Sverre Rabbelier
2009-01-19 3:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqod5thi.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.