From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Ray Chuan <rctay89@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] http-push: remove MOVE step after PUT when sending objects to server
Date: Sun, 18 Jan 2009 12:05:21 -0800 [thread overview]
Message-ID: <7vocy4wfb2.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0901181425420.3586@pacific.mpi-cbg.de> (Johannes Schindelin's message of "Sun, 18 Jan 2009 14:32:30 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> The point is: the repository inside the document root of the web server is
> still a valid repository.
>
> And the assumption is that whenever you have a file that looks like a
> valid object/pack inside a valid repository, that it does not need
> replacing.
>
> So even when optimizing the uncommon (HTTP push is 2nd class citizen), we
> have to keep the common workflow intact (1st class citizens _are_ push by
> file system, ssh or git://).
The first class citizens are "local use", not "copying out of the area
that looks like a repository only to http:// transport users".
> Which unfortunately means that put && move must stay.
I still do not understand why it is unfortunate.
As far as I understand, Ray's issue was that his filesystem did not like
the temporary file name that is used for the initial "put" phase because
it contained a character it did not like (colon, perhaps). Why isn't the
patch about changing _that_ single issue?
next prev parent reply other threads:[~2009-01-18 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 20:24 [PATCH 2/2] http-push: remove MOVE step after PUT when sending objects to server Ray Chuan
2009-01-18 0:48 ` Junio C Hamano
2009-01-18 3:19 ` Ray Chuan
2009-01-18 13:32 ` Johannes Schindelin
2009-01-18 20:05 ` Junio C Hamano [this message]
2009-01-18 21:14 ` Johannes Schindelin
2009-01-18 21:43 ` Junio C Hamano
2009-01-18 21:58 ` Johannes Schindelin
2009-01-19 0:12 ` Sverre Rabbelier
2009-01-19 3:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vocy4wfb2.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.